mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Mike Frysinger" <vapier.adi@gmail.com>
To: "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	linux-serial@vger.kernel.org,
	"Robin Getz" <rgetz@blackfin.uclinux.org>
Subject: Re: should RTS init in serial core be tied to CRTSCTS
Date: Mon, 5 Mar 2007 13:13:14 -0500	[thread overview]
Message-ID: <8bd0f97a0703051013u5732e127t598ae008e6f5894@mail.gmail.com> (raw)
In-Reply-To: <20070305175604.GB18548@flint.arm.linux.org.uk>

On 3/5/07, Russell King <rmk+lkml@arm.linux.org.uk> wrote:
> On Mon, Mar 05, 2007 at 12:09:20PM -0500, Mike Frysinger wrote:
> > On 3/4/07, Russell King <rmk+lkml@arm.linux.org.uk> wrote:
> > >On Thu, Mar 01, 2007 at 07:03:02PM -0500, Mike Frysinger wrote:
> > >> the console= bootcmd allows for controlling of the initial state of
> > >> flow control by adding/omitting the 'r' suffix ...
> > >
> > >The console command *only* sets the state for the kernel's use of one
> > >serial port.  It does not affect any other serial port, so tying
> > >random RTS behaviours into that command line option is absolutely
> > >silly.
> >
> > true ... so ignoring the original motivation for change i posted, is
> > it really correct for the serial core to be forcing TIOCM_RTS at uart
> > startup even though the uart doesnt have CTSRTS flow control enabled ?
> > in other words, my change is agnostic of the console, and is done for
> > all uarts ... it should prob have a similar change in uart_shutdown()
> > though ...
>
> No idea - it's something that Linux has always done.  Neither do I have
> any idea if changing it will break anyones setup.  However, since I don't
> maintain serial anymore, I'm not about to start playing about with this
> trying to find out.

ok, i was going by Documentation/serial/driver:
... any questions you have should be directed to <rmk@arm.linux.org.uk>
guessing that should be updated ? :)

> Feel free to submit a patch to akpm to leave RTS alone when CRTSCTS is
> not set.  I'd recommend that it sits in -mm for about 6 months to really
> get an idea if it breaks anything.

sounds good to me, thanks
-mike

  reply	other threads:[~2007-03-05 18:13 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-02  0:03 Mike Frysinger
2007-03-04 16:20 ` Robin Getz
2007-03-04 19:46 ` Russell King
2007-03-04 20:42   ` Robin Getz
2007-03-05  8:39     ` Russell King
2007-03-05 17:09   ` Mike Frysinger
2007-03-05 17:56     ` Russell King
2007-03-05 18:13       ` Mike Frysinger [this message]
2007-03-06 20:40 ` Krzysztof Halasa
2007-03-06 23:24   ` Robin Getz
2007-03-07 12:46     ` Krzysztof Halasa
2007-03-07 13:38       ` Oleksiy Kebkal
2007-03-07 15:19       ` Robin Getz
2007-03-07 21:30         ` Oleksiy Kebkal
2007-03-08 13:44           ` Robin Getz
2007-03-08 13:48             ` Russell King
2007-03-08 14:16               ` Carl-Daniel Hailfinger
2007-03-08 14:20                 ` Russell King
2007-03-08 16:51                 ` Krzysztof Halasa
2007-03-08 18:43                   ` Tosoni
2007-03-09 20:39                     ` Krzysztof Halasa
2007-03-12  9:22                       ` Tosoni
2007-03-12 12:59                         ` Krzysztof Halasa
2007-03-08 14:23               ` Oleksiy Kebkal
2007-03-08 14:28                 ` Russell King
2007-03-08 14:40                   ` Oleksiy Kebkal
2007-03-08 14:25               ` Oleksiy Kebkal
2007-03-08 20:23               ` Robin Getz
2007-03-08 20:40                 ` Russell King
2007-03-08 23:32                   ` Robin Getz
2007-03-09  8:57                     ` Russell King
2007-03-09 14:18                   ` Oleksiy Kebkal
2007-03-07 12:54     ` Oleksiy Kebkal
2007-03-07 13:03       ` Krzysztof Halasa
2007-03-07 20:04         ` Mike Frysinger
2007-03-07  5:13   ` Oleksiy Kebkal
2007-03-07 12:48     ` Krzysztof Halasa
2007-03-05  8:23 Oleksiy Kebkal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8bd0f97a0703051013u5732e127t598ae008e6f5894@mail.gmail.com \
    --to=vapier.adi@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=rgetz@blackfin.uclinux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®