Re: [PATCH v2] firmware: only allow EDD on x86/x86_64

[Mike Frysinger <vapier.adi@gmail.com>]

On Tue, Oct 6, 2009 at 03:07, Takashi Iwai wrote:
> At Tue,  6 Oct 2009 01:57:07 -0400,
>> Rather than have the EDD depend on !ia64 (and assuming that only ia64,
>> x86, x86_64 will be including this Kconfig), have EDD depend on the only
>> arches which can support this code.  This should allow all other arches
>> to cleanly include the firmware Kconfig.
>>
>> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
>> ---
>> v2
>>       - send out the right file this time
>>
>>  drivers/firmware/Kconfig |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig
>> index ebb9e51..7fff33f 100644
>> --- a/drivers/firmware/Kconfig
>> +++ b/drivers/firmware/Kconfig
>> @@ -7,7 +7,7 @@ menu "Firmware Drivers"
>>
>>  config EDD
>>       tristate "BIOS Enhanced Disk Drive calls determine boot disk"
>> -     depends on !IA64
>> +     depends on (X86_64 || X86_32)
>
> How about "depends on X86" ?

i merely copied the string as seen in FIRMWARE_MEMMAP ... i assumed
that was the way to go.  if simply using x86 works, then i can change
it to that.
-mike