From: Takashi Iwai <tiwai@suse.de>
To: Mike Frysinger <vapier@gentoo.org>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] firmware: only allow EDD on x86/x86_64
Date: Tue, 06 Oct 2009 09:07:54 +0200 [thread overview]
Message-ID: <s5h8wfprodx.wl%tiwai@suse.de> (raw)
In-Reply-To: <1254808627-3889-1-git-send-email-vapier@gentoo.org>
At Tue, 6 Oct 2009 01:57:07 -0400,
Mike Frysinger wrote:
>
> Rather than have the EDD depend on !ia64 (and assuming that only ia64,
> x86, x86_64 will be including this Kconfig), have EDD depend on the only
> arches which can support this code. This should allow all other arches
> to cleanly include the firmware Kconfig.
>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> ---
> v2
> - send out the right file this time
>
> drivers/firmware/Kconfig | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig
> index ebb9e51..7fff33f 100644
> --- a/drivers/firmware/Kconfig
> +++ b/drivers/firmware/Kconfig
> @@ -7,7 +7,7 @@ menu "Firmware Drivers"
>
> config EDD
> tristate "BIOS Enhanced Disk Drive calls determine boot disk"
> - depends on !IA64
> + depends on (X86_64 || X86_32)
How about "depends on X86" ?
Takashi
next prev parent reply other threads:[~2009-10-06 7:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-06 5:55 [PATCH] " Mike Frysinger
2009-10-06 5:57 ` [PATCH v2] " Mike Frysinger
2009-10-06 7:07 ` Takashi Iwai [this message]
2009-10-06 7:21 ` Mike Frysinger
2009-10-06 7:40 ` [PATCH v3] firmware: only allow EDD on x86 Mike Frysinger
2009-10-06 17:44 ` Matt Domsch
2009-10-06 21:21 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h8wfprodx.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®