Re: [PATCH v4][mmc/host]:Blackfin SD Host Controller Driver

[Mike Frysinger <vapier.adi@gmail.com>]

On Wed, Nov 25, 2009 at 17:43, Andrew Morton wrote:
> On Wed, 25 Nov 2009 17:25:20 -0500 Mike Frysinger wrote:
>> > Arguably wrong from a coding-style POV and looks weird IMO. __Adds a bit
>> > of risk that subsequent coders will think they're writing in python adn
>> > will add bugs.
>>
>> i dont really get what you're referring to here.  the code in question
>> looks ifne to me, and i dont see anything "python-esque" about it
>
> Code like
>
>        if (expr) {
>                line1;
>                line2;
>        } else
>                line3;
>
> looks odd and can cause people to later add bugs along the lines of
>
>        if (expr) {
>                line1;
>                line2;
>        } else
> +               line3a;
>                line3;
>
> this is particularly the case if line3 is long, or is preceded by a
> comment.  This has happened in the past.
>
> Adding the missing braces reduces the risk that this will occur.

*shrug* people can screw up braces regardless of how many statements
and/or branches there are.  i doubt people are going to get confused
and think kernel code is python, but if you really want to be pedantic
about braces, doesnt matter that much to me.
-mike