mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier.adi@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: cliffcai.sh@gmail.com, linux-mmc@vger.kernel.org,
	linux-kernel@vger.kernel.org, cliff.cai@analog.com,
	Bryan Wu <cooloney@kernel.org>,
	Mike Frysinger <vapier@gentoo.org>
Subject: Re: [PATCH v4][mmc/host]:Blackfin SD Host Controller Driver
Date: Thu, 3 Dec 2009 21:08:58 -0500	[thread overview]
Message-ID: <8bd0f97a0912031808p5032f8c8i804d72dfad5b51b2@mail.gmail.com> (raw)
In-Reply-To: <20091125140422.cdee4a0d.akpm@linux-foundation.org>

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=UTF-8, Size: 2173 bytes --]

On Wed, Nov 25, 2009 at 17:04, Andrew Morton wrote:> --- a/drivers/mmc/host/bfin_sdh.c~blackfin-sd-host-controller-driver-fix> +++ a/drivers/mmc/host/bfin_sdh.c> @@ -149,15 +149,17 @@ static int sdh_setup_data(struct sdh_hos>        sdh_enable_stat_irq(host, (DAT_CRC_FAIL | DAT_TIME_OUT | DAT_END));>        host->dma_len = dma_map_sg(mmc_dev(host->mmc), data->sg, data->sg_len, host->dma_dir);>  #if defined(CONFIG_BF54x)> -       int i;>        dma_cfg |= DMAFLOW_ARRAY | NDSIZE_5 | RESTART | WDSIZE_32 | DMAEN;> -       for_each_sg(data->sg, sg, host->dma_len, i) {> -               host->sg_cpu[i].start_addr = sg_dma_address(sg);> -               host->sg_cpu[i].cfg = dma_cfg;> -               host->sg_cpu[i].x_count = sg_dma_len(sg) / 4;> -               host->sg_cpu[i].x_modify = 4;> -               dev_dbg(mmc_dev(host->mmc), "%d: start_addr:0x%lx, cfg:0x%x, x_count:0x%x,\> -                               x_modify:0x%x\n", i, host->sg_cpu[i].start_addr,> +       {> +               int i;> +               for_each_sg(data->sg, sg, host->dma_len, i) {> +                       host->sg_cpu[i].start_addr = sg_dma_address(sg);> +                       host->sg_cpu[i].cfg = dma_cfg;> +                       host->sg_cpu[i].x_count = sg_dma_len(sg) / 4;> +                       host->sg_cpu[i].x_modify = 4;> +                       dev_dbg(mmc_dev(host->mmc), "%d: start_addr:0x%lx, "> +                               "cfg:0x%x, x_count:0x%x, x_modify:0x%x\n",> +                               i, host->sg_cpu[i].start_addr,>                                host->sg_cpu[i].cfg, host->sg_cpu[i].x_count,>                                host->sg_cpu[i].x_modify);>        }
this change also has an error in it ... the new opening brace bracestole the closing brace from the for_each_sg()-mikeÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

      parent reply	other threads:[~2009-12-04  2:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-25 15:19 cliffcai.sh
2009-11-25 22:04 ` Andrew Morton
2009-11-25 22:25   ` Mike Frysinger
2009-11-25 22:43     ` Andrew Morton
2009-11-29 21:39       ` Mike Frysinger
2009-12-04  2:08   ` Mike Frysinger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8bd0f97a0912031808p5032f8c8i804d72dfad5b51b2@mail.gmail.com \
    --to=vapier.adi@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=cliff.cai@analog.com \
    --cc=cliffcai.sh@gmail.com \
    --cc=cooloney@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®