mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v2] drm/mediatek: hdmi: Convert DRM_ERROR() to drm_err()
@ 2026-04-20  6:45 sai madhu
  2026-05-08  8:25 ` CK Hu (胡俊光)
  2026-05-13 14:44 ` Chun-Kuang Hu
  0 siblings, 2 replies; 4+ messages in thread
From: sai madhu @ 2026-04-20  6:45 UTC (permalink / raw)
  To: Chun-Kuang Hu
  Cc: Philipp Zabel, dri-devel, linux-mediatek, linux-kernel,
	linux-arm-kernel, sai madhu

The DRM_ERROR() macro is deprecated in favor of drm_err() which
provides device-specific logging.

Replace DRM_ERROR() with drm_err() in the Mediatek HDMI bridge
driver and pass the drm_device pointer via bridge->dev.

No functional change intended.

Signed-off-by: sai madhu <suryasaimadhu369@gmail.com>
---
 drivers/gpu/drm/mediatek/mtk_hdmi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c
index 1ea259854780..4ddcdbf7bc8c 100644
--- a/drivers/gpu/drm/mediatek/mtk_hdmi.c
+++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c
@@ -981,8 +981,8 @@ static int mtk_hdmi_bridge_attach(struct drm_bridge *bridge,
 	int ret;
 
 	if (!(flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR)) {
-		DRM_ERROR("%s: The flag DRM_BRIDGE_ATTACH_NO_CONNECTOR must be supplied\n",
-			  __func__);
+		drm_err(bridge->dev,
+			"DRM_BRIDGE_ATTACH_NO_CONNECTOR must be supplied\n");
 		return -EINVAL;
 	}
 
-- 
2.34.1


^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH v2] drm/mediatek: hdmi: Convert DRM_ERROR() to drm_err()
  2026-04-20  6:45 [PATCH v2] drm/mediatek: hdmi: Convert DRM_ERROR() to drm_err() sai madhu
@ 2026-05-08  8:25 ` CK Hu (胡俊光)
  2026-05-13 14:44 ` Chun-Kuang Hu
  1 sibling, 0 replies; 4+ messages in thread
From: CK Hu (胡俊光) @ 2026-05-08  8:25 UTC (permalink / raw)
  To: chunkuang.hu, suryasaimadhu369
  Cc: p.zabel, dri-devel, linux-mediatek, linux-arm-kernel, linux-kernel

On Mon, 2026-04-20 at 06:45 +0000, sai madhu wrote:
> External email : Please do not click links or open attachments until you have verified the sender or the content.
> 
> 
> The DRM_ERROR() macro is deprecated in favor of drm_err() which
> provides device-specific logging.
> 
> Replace DRM_ERROR() with drm_err() in the Mediatek HDMI bridge
> driver and pass the drm_device pointer via bridge->dev.
> 
> No functional change intended.

Reviewed-by: CK Hu <ck.hu@mediatek.com>

> 
> Signed-off-by: sai madhu <suryasaimadhu369@gmail.com>
> ---
>  drivers/gpu/drm/mediatek/mtk_hdmi.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> index 1ea259854780..4ddcdbf7bc8c 100644
> --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> @@ -981,8 +981,8 @@ static int mtk_hdmi_bridge_attach(struct drm_bridge *bridge,
>         int ret;
> 
>         if (!(flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR)) {
> -               DRM_ERROR("%s: The flag DRM_BRIDGE_ATTACH_NO_CONNECTOR must be supplied\n",
> -                         __func__);
> +               drm_err(bridge->dev,
> +                       "DRM_BRIDGE_ATTACH_NO_CONNECTOR must be supplied\n");
>                 return -EINVAL;
>         }
> 
> --
> 2.34.1
> 


^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH v2] drm/mediatek: hdmi: Convert DRM_ERROR() to drm_err()
  2026-04-20  6:45 [PATCH v2] drm/mediatek: hdmi: Convert DRM_ERROR() to drm_err() sai madhu
  2026-05-08  8:25 ` CK Hu (胡俊光)
@ 2026-05-13 14:44 ` Chun-Kuang Hu
  1 sibling, 0 replies; 4+ messages in thread
From: Chun-Kuang Hu @ 2026-05-13 14:44 UTC (permalink / raw)
  To: sai madhu
  Cc: Chun-Kuang Hu, Philipp Zabel, dri-devel, linux-mediatek,
	linux-kernel, linux-arm-kernel

Hi, sai:

sai madhu <suryasaimadhu369@gmail.com> 於 2026年4月20日週一 上午6:45寫道：
>
> The DRM_ERROR() macro is deprecated in favor of drm_err() which
> provides device-specific logging.
>
> Replace DRM_ERROR() with drm_err() in the Mediatek HDMI bridge
> driver and pass the drm_device pointer via bridge->dev.
>
> No functional change intended.

Applied to mediatek-drm-next [1], thanks.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next

Regards,
Chun-Kuang.

>
> Signed-off-by: sai madhu <suryasaimadhu369@gmail.com>
> ---
>  drivers/gpu/drm/mediatek/mtk_hdmi.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> index 1ea259854780..4ddcdbf7bc8c 100644
> --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> @@ -981,8 +981,8 @@ static int mtk_hdmi_bridge_attach(struct drm_bridge *bridge,
>         int ret;
>
>         if (!(flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR)) {
> -               DRM_ERROR("%s: The flag DRM_BRIDGE_ATTACH_NO_CONNECTOR must be supplied\n",
> -                         __func__);
> +               drm_err(bridge->dev,
> +                       "DRM_BRIDGE_ATTACH_NO_CONNECTOR must be supplied\n");
>                 return -EINVAL;
>         }
>
> --
> 2.34.1
>

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [PATCH v2] drm/mediatek: hdmi: Convert DRM_ERROR() to drm_err()
@ 2026-04-17 12:27 sai madhu
  0 siblings, 0 replies; 4+ messages in thread
From: sai madhu @ 2026-04-17 12:27 UTC (permalink / raw)
  To: Chun-Kuang Hu
  Cc: Philipp Zabel, dri-devel, linux-mediatek, linux-kernel,
	linux-arm-kernel, sai madhu

The DRM_ERROR() macro is deprecated in favor of drm_err() which
provides device-specific logging.

Replace DRM_ERROR() with drm_err() in the Mediatek HDMI bridge
driver and pass the drm_device pointer via bridge->dev.

No functional change intended.

Signed-off-by: sai madhu <suryasaimadhu369@gmail.com>
---
 drivers/gpu/drm/mediatek/mtk_hdmi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c
index 1ea259854780..4ddcdbf7bc8c 100644
--- a/drivers/gpu/drm/mediatek/mtk_hdmi.c
+++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c
@@ -981,8 +981,8 @@ static int mtk_hdmi_bridge_attach(struct drm_bridge *bridge,
 	int ret;
 
 	if (!(flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR)) {
-		DRM_ERROR("%s: The flag DRM_BRIDGE_ATTACH_NO_CONNECTOR must be supplied\n",
-			  __func__);
+		drm_err(bridge->dev,
+			"DRM_BRIDGE_ATTACH_NO_CONNECTOR must be supplied\n");
 		return -EINVAL;
 	}
 
-- 
2.34.1


^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-05-13 14:44 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-04-20  6:45 [PATCH v2] drm/mediatek: hdmi: Convert DRM_ERROR() to drm_err() sai madhu
2026-05-08  8:25 ` CK Hu (胡俊光)
2026-05-13 14:44 ` Chun-Kuang Hu
  -- strict thread matches above, loose matches on Subject: below --
2026-04-17 12:27 sai madhu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®