mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Shawn Lin <shawn.lin@rock-chips.com>
To: iav@iav.lv, Heiko Stuebner <heiko@sntech.de>
Cc: shawn.lin@rock-chips.com, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: rockchip: Enable HS400 enhanced strobe on Kobol Helios64 eMMC
Date: Sun, 11 Oct 2026 09:49:39 +0800	[thread overview]
Message-ID: <8bf7a001-8b65-4129-8b41-a2986bb78643@rock-chips.com> (raw)
In-Reply-To: <20261011-b4-helios64-emmc-hs400-v1-1-36951d319229@iav.lv>

在 2026/10/11 星期日 5:52, Igor Velkov via B4 Relay 写道:
> From: Igor Velkov <iav@iav.lv>
> 
> The eMMC of Helios64 runs in HS200. Run it in HS400 enhanced strobe at
> 150 MHz, as on Gru. The strobe line goes straight from the SoC to the
> DS pin of the eMMC with no pull-down on the board, so enable the one
> in the eMMC PHY.
> 

Reviewed-by: Shawn Lin <shawn.lin@rock-chips.com>

> Assisted-by: LLM
> Signed-off-by: Igor Velkov <iav@iav.lv>
> ---
> Schematic, sheet 14:
> https://wiki.kobol.io/helios64/files/schematics/Helios64_Schematics_Rev1.2.pdf
> 
> Tested on mainline with three 2 GiB write and read-back passes, no
> errors. Raw reads go from 180 MB/s in HS200 to 247 MB/s. Without the
> pull-down, writes dropped to about 1 MB/s with repeated
> "mmc1: running CQE recovery".
> ---
>   arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts b/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts
> index 63ad79b4c8ac..f78482c4c285 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts
> @@ -320,6 +320,7 @@ &cpu_l3 {
>   };
>   
>   &emmc_phy {
> +	rockchip,enable-strobe-pulldown;
>   	status = "okay";
>   };
>   
> @@ -586,8 +587,11 @@ &saradc {
>   };
>   
>   &sdhci {
> +	assigned-clock-rates = <150000000>;
>   	bus-width = <8>;
>   	mmc-hs200-1_8v;
> +	mmc-hs400-1_8v;
> +	mmc-hs400-enhanced-strobe;
>   	non-removable;
>   	vqmmc-supply = <&vcc1v8_sys_s0>;
>   	status = "okay";
> 
> ---
> base-commit: d2abcbb905b0e4b2e06b257fa1e5bcf4faa6dbda
> change-id: 20261011-b4-helios64-emmc-hs400-9c784f35d8dd
> 
> Best regards,


  reply	other threads:[~2026-10-11  4:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-10 21:52 Igor Velkov via B4 Relay
2026-10-11  1:49 ` Shawn Lin [this message]
2026-11-01 22:15 ` Heiko Stuebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8bf7a001-8b65-4129-8b41-a2986bb78643@rock-chips.com \
    --to=shawn.lin@rock-chips.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=iav@iav.lv \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®