mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: rockchip: Enable HS400 enhanced strobe on Kobol Helios64 eMMC
@ 2026-10-10 21:52 Igor Velkov via B4 Relay
  2026-10-11  1:49 ` Shawn Lin
  2026-11-01 22:15 ` Heiko Stuebner
  0 siblings, 2 replies; 3+ messages in thread
From: Igor Velkov via B4 Relay @ 2026-10-10 21:52 UTC (permalink / raw)
  To: Heiko Stuebner
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, devicetree,
	linux-arm-kernel, linux-rockchip, linux-kernel, Igor Velkov

From: Igor Velkov <iav@iav.lv>

The eMMC of Helios64 runs in HS200. Run it in HS400 enhanced strobe at
150 MHz, as on Gru. The strobe line goes straight from the SoC to the
DS pin of the eMMC with no pull-down on the board, so enable the one
in the eMMC PHY.

Assisted-by: LLM
Signed-off-by: Igor Velkov <iav@iav.lv>
---
Schematic, sheet 14:
https://wiki.kobol.io/helios64/files/schematics/Helios64_Schematics_Rev1.2.pdf

Tested on mainline with three 2 GiB write and read-back passes, no
errors. Raw reads go from 180 MB/s in HS200 to 247 MB/s. Without the
pull-down, writes dropped to about 1 MB/s with repeated
"mmc1: running CQE recovery".
---
 arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts b/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts
index 63ad79b4c8ac..f78482c4c285 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts
@@ -320,6 +320,7 @@ &cpu_l3 {
 };
 
 &emmc_phy {
+	rockchip,enable-strobe-pulldown;
 	status = "okay";
 };
 
@@ -586,8 +587,11 @@ &saradc {
 };
 
 &sdhci {
+	assigned-clock-rates = <150000000>;
 	bus-width = <8>;
 	mmc-hs200-1_8v;
+	mmc-hs400-1_8v;
+	mmc-hs400-enhanced-strobe;
 	non-removable;
 	vqmmc-supply = <&vcc1v8_sys_s0>;
 	status = "okay";

---
base-commit: d2abcbb905b0e4b2e06b257fa1e5bcf4faa6dbda
change-id: 20261011-b4-helios64-emmc-hs400-9c784f35d8dd

Best regards,
-- 
Igor Velkov <iav@iav.lv>



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: dts: rockchip: Enable HS400 enhanced strobe on Kobol Helios64 eMMC
  2026-10-10 21:52 [PATCH] arm64: dts: rockchip: Enable HS400 enhanced strobe on Kobol Helios64 eMMC Igor Velkov via B4 Relay
@ 2026-10-11  1:49 ` Shawn Lin
  2026-11-01 22:15 ` Heiko Stuebner
  1 sibling, 0 replies; 3+ messages in thread
From: Shawn Lin @ 2026-10-11  1:49 UTC (permalink / raw)
  To: iav, Heiko Stuebner
  Cc: shawn.lin, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	devicetree, linux-arm-kernel, linux-rockchip, linux-kernel

在 2026/10/11 星期日 5:52, Igor Velkov via B4 Relay 写道:
> From: Igor Velkov <iav@iav.lv>
> 
> The eMMC of Helios64 runs in HS200. Run it in HS400 enhanced strobe at
> 150 MHz, as on Gru. The strobe line goes straight from the SoC to the
> DS pin of the eMMC with no pull-down on the board, so enable the one
> in the eMMC PHY.
> 

Reviewed-by: Shawn Lin <shawn.lin@rock-chips.com>

> Assisted-by: LLM
> Signed-off-by: Igor Velkov <iav@iav.lv>
> ---
> Schematic, sheet 14:
> https://wiki.kobol.io/helios64/files/schematics/Helios64_Schematics_Rev1.2.pdf
> 
> Tested on mainline with three 2 GiB write and read-back passes, no
> errors. Raw reads go from 180 MB/s in HS200 to 247 MB/s. Without the
> pull-down, writes dropped to about 1 MB/s with repeated
> "mmc1: running CQE recovery".
> ---
>   arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts b/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts
> index 63ad79b4c8ac..f78482c4c285 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts
> @@ -320,6 +320,7 @@ &cpu_l3 {
>   };
>   
>   &emmc_phy {
> +	rockchip,enable-strobe-pulldown;
>   	status = "okay";
>   };
>   
> @@ -586,8 +587,11 @@ &saradc {
>   };
>   
>   &sdhci {
> +	assigned-clock-rates = <150000000>;
>   	bus-width = <8>;
>   	mmc-hs200-1_8v;
> +	mmc-hs400-1_8v;
> +	mmc-hs400-enhanced-strobe;
>   	non-removable;
>   	vqmmc-supply = <&vcc1v8_sys_s0>;
>   	status = "okay";
> 
> ---
> base-commit: d2abcbb905b0e4b2e06b257fa1e5bcf4faa6dbda
> change-id: 20261011-b4-helios64-emmc-hs400-9c784f35d8dd
> 
> Best regards,


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: dts: rockchip: Enable HS400 enhanced strobe on Kobol Helios64 eMMC
  2026-10-10 21:52 [PATCH] arm64: dts: rockchip: Enable HS400 enhanced strobe on Kobol Helios64 eMMC Igor Velkov via B4 Relay
  2026-10-11  1:49 ` Shawn Lin
@ 2026-11-01 22:15 ` Heiko Stuebner
  1 sibling, 0 replies; 3+ messages in thread
From: Heiko Stuebner @ 2026-11-01 22:15 UTC (permalink / raw)
  To: Igor Velkov
  Cc: Heiko Stuebner, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	devicetree, linux-arm-kernel, linux-rockchip, linux-kernel


On Sun, 11 Oct 2026 00:52:37 +0300, Igor Velkov wrote:
> The eMMC of Helios64 runs in HS200. Run it in HS400 enhanced strobe at
> 150 MHz, as on Gru. The strobe line goes straight from the SoC to the
> DS pin of the eMMC with no pull-down on the board, so enable the one
> in the eMMC PHY.

Applied, thanks!

[1/1] arm64: dts: rockchip: Enable HS400 enhanced strobe on Kobol Helios64 eMMC
      commit: 0b1be7859dc26611558e4bbb7f42e4a1238af59a

Best regards,
-- 
Heiko Stuebner <heiko@sntech.de>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-11-01 22:15 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-10 21:52 [PATCH] arm64: dts: rockchip: Enable HS400 enhanced strobe on Kobol Helios64 eMMC Igor Velkov via B4 Relay
2026-10-11  1:49 ` Shawn Lin
2026-11-01 22:15 ` Heiko Stuebner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®