mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: <Claudiu.Beznea@microchip.com>
To: <michael@walle.cc>, <robh+dt@kernel.org>,
	<krzysztof.kozlowski+dt@linaro.org>,
	<Nicolas.Ferre@microchip.com>
Cc: <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ARM: dts: kswitch-d10: use open drain mode for coma-mode pins
Date: Fri, 8 Jul 2022 15:15:47 +0000	[thread overview]
Message-ID: <8c166a4a-d0a8-b225-fee9-14ad2898ebc6@microchip.com> (raw)
In-Reply-To: <20220704150808.1104295-1-michael@walle.cc>

On 04.07.2022 18:08, Michael Walle wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> The driver use the coma-mode pins as open-drain. Flag them in the device
> tree accordingly. This avoids the following error:
> [   14.114180] gpio-2007 (coma-mode): enforced open drain please flag it properly in DT/ACPI DSDT/board file
> 
> Fixes: 46a9556d977e ("ARM: dts: kswitch-d10: enable networking")
> Signed-off-by: Michael Walle <michael@walle.cc>

Applied to at91-fixes, thanks!

> ---
>  arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi b/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi
> index 949d49944a37..5a6c5f7c371a 100644
> --- a/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi
> +++ b/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi
> @@ -87,22 +87,22 @@ &mdio0 {
> 
>         phy4: ethernet-phy@5 {
>                 reg = <5>;
> -               coma-mode-gpios = <&gpio 37 GPIO_ACTIVE_HIGH>;
> +               coma-mode-gpios = <&gpio 37 GPIO_OPEN_DRAIN>;
>         };
> 
>         phy5: ethernet-phy@6 {
>                 reg = <6>;
> -               coma-mode-gpios = <&gpio 37 GPIO_ACTIVE_HIGH>;
> +               coma-mode-gpios = <&gpio 37 GPIO_OPEN_DRAIN>;
>         };
> 
>         phy6: ethernet-phy@7 {
>                 reg = <7>;
> -               coma-mode-gpios = <&gpio 37 GPIO_ACTIVE_HIGH>;
> +               coma-mode-gpios = <&gpio 37 GPIO_OPEN_DRAIN>;
>         };
> 
>         phy7: ethernet-phy@8 {
>                 reg = <8>;
> -               coma-mode-gpios = <&gpio 37 GPIO_ACTIVE_HIGH>;
> +               coma-mode-gpios = <&gpio 37 GPIO_OPEN_DRAIN>;
>         };
>  };
> 
> --
> 2.30.2
> 


      reply	other threads:[~2022-07-08 15:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-04 15:08 Michael Walle
2022-07-08 15:15 ` Claudiu.Beznea [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8c166a4a-d0a8-b225-fee9-14ad2898ebc6@microchip.com \
    --to=claudiu.beznea@microchip.com \
    --cc=Nicolas.Ferre@microchip.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael@walle.cc \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®