* [PATCH] ARM: dts: kswitch-d10: use open drain mode for coma-mode pins
@ 2022-07-04 15:08 Michael Walle
2022-07-08 15:15 ` Claudiu.Beznea
0 siblings, 1 reply; 2+ messages in thread
From: Michael Walle @ 2022-07-04 15:08 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Claudiu Beznea, Nicolas Ferre
Cc: devicetree, linux-kernel, Michael Walle
The driver use the coma-mode pins as open-drain. Flag them in the device
tree accordingly. This avoids the following error:
[ 14.114180] gpio-2007 (coma-mode): enforced open drain please flag it properly in DT/ACPI DSDT/board file
Fixes: 46a9556d977e ("ARM: dts: kswitch-d10: enable networking")
Signed-off-by: Michael Walle <michael@walle.cc>
---
arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi b/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi
index 949d49944a37..5a6c5f7c371a 100644
--- a/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi
+++ b/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi
@@ -87,22 +87,22 @@ &mdio0 {
phy4: ethernet-phy@5 {
reg = <5>;
- coma-mode-gpios = <&gpio 37 GPIO_ACTIVE_HIGH>;
+ coma-mode-gpios = <&gpio 37 GPIO_OPEN_DRAIN>;
};
phy5: ethernet-phy@6 {
reg = <6>;
- coma-mode-gpios = <&gpio 37 GPIO_ACTIVE_HIGH>;
+ coma-mode-gpios = <&gpio 37 GPIO_OPEN_DRAIN>;
};
phy6: ethernet-phy@7 {
reg = <7>;
- coma-mode-gpios = <&gpio 37 GPIO_ACTIVE_HIGH>;
+ coma-mode-gpios = <&gpio 37 GPIO_OPEN_DRAIN>;
};
phy7: ethernet-phy@8 {
reg = <8>;
- coma-mode-gpios = <&gpio 37 GPIO_ACTIVE_HIGH>;
+ coma-mode-gpios = <&gpio 37 GPIO_OPEN_DRAIN>;
};
};
--
2.30.2
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] ARM: dts: kswitch-d10: use open drain mode for coma-mode pins
2022-07-04 15:08 [PATCH] ARM: dts: kswitch-d10: use open drain mode for coma-mode pins Michael Walle
@ 2022-07-08 15:15 ` Claudiu.Beznea
0 siblings, 0 replies; 2+ messages in thread
From: Claudiu.Beznea @ 2022-07-08 15:15 UTC (permalink / raw)
To: michael, robh+dt, krzysztof.kozlowski+dt, Nicolas.Ferre
Cc: devicetree, linux-kernel
On 04.07.2022 18:08, Michael Walle wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> The driver use the coma-mode pins as open-drain. Flag them in the device
> tree accordingly. This avoids the following error:
> [ 14.114180] gpio-2007 (coma-mode): enforced open drain please flag it properly in DT/ACPI DSDT/board file
>
> Fixes: 46a9556d977e ("ARM: dts: kswitch-d10: enable networking")
> Signed-off-by: Michael Walle <michael@walle.cc>
Applied to at91-fixes, thanks!
> ---
> arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi b/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi
> index 949d49944a37..5a6c5f7c371a 100644
> --- a/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi
> +++ b/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi
> @@ -87,22 +87,22 @@ &mdio0 {
>
> phy4: ethernet-phy@5 {
> reg = <5>;
> - coma-mode-gpios = <&gpio 37 GPIO_ACTIVE_HIGH>;
> + coma-mode-gpios = <&gpio 37 GPIO_OPEN_DRAIN>;
> };
>
> phy5: ethernet-phy@6 {
> reg = <6>;
> - coma-mode-gpios = <&gpio 37 GPIO_ACTIVE_HIGH>;
> + coma-mode-gpios = <&gpio 37 GPIO_OPEN_DRAIN>;
> };
>
> phy6: ethernet-phy@7 {
> reg = <7>;
> - coma-mode-gpios = <&gpio 37 GPIO_ACTIVE_HIGH>;
> + coma-mode-gpios = <&gpio 37 GPIO_OPEN_DRAIN>;
> };
>
> phy7: ethernet-phy@8 {
> reg = <8>;
> - coma-mode-gpios = <&gpio 37 GPIO_ACTIVE_HIGH>;
> + coma-mode-gpios = <&gpio 37 GPIO_OPEN_DRAIN>;
> };
> };
>
> --
> 2.30.2
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-07-08 15:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-04 15:08 [PATCH] ARM: dts: kswitch-d10: use open drain mode for coma-mode pins Michael Walle
2022-07-08 15:15 ` Claudiu.Beznea
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®