mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Pearson <markpearson@lenovo.com>
To: Mario Limonciello <mario.limonciello@amd.com>,
	<xazrael@hotmail.com>, <lgirdwood@gmail.com>,
	<broonie@kernel.org>, <perex@perex.cz>, <tiwai@suse.com>,
	<Syed.SabaKareem@amd.com>, <Vijendar.Mukunda@amd.com>,
	<renjith.pananchikkal@amd.com>
Cc: <alsa-devel@alsa-project.org>, open list <linux-kernel@vger.kernel.org>
Subject: Re: Fw: [External] RE: [PATCH -next] ASoC: amd: yc: Adding Lenovo ThinkBook 14 Gen 4+ ARA and Lenovo ThinkBook 16 Gen 4+ ARA to the Quirks List
Date: Tue, 11 Oct 2022 14:30:33 -0400	[thread overview]
Message-ID: <8c7cb257-3e88-e299-5e92-a44cea06d771@lenovo.com> (raw)
In-Reply-To: <TYZPR03MB5994C7FD8582F831A69055DEBD239@TYZPR03MB5994.apcprd03.prod.outlook.com>

<moved to my more open-source friendly email account>

Thanks Mario

On 2022-10-11 13:14, Mark Pearson wrote:
> 
> --------------------------------------------------------------------------------
> *From:* Limonciello, Mario <Mario.Limonciello@amd.com>
> *Sent:* October 11, 2022 13:08
> *Subject:* [External] RE: [PATCH -next] ASoC: amd: yc: Adding Lenovo ThinkBook 
> 14 Gen 4+ ARA and Lenovo ThinkBook 16 Gen 4+ ARA to the Quirks List
> [Public]
> 
> Cc:
> Mark Pearson
> Vijendar
> Syed
> Renjith
> 
>> -----Original Message-----
>> From: linkt <xazrael@hotmail.com>
>> Sent: Monday, October 10, 2022 21:52
>> To: lgirdwood@gmail.com; broonie@kernel.org; perex@perex.cz;
>> tiwai@suse.com; Limonciello, Mario <Mario.Limonciello@amd.com>
>> Cc: alsa-devel@alsa-project.org; linux-kernel@vger.kernel.org; linkt
>> <xazrael@hotmail.com>
>> Subject: [PATCH -next] ASoC: amd: yc: Adding Lenovo ThinkBook 14 Gen 4+
>> ARA and Lenovo ThinkBook 16 Gen 4+ ARA to the Quirks List
>> 
>> Lenovo ThinkBook 14 Gen 4+ ARA and ThinkBook 16 Gen 4+ ARA
>> need to be added to the list of quirks for the microphone to work properly.
>> 
>> Signed-off-by: linkt <xazrael@hotmail.com>
> 
> This patch alone makes sense to me.
> 
> Cc: stable@vger.kernel.org
> Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
> 
> I think it should go in as is, but it prompts another idea to me I want to run by
> Mark specifically..
> 
> Should we just drop this whole file down to a much simpler DMI match prefix like 
> this:
> 
>> +     {
>> +             .driver_data = &acp6x_card,
>> +             .matches = {
>> +                     DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
>> +                     DMI_MATCH(DMI_PRODUCT_NAME, "21"),
>> +             }
>> +     },
> 
> That would allow it to match all the Lenovo Rembrandt systems presumably and
> can stop touching the file.  This only makes sense if every single Lenovo 
> Rembrandt design
> uses a DMIC from ACP.  I don't know if that's a valid assumption and I think we 
> need Mark
> to confirm it.
> 
> The DMI match "technically" would match some of the Intel systems from this 
> generation
> but this driver is only "loaded" on AMD Rembrandt systems, so I don't think it's 
> a problem.
> 

I love the idea but I'm a little hesitant as I don't know if I'll be
able to confirm it authoritatively - I don't have particularly great
levers to pull on for platforms outside the Linux program. I'll try -
but I think chances of being able to reply yes or no with confidence are
limited.

I think it's relatively low risk for breaking anything on this years
platforms - but may get more interesting for next years. If needed can
we then just quirk any platforms that come up that need the logic
reversing or does that get really messy.

I can confirm the "21" match is going to be match a ton of Intel
platforms. For the AMD platforms - will this be limited to Rembrandt
only or will it affect any past/future generations?

Short answer - I'll see what I can find...but no promises

Mark

  parent reply	other threads:[~2022-10-11 18:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-11  2:51 linkt
2022-10-11 17:08 ` Limonciello, Mario
     [not found]   ` <TYZPR03MB5994C7FD8582F831A69055DEBD239@TYZPR03MB5994.apcprd03.prod.outlook.com>
2022-10-11 18:30     ` Mark Pearson [this message]
2022-10-11 19:17       ` Fw: [External] " Limonciello, Mario
2022-10-19 17:13 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8c7cb257-3e88-e299-5e92-a44cea06d771@lenovo.com \
    --to=markpearson@lenovo.com \
    --cc=Syed.SabaKareem@amd.com \
    --cc=Vijendar.Mukunda@amd.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mario.limonciello@amd.com \
    --cc=perex@perex.cz \
    --cc=renjith.pananchikkal@amd.com \
    --cc=tiwai@suse.com \
    --cc=xazrael@hotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®