mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH -next] ASoC: amd: yc: Adding Lenovo ThinkBook 14 Gen 4+ ARA and Lenovo ThinkBook 16 Gen 4+ ARA to the Quirks List
@ 2022-10-11  2:51 linkt
  2022-10-11 17:08 ` Limonciello, Mario
  2022-10-19 17:13 ` Mark Brown
  0 siblings, 2 replies; 5+ messages in thread
From: linkt @ 2022-10-11  2:51 UTC (permalink / raw)
  To: lgirdwood, broonie, perex, tiwai, mario.limonciello
  Cc: alsa-devel, linux-kernel, linkt

Lenovo ThinkBook 14 Gen 4+ ARA and ThinkBook 16 Gen 4+ ARA
need to be added to the list of quirks for the microphone to work properly.

Signed-off-by: linkt <xazrael@hotmail.com>
---
 sound/soc/amd/yc/acp6x-mach.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c
index 2cb50d5cf1a9..09a8aceff22f 100644
--- a/sound/soc/amd/yc/acp6x-mach.c
+++ b/sound/soc/amd/yc/acp6x-mach.c
@@ -45,6 +45,20 @@ static struct snd_soc_card acp6x_card = {
 };
 
 static const struct dmi_system_id yc_acp_quirk_table[] = {
+	{
+		.driver_data = &acp6x_card,
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "21D0"),
+		}
+	},
+	{
+		.driver_data = &acp6x_card,
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "21D1"),
+		}
+	},
 	{
 		.driver_data = &acp6x_card,
 		.matches = {
-- 
2.37.3


^ permalink raw reply	[flat|nested] 5+ messages in thread

* RE: [PATCH -next] ASoC: amd: yc: Adding Lenovo ThinkBook 14 Gen 4+ ARA and Lenovo ThinkBook 16 Gen 4+ ARA to the Quirks List
  2022-10-11  2:51 [PATCH -next] ASoC: amd: yc: Adding Lenovo ThinkBook 14 Gen 4+ ARA and Lenovo ThinkBook 16 Gen 4+ ARA to the Quirks List linkt
@ 2022-10-11 17:08 ` Limonciello, Mario
       [not found]   ` <TYZPR03MB5994C7FD8582F831A69055DEBD239@TYZPR03MB5994.apcprd03.prod.outlook.com>
  2022-10-19 17:13 ` Mark Brown
  1 sibling, 1 reply; 5+ messages in thread
From: Limonciello, Mario @ 2022-10-11 17:08 UTC (permalink / raw)
  To: linkt, lgirdwood, broonie, perex, tiwai, Mark Pearson,
	Saba Kareem, Syed, Mukunda, Vijendar, Pananchikkal, Renjith
  Cc: alsa-devel, linux-kernel

[Public]

Cc:
Mark Pearson
Vijendar
Syed
Renjith

> -----Original Message-----
> From: linkt <xazrael@hotmail.com>
> Sent: Monday, October 10, 2022 21:52
> To: lgirdwood@gmail.com; broonie@kernel.org; perex@perex.cz;
> tiwai@suse.com; Limonciello, Mario <Mario.Limonciello@amd.com>
> Cc: alsa-devel@alsa-project.org; linux-kernel@vger.kernel.org; linkt
> <xazrael@hotmail.com>
> Subject: [PATCH -next] ASoC: amd: yc: Adding Lenovo ThinkBook 14 Gen 4+
> ARA and Lenovo ThinkBook 16 Gen 4+ ARA to the Quirks List
> 
> Lenovo ThinkBook 14 Gen 4+ ARA and ThinkBook 16 Gen 4+ ARA
> need to be added to the list of quirks for the microphone to work properly.
> 
> Signed-off-by: linkt <xazrael@hotmail.com>

This patch alone makes sense to me.

Cc: stable@vger.kernel.org
Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>

I think it should go in as is, but it prompts another idea to me I want to run by
Mark specifically..

Should we just drop this whole file down to a much simpler DMI match prefix like this:

> +	{
> +		.driver_data = &acp6x_card,
> +		.matches = {
> +			DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "21"),
> +		}
> +	},

That would allow it to match all the Lenovo Rembrandt systems presumably and
can stop touching the file.  This only makes sense if every single Lenovo Rembrandt design 
uses a DMIC from ACP.  I don't know if that's a valid assumption and I think we need Mark
to confirm it.

The DMI match "technically" would match some of the Intel systems from this generation
but this driver is only "loaded" on AMD Rembrandt systems, so I don't think it's a problem.

> ---
>  sound/soc/amd/yc/acp6x-mach.c | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-
> mach.c
> index 2cb50d5cf1a9..09a8aceff22f 100644
> --- a/sound/soc/amd/yc/acp6x-mach.c
> +++ b/sound/soc/amd/yc/acp6x-mach.c
> @@ -45,6 +45,20 @@ static struct snd_soc_card acp6x_card = {
>  };
> 
>  static const struct dmi_system_id yc_acp_quirk_table[] = {
> +	{
> +		.driver_data = &acp6x_card,
> +		.matches = {
> +			DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "21D0"),
> +		}
> +	},
> +	{
> +		.driver_data = &acp6x_card,
> +		.matches = {
> +			DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "21D1"),
> +		}
> +	},
>  	{
>  		.driver_data = &acp6x_card,
>  		.matches = {
> --
> 2.37.3

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Fw: [External] RE: [PATCH -next] ASoC: amd: yc: Adding Lenovo ThinkBook 14 Gen 4+ ARA and Lenovo ThinkBook 16 Gen 4+ ARA to the Quirks List
       [not found]   ` <TYZPR03MB5994C7FD8582F831A69055DEBD239@TYZPR03MB5994.apcprd03.prod.outlook.com>
@ 2022-10-11 18:30     ` Mark Pearson
  2022-10-11 19:17       ` Limonciello, Mario
  0 siblings, 1 reply; 5+ messages in thread
From: Mark Pearson @ 2022-10-11 18:30 UTC (permalink / raw)
  To: Mario Limonciello, xazrael, lgirdwood, broonie, perex, tiwai,
	Syed.SabaKareem, Vijendar.Mukunda, renjith.pananchikkal
  Cc: alsa-devel, open list

<moved to my more open-source friendly email account>

Thanks Mario

On 2022-10-11 13:14, Mark Pearson wrote:
> 
> --------------------------------------------------------------------------------
> *From:* Limonciello, Mario <Mario.Limonciello@amd.com>
> *Sent:* October 11, 2022 13:08
> *Subject:* [External] RE: [PATCH -next] ASoC: amd: yc: Adding Lenovo ThinkBook 
> 14 Gen 4+ ARA and Lenovo ThinkBook 16 Gen 4+ ARA to the Quirks List
> [Public]
> 
> Cc:
> Mark Pearson
> Vijendar
> Syed
> Renjith
> 
>> -----Original Message-----
>> From: linkt <xazrael@hotmail.com>
>> Sent: Monday, October 10, 2022 21:52
>> To: lgirdwood@gmail.com; broonie@kernel.org; perex@perex.cz;
>> tiwai@suse.com; Limonciello, Mario <Mario.Limonciello@amd.com>
>> Cc: alsa-devel@alsa-project.org; linux-kernel@vger.kernel.org; linkt
>> <xazrael@hotmail.com>
>> Subject: [PATCH -next] ASoC: amd: yc: Adding Lenovo ThinkBook 14 Gen 4+
>> ARA and Lenovo ThinkBook 16 Gen 4+ ARA to the Quirks List
>> 
>> Lenovo ThinkBook 14 Gen 4+ ARA and ThinkBook 16 Gen 4+ ARA
>> need to be added to the list of quirks for the microphone to work properly.
>> 
>> Signed-off-by: linkt <xazrael@hotmail.com>
> 
> This patch alone makes sense to me.
> 
> Cc: stable@vger.kernel.org
> Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
> 
> I think it should go in as is, but it prompts another idea to me I want to run by
> Mark specifically..
> 
> Should we just drop this whole file down to a much simpler DMI match prefix like 
> this:
> 
>> +     {
>> +             .driver_data = &acp6x_card,
>> +             .matches = {
>> +                     DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
>> +                     DMI_MATCH(DMI_PRODUCT_NAME, "21"),
>> +             }
>> +     },
> 
> That would allow it to match all the Lenovo Rembrandt systems presumably and
> can stop touching the file.  This only makes sense if every single Lenovo 
> Rembrandt design
> uses a DMIC from ACP.  I don't know if that's a valid assumption and I think we 
> need Mark
> to confirm it.
> 
> The DMI match "technically" would match some of the Intel systems from this 
> generation
> but this driver is only "loaded" on AMD Rembrandt systems, so I don't think it's 
> a problem.
> 

I love the idea but I'm a little hesitant as I don't know if I'll be
able to confirm it authoritatively - I don't have particularly great
levers to pull on for platforms outside the Linux program. I'll try -
but I think chances of being able to reply yes or no with confidence are
limited.

I think it's relatively low risk for breaking anything on this years
platforms - but may get more interesting for next years. If needed can
we then just quirk any platforms that come up that need the logic
reversing or does that get really messy.

I can confirm the "21" match is going to be match a ton of Intel
platforms. For the AMD platforms - will this be limited to Rembrandt
only or will it affect any past/future generations?

Short answer - I'll see what I can find...but no promises

Mark

^ permalink raw reply	[flat|nested] 5+ messages in thread

* RE: Fw: [External] RE: [PATCH -next] ASoC: amd: yc: Adding Lenovo ThinkBook 14 Gen 4+ ARA and Lenovo ThinkBook 16 Gen 4+ ARA to the Quirks List
  2022-10-11 18:30     ` Fw: [External] " Mark Pearson
@ 2022-10-11 19:17       ` Limonciello, Mario
  0 siblings, 0 replies; 5+ messages in thread
From: Limonciello, Mario @ 2022-10-11 19:17 UTC (permalink / raw)
  To: Mark Pearson, xazrael, lgirdwood, broonie, perex, tiwai,
	Saba Kareem, Syed, Mukunda, Vijendar, Pananchikkal, Renjith
  Cc: alsa-devel, open list

[Public]


> <moved to my more open-source friendly email account>

Whoops sorry; I mix them up constantly.

> 
> Thanks Mario
> 
> On 2022-10-11 13:14, Mark Pearson wrote:
> >
> > --------------------------------------------------------------------------------
> > *From:* Limonciello, Mario <Mario.Limonciello@amd.com>
> > *Sent:* October 11, 2022 13:08
> > *Subject:* [External] RE: [PATCH -next] ASoC: amd: yc: Adding Lenovo
> ThinkBook
> > 14 Gen 4+ ARA and Lenovo ThinkBook 16 Gen 4+ ARA to the Quirks List
> > [Public]
> >
> > Cc:
> > Mark Pearson
> > Vijendar
> > Syed
> > Renjith
> >
> >> -----Original Message-----
> >> From: linkt <xazrael@hotmail.com>
> >> Sent: Monday, October 10, 2022 21:52
> >> To: lgirdwood@gmail.com; broonie@kernel.org; perex@perex.cz;
> >> tiwai@suse.com; Limonciello, Mario <Mario.Limonciello@amd.com>
> >> Cc: alsa-devel@alsa-project.org; linux-kernel@vger.kernel.org; linkt
> >> <xazrael@hotmail.com>
> >> Subject: [PATCH -next] ASoC: amd: yc: Adding Lenovo ThinkBook 14 Gen
> 4+
> >> ARA and Lenovo ThinkBook 16 Gen 4+ ARA to the Quirks List
> >>
> >> Lenovo ThinkBook 14 Gen 4+ ARA and ThinkBook 16 Gen 4+ ARA
> >> need to be added to the list of quirks for the microphone to work
> properly.
> >>
> >> Signed-off-by: linkt <xazrael@hotmail.com>
> >
> > This patch alone makes sense to me.
> >
> > Cc: stable@vger.kernel.org
> > Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
> >
> > I think it should go in as is, but it prompts another idea to me I want to run
> by
> > Mark specifically..
> >
> > Should we just drop this whole file down to a much simpler DMI match
> prefix like
> > this:
> >
> >> +     {
> >> +             .driver_data = &acp6x_card,
> >> +             .matches = {
> >> +                     DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
> >> +                     DMI_MATCH(DMI_PRODUCT_NAME, "21"),
> >> +             }
> >> +     },
> >
> > That would allow it to match all the Lenovo Rembrandt systems presumably
> and
> > can stop touching the file.  This only makes sense if every single Lenovo
> > Rembrandt design
> > uses a DMIC from ACP.  I don't know if that's a valid assumption and I think
> we
> > need Mark
> > to confirm it.
> >
> > The DMI match "technically" would match some of the Intel systems from
> this
> > generation
> > but this driver is only "loaded" on AMD Rembrandt systems, so I don't think
> it's
> > a problem.
> >
> 
> I love the idea but I'm a little hesitant as I don't know if I'll be
> able to confirm it authoritatively - I don't have particularly great
> levers to pull on for platforms outside the Linux program. I'll try -
> but I think chances of being able to reply yes or no with confidence are
> limited.
> 
> I think it's relatively low risk for breaking anything on this years
> platforms - but may get more interesting for next years. If needed can
> we then just quirk any platforms that come up that need the logic
> reversing or does that get really messy.
> 
> I can confirm the "21" match is going to be match a ton of Intel
> platforms. For the AMD platforms - will this be limited to Rembrandt
> only or will it affect any past/future generations?

This driver only loads on Yellow Carp (Rembrandt).  It is not used for
any other generations.

My hope is that with the _DSD supported in future programs that
less of these quirks are needed too even for platforms now in your
Linux program.

> 
> Short answer - I'll see what I can find...but no promises
> 

OK, thanks.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH -next] ASoC: amd: yc: Adding Lenovo ThinkBook 14 Gen 4+ ARA and Lenovo ThinkBook 16 Gen 4+ ARA to the Quirks List
  2022-10-11  2:51 [PATCH -next] ASoC: amd: yc: Adding Lenovo ThinkBook 14 Gen 4+ ARA and Lenovo ThinkBook 16 Gen 4+ ARA to the Quirks List linkt
  2022-10-11 17:08 ` Limonciello, Mario
@ 2022-10-19 17:13 ` Mark Brown
  1 sibling, 0 replies; 5+ messages in thread
From: Mark Brown @ 2022-10-19 17:13 UTC (permalink / raw)
  To: linkt, lgirdwood, tiwai, mario.limonciello, perex
  Cc: linux-kernel, alsa-devel

On Tue, 11 Oct 2022 10:51:36 +0800, linkt wrote:
> Lenovo ThinkBook 14 Gen 4+ ARA and ThinkBook 16 Gen 4+ ARA
> need to be added to the list of quirks for the microphone to work properly.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: amd: yc: Adding Lenovo ThinkBook 14 Gen 4+ ARA and Lenovo ThinkBook 16 Gen 4+ ARA to the Quirks List
      commit: a450b5c8739248069e11f72129fca61a56125577

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2022-10-19 17:13 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-11  2:51 [PATCH -next] ASoC: amd: yc: Adding Lenovo ThinkBook 14 Gen 4+ ARA and Lenovo ThinkBook 16 Gen 4+ ARA to the Quirks List linkt
2022-10-11 17:08 ` Limonciello, Mario
     [not found]   ` <TYZPR03MB5994C7FD8582F831A69055DEBD239@TYZPR03MB5994.apcprd03.prod.outlook.com>
2022-10-11 18:30     ` Fw: [External] " Mark Pearson
2022-10-11 19:17       ` Limonciello, Mario
2022-10-19 17:13 ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®