* [PATCH] drm/amdgpu: Fix assignment errors in 'si_common_early_init' functions
@ 2024-02-28 1:44 Lu Yao
2024-02-28 6:51 ` Christian König
0 siblings, 1 reply; 2+ messages in thread
From: Lu Yao @ 2024-02-28 1:44 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, Xinhui.Pan, airlied, daniel
Cc: amd-gfx, dri-devel, linux-kernel, Lu Yao
uvd_ctx_rreg/uvd_ctx_wreg correct value requires function pointer.
Signed-off-by: Lu Yao <yaolu@kylinos.cn>
---
drivers/gpu/drm/amd/amdgpu/si.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/si.c b/drivers/gpu/drm/amd/amdgpu/si.c
index a757526153e5..455d49f7bd9c 100644
--- a/drivers/gpu/drm/amd/amdgpu/si.c
+++ b/drivers/gpu/drm/amd/amdgpu/si.c
@@ -2032,8 +2032,8 @@ static int si_common_early_init(void *handle)
adev->pcie_wreg = &si_pcie_wreg;
adev->pciep_rreg = &si_pciep_rreg;
adev->pciep_wreg = &si_pciep_wreg;
- adev->uvd_ctx_rreg = si_uvd_ctx_rreg;
- adev->uvd_ctx_wreg = si_uvd_ctx_wreg;
+ adev->uvd_ctx_rreg = &si_uvd_ctx_rreg;
+ adev->uvd_ctx_wreg = &si_uvd_ctx_wreg;
adev->didt_rreg = NULL;
adev->didt_wreg = NULL;
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/amdgpu: Fix assignment errors in 'si_common_early_init' functions
2024-02-28 1:44 [PATCH] drm/amdgpu: Fix assignment errors in 'si_common_early_init' functions Lu Yao
@ 2024-02-28 6:51 ` Christian König
0 siblings, 0 replies; 2+ messages in thread
From: Christian König @ 2024-02-28 6:51 UTC (permalink / raw)
To: Lu Yao, alexander.deucher, Xinhui.Pan, airlied, daniel
Cc: amd-gfx, dri-devel, linux-kernel
Am 28.02.24 um 02:44 schrieb Lu Yao:
> uvd_ctx_rreg/uvd_ctx_wreg correct value requires function pointer.
Yeah, but that is completely irrelevant here. We usually don't use the &
for function pointers since that is unnecessary in C.
Regards,
Christian.
>
> Signed-off-by: Lu Yao <yaolu@kylinos.cn>
> ---
> drivers/gpu/drm/amd/amdgpu/si.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/si.c b/drivers/gpu/drm/amd/amdgpu/si.c
> index a757526153e5..455d49f7bd9c 100644
> --- a/drivers/gpu/drm/amd/amdgpu/si.c
> +++ b/drivers/gpu/drm/amd/amdgpu/si.c
> @@ -2032,8 +2032,8 @@ static int si_common_early_init(void *handle)
> adev->pcie_wreg = &si_pcie_wreg;
> adev->pciep_rreg = &si_pciep_rreg;
> adev->pciep_wreg = &si_pciep_wreg;
> - adev->uvd_ctx_rreg = si_uvd_ctx_rreg;
> - adev->uvd_ctx_wreg = si_uvd_ctx_wreg;
> + adev->uvd_ctx_rreg = &si_uvd_ctx_rreg;
> + adev->uvd_ctx_wreg = &si_uvd_ctx_wreg;
> adev->didt_rreg = NULL;
> adev->didt_wreg = NULL;
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-02-28 6:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-28 1:44 [PATCH] drm/amdgpu: Fix assignment errors in 'si_common_early_init' functions Lu Yao
2024-02-28 6:51 ` Christian König
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®