* [PATCH] ASoC: Intel: atom: remove unused 'sst_mix_voip_controls'
@ 2020-04-17 9:23 Jason Yan
2020-04-17 13:43 ` Pierre-Louis Bossart
0 siblings, 1 reply; 2+ messages in thread
From: Jason Yan @ 2020-04-17 9:23 UTC (permalink / raw)
To: cezary.rojewski, pierre-louis.bossart, liam.r.girdwood, yang.jie,
broonie, perex, tiwai, hdegoede, tglx, alsa-devel, linux-kernel
Cc: Jason Yan, Hulk Robot
Fix the following gcc warning:
sound/soc/intel/atom/sst-atom-controls.c:710:30: warning:
‘sst_mix_voip_controls’ defined but not used [-Wunused-const-variable=]
SST_SBA_DECLARE_MIX_CONTROLS(sst_mix_voip_controls);
^
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
sound/soc/intel/atom/sst-atom-controls.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/sound/soc/intel/atom/sst-atom-controls.c b/sound/soc/intel/atom/sst-atom-controls.c
index 69f3af4524ab..541f0059ba7a 100644
--- a/sound/soc/intel/atom/sst-atom-controls.c
+++ b/sound/soc/intel/atom/sst-atom-controls.c
@@ -707,7 +707,6 @@ SST_SBA_DECLARE_MIX_CONTROLS(sst_mix_pcm2_controls);
SST_SBA_DECLARE_MIX_CONTROLS(sst_mix_sprot_l0_controls);
SST_SBA_DECLARE_MIX_CONTROLS(sst_mix_media_l1_controls);
SST_SBA_DECLARE_MIX_CONTROLS(sst_mix_media_l2_controls);
-SST_SBA_DECLARE_MIX_CONTROLS(sst_mix_voip_controls);
SST_SBA_DECLARE_MIX_CONTROLS(sst_mix_codec0_controls);
SST_SBA_DECLARE_MIX_CONTROLS(sst_mix_codec1_controls);
SST_SBA_DECLARE_MIX_CONTROLS(sst_mix_modem_controls);
--
2.21.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] ASoC: Intel: atom: remove unused 'sst_mix_voip_controls'
2020-04-17 9:23 [PATCH] ASoC: Intel: atom: remove unused 'sst_mix_voip_controls' Jason Yan
@ 2020-04-17 13:43 ` Pierre-Louis Bossart
0 siblings, 0 replies; 2+ messages in thread
From: Pierre-Louis Bossart @ 2020-04-17 13:43 UTC (permalink / raw)
To: Jason Yan, cezary.rojewski, liam.r.girdwood, yang.jie, broonie,
perex, tiwai, hdegoede, tglx, alsa-devel, linux-kernel
Cc: Hulk Robot
On 4/17/20 4:23 AM, Jason Yan wrote:
> Fix the following gcc warning:
>
> sound/soc/intel/atom/sst-atom-controls.c:710:30: warning:
> ‘sst_mix_voip_controls’ defined but not used [-Wunused-const-variable=]
> SST_SBA_DECLARE_MIX_CONTROLS(sst_mix_voip_controls);
I'd prefer it if we didn't change this but only added __maybe_unused in
the macro.
This is 2013/2014 legacy stuff, some parts were not upstreamed and this
was used by out-of-tree Android variations, and I don't know the
consequences of taking this out.
Better just squelch the warning but not change anything, no?
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
> ---
> sound/soc/intel/atom/sst-atom-controls.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/sound/soc/intel/atom/sst-atom-controls.c b/sound/soc/intel/atom/sst-atom-controls.c
> index 69f3af4524ab..541f0059ba7a 100644
> --- a/sound/soc/intel/atom/sst-atom-controls.c
> +++ b/sound/soc/intel/atom/sst-atom-controls.c
> @@ -707,7 +707,6 @@ SST_SBA_DECLARE_MIX_CONTROLS(sst_mix_pcm2_controls);
> SST_SBA_DECLARE_MIX_CONTROLS(sst_mix_sprot_l0_controls);
> SST_SBA_DECLARE_MIX_CONTROLS(sst_mix_media_l1_controls);
> SST_SBA_DECLARE_MIX_CONTROLS(sst_mix_media_l2_controls);
> -SST_SBA_DECLARE_MIX_CONTROLS(sst_mix_voip_controls);
> SST_SBA_DECLARE_MIX_CONTROLS(sst_mix_codec0_controls);
> SST_SBA_DECLARE_MIX_CONTROLS(sst_mix_codec1_controls);
> SST_SBA_DECLARE_MIX_CONTROLS(sst_mix_modem_controls);
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-17 15:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-17 9:23 [PATCH] ASoC: Intel: atom: remove unused 'sst_mix_voip_controls' Jason Yan
2020-04-17 13:43 ` Pierre-Louis Bossart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®