mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: Barry Song <21cnbao@gmail.com>
Cc: Feng Lee <379943137@qq.com>,
	akpm@linux-foundation.org, ryan.roberts@arm.com,
	libang.li@antgroup.com, peterx@redhat.com, maobibo@loongson.cn,
	lance.yang@linux.dev, anshuman.khandual@arm.com,
	trivial@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: remove useless code
Date: Thu, 8 May 2025 16:39:27 +0200	[thread overview]
Message-ID: <8cd1e38d-cc80-40ac-bb7a-ca45b37f45df@redhat.com> (raw)
In-Reply-To: <CAGsJ_4y5QB7UTD3Mvwqib-c6DYkKCP_9V1s9eVoXLZGx+A5ObA@mail.gmail.com>


>> Yeah, but this is GUP ... ("user") ... looks like that check/handling
>> was in there ever since git happened.
>>
>> get_gate_vma() only exists on x86-64 and uml.
>>
>> I wonder if that could ever actually reside > TASK_SIZE such that we
>> would even need that.
> 
> I assume that reside > TASK_SIZE can only be true on IA64?
> 
>   /* Look up a pgd entry in the gate area.  On IA-64, the gate-area
>        resides in the kernel-mapped segment, hence we use pgd_offset_k()
>        here.  */
> #define pgd_offset_gate(mm, addr) pgd_offset_k(addr)
> 
> Since IA64 is dead, is the code also dead? It seems we can safely move
> forward with the approach you're proposing.

Thanks for verifying!

-- 
Cheers,

David / dhildenb


  parent reply	other threads:[~2025-05-08 14:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-27  6:13 Feng Lee
2025-04-27  8:22 ` Barry Song
2025-04-28  7:17   ` David Hildenbrand
2025-04-28 11:03     ` Barry Song
2025-04-28 13:59       ` David Hildenbrand
2025-04-30 23:23         ` Barry Song
2025-05-08 12:47           ` Feng Lee
2025-05-08 14:39           ` David Hildenbrand [this message]
2025-04-29  8:13       ` Feng Lee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8cd1e38d-cc80-40ac-bb7a-ca45b37f45df@redhat.com \
    --to=david@redhat.com \
    --cc=21cnbao@gmail.com \
    --cc=379943137@qq.com \
    --cc=akpm@linux-foundation.org \
    --cc=anshuman.khandual@arm.com \
    --cc=lance.yang@linux.dev \
    --cc=libang.li@antgroup.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maobibo@loongson.cn \
    --cc=peterx@redhat.com \
    --cc=ryan.roberts@arm.com \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®