* [PATCH] MIPS:DTS:Correct device id and class code of pcie for Loongnon-2K
@ 2021-04-25 5:28 Xiaochuan Mao
2021-04-25 10:39 ` Jiaxun Yang
0 siblings, 1 reply; 3+ messages in thread
From: Xiaochuan Mao @ 2021-04-25 5:28 UTC (permalink / raw)
To: Rob Herring, Thomas Bogendoerfer, Qing Zhang, Jiaxun Yang
Cc: devicetree, linux-mips, linux-kernel, Xiaochuan Mao
from Loongson-2K user manual know that Loongson-2K have two
pcie controller pcie0 and pcie1, pcie0 have four port named port0~port3
and pcie1 have 2 port named port0~port1. the device id of port0 is 7a19
in each pcie controller and others are 7a09. and their class code is 0b0300.
Signed-off-by: Xiaochuan Mao <maoxiaochuan@loongson.cn>
---
.../boot/dts/loongson/loongson64-2k1000.dtsi | 40 +++++++++----------
1 file changed, 20 insertions(+), 20 deletions(-)
diff --git a/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi b/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi
index 569e814def83..a95121359080 100644
--- a/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi
+++ b/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi
@@ -150,8 +150,8 @@
pci_bridge@9,0 {
compatible = "pci0014,7a19.0",
"pci0014,7a19",
- "pciclass060400",
- "pciclass0604";
+ "pciclass0b0300",
+ "pciclass0b03";
reg = <0x4800 0x0 0x0 0x0 0x0>;
#interrupt-cells = <1>;
@@ -163,10 +163,10 @@
};
pci_bridge@a,0 {
- compatible = "pci0014,7a19.0",
- "pci0014,7a19",
- "pciclass060400",
- "pciclass0604";
+ compatible = "pci0014,7a09.0",
+ "pci0014,7a09",
+ "pciclass0b0300",
+ "pciclass0b03";
reg = <0x5000 0x0 0x0 0x0 0x0>;
#interrupt-cells = <1>;
@@ -178,10 +178,10 @@
};
pci_bridge@b,0 {
- compatible = "pci0014,7a19.0",
- "pci0014,7a19",
- "pciclass060400",
- "pciclass0604";
+ compatible = "pci0014,7a09.0",
+ "pci0014,7a09",
+ "pciclass0b0300",
+ "pciclass0b03";
reg = <0x5800 0x0 0x0 0x0 0x0>;
#interrupt-cells = <1>;
@@ -193,10 +193,10 @@
};
pci_bridge@c,0 {
- compatible = "pci0014,7a19.0",
- "pci0014,7a19",
- "pciclass060400",
- "pciclass0604";
+ compatible = "pci0014,7a09.0",
+ "pci0014,7a09",
+ "pciclass0b0300",
+ "pciclass0b03";
reg = <0x6000 0x0 0x0 0x0 0x0>;
#interrupt-cells = <1>;
@@ -210,8 +210,8 @@
pci_bridge@d,0 {
compatible = "pci0014,7a19.0",
"pci0014,7a19",
- "pciclass060400",
- "pciclass0604";
+ "pciclass0b0300",
+ "pciclass0b03";
reg = <0x6800 0x0 0x0 0x0 0x0>;
#interrupt-cells = <1>;
@@ -223,10 +223,10 @@
};
pci_bridge@e,0 {
- compatible = "pci0014,7a19.0",
- "pci0014,7a19",
- "pciclass060400",
- "pciclass0604";
+ compatible = "pci0014,7a09.0",
+ "pci0014,7a09",
+ "pciclass0b0300",
+ "pciclass0b03";
reg = <0x7000 0x0 0x0 0x0 0x0>;
#interrupt-cells = <1>;
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] MIPS:DTS:Correct device id and class code of pcie for Loongnon-2K
2021-04-25 5:28 [PATCH] MIPS:DTS:Correct device id and class code of pcie for Loongnon-2K Xiaochuan Mao
@ 2021-04-25 10:39 ` Jiaxun Yang
2021-04-25 12:05 ` Xiaochuan Mao
0 siblings, 1 reply; 3+ messages in thread
From: Jiaxun Yang @ 2021-04-25 10:39 UTC (permalink / raw)
To: xiaochuan mao, Rob Herring, Thomas Bogendoerfer, Qing Zhang
Cc: devicetree, linux-mips, linux-kernel
On Sun, Apr 25, 2021, at 1:28 PM, Xiaochuan Mao wrote:
> from Loongson-2K user manual know that Loongson-2K have two
> pcie controller pcie0 and pcie1, pcie0 have four port named port0~port3
> and pcie1 have 2 port named port0~port1. the device id of port0 is 7a19
> in each pcie controller and others are 7a09. and their class code is 0b0300.
The manual is obviously incorrect.
class0604 is PCI to PCI bridge that matches. hardware. 0b03 is undefined.
Thanks.
>
> Signed-off-by: Xiaochuan Mao <maoxiaochuan@loongson.cn>
> ---
> .../boot/dts/loongson/loongson64-2k1000.dtsi | 40 +++++++++----------
> 1 file changed, 20 insertions(+), 20 deletions(-)
>
> diff --git a/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi
> b/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi
> index 569e814def83..a95121359080 100644
> --- a/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi
> +++ b/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi
> @@ -150,8 +150,8 @@
> pci_bridge@9,0 {
> compatible = "pci0014,7a19.0",
> "pci0014,7a19",
> - "pciclass060400",
> - "pciclass0604";
> + "pciclass0b0300",
> + "pciclass0b03";
>
> reg = <0x4800 0x0 0x0 0x0 0x0>;
> #interrupt-cells = <1>;
> @@ -163,10 +163,10 @@
> };
>
> pci_bridge@a,0 {
> - compatible = "pci0014,7a19.0",
> - "pci0014,7a19",
> - "pciclass060400",
> - "pciclass0604";
> + compatible = "pci0014,7a09.0",
> + "pci0014,7a09",
> + "pciclass0b0300",
> + "pciclass0b03";
>
> reg = <0x5000 0x0 0x0 0x0 0x0>;
> #interrupt-cells = <1>;
> @@ -178,10 +178,10 @@
> };
>
> pci_bridge@b,0 {
> - compatible = "pci0014,7a19.0",
> - "pci0014,7a19",
> - "pciclass060400",
> - "pciclass0604";
> + compatible = "pci0014,7a09.0",
> + "pci0014,7a09",
> + "pciclass0b0300",
> + "pciclass0b03";
>
> reg = <0x5800 0x0 0x0 0x0 0x0>;
> #interrupt-cells = <1>;
> @@ -193,10 +193,10 @@
> };
>
> pci_bridge@c,0 {
> - compatible = "pci0014,7a19.0",
> - "pci0014,7a19",
> - "pciclass060400",
> - "pciclass0604";
> + compatible = "pci0014,7a09.0",
> + "pci0014,7a09",
> + "pciclass0b0300",
> + "pciclass0b03";
>
> reg = <0x6000 0x0 0x0 0x0 0x0>;
> #interrupt-cells = <1>;
> @@ -210,8 +210,8 @@
> pci_bridge@d,0 {
> compatible = "pci0014,7a19.0",
> "pci0014,7a19",
> - "pciclass060400",
> - "pciclass0604";
> + "pciclass0b0300",
> + "pciclass0b03";
>
> reg = <0x6800 0x0 0x0 0x0 0x0>;
> #interrupt-cells = <1>;
> @@ -223,10 +223,10 @@
> };
>
> pci_bridge@e,0 {
> - compatible = "pci0014,7a19.0",
> - "pci0014,7a19",
> - "pciclass060400",
> - "pciclass0604";
> + compatible = "pci0014,7a09.0",
> + "pci0014,7a09",
> + "pciclass0b0300",
> + "pciclass0b03";
>
> reg = <0x7000 0x0 0x0 0x0 0x0>;
> #interrupt-cells = <1>;
> --
> 2.17.1
>
>
--
- Jiaxun
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] MIPS:DTS:Correct device id and class code of pcie for Loongnon-2K
2021-04-25 10:39 ` Jiaxun Yang
@ 2021-04-25 12:05 ` Xiaochuan Mao
0 siblings, 0 replies; 3+ messages in thread
From: Xiaochuan Mao @ 2021-04-25 12:05 UTC (permalink / raw)
To: Jiaxun Yang, Rob Herring, Thomas Bogendoerfer, Qing Zhang
Cc: devicetree, linux-mips, linux-kernel
On 2021/4/25 下午6:39, Jiaxun Yang wrote:
>
> On Sun, Apr 25, 2021, at 1:28 PM, Xiaochuan Mao wrote:
>> from Loongson-2K user manual know that Loongson-2K have two
>> pcie controller pcie0 and pcie1, pcie0 have four port named port0~port3
>> and pcie1 have 2 port named port0~port1. the device id of port0 is 7a19
>> in each pcie controller and others are 7a09. and their class code is 0b0300.
> The manual is obviously incorrect.
>
> class0604 is PCI to PCI bridge that matches. hardware. 0b03 is undefined.
>
> Thanks.
thanks your suggest , is my mistake .
>> Signed-off-by: Xiaochuan Mao <maoxiaochuan@loongson.cn>
>> ---
>> .../boot/dts/loongson/loongson64-2k1000.dtsi | 40 +++++++++----------
>> 1 file changed, 20 insertions(+), 20 deletions(-)
>>
>> diff --git a/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi
>> b/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi
>> index 569e814def83..a95121359080 100644
>> --- a/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi
>> +++ b/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi
>> @@ -150,8 +150,8 @@
>> pci_bridge@9,0 {
>> compatible = "pci0014,7a19.0",
>> "pci0014,7a19",
>> - "pciclass060400",
>> - "pciclass0604";
>> + "pciclass0b0300",
>> + "pciclass0b03";
>>
>> reg = <0x4800 0x0 0x0 0x0 0x0>;
>> #interrupt-cells = <1>;
>> @@ -163,10 +163,10 @@
>> };
>>
>> pci_bridge@a,0 {
>> - compatible = "pci0014,7a19.0",
>> - "pci0014,7a19",
>> - "pciclass060400",
>> - "pciclass0604";
>> + compatible = "pci0014,7a09.0",
>> + "pci0014,7a09",
>> + "pciclass0b0300",
>> + "pciclass0b03";
>>
>> reg = <0x5000 0x0 0x0 0x0 0x0>;
>> #interrupt-cells = <1>;
>> @@ -178,10 +178,10 @@
>> };
>>
>> pci_bridge@b,0 {
>> - compatible = "pci0014,7a19.0",
>> - "pci0014,7a19",
>> - "pciclass060400",
>> - "pciclass0604";
>> + compatible = "pci0014,7a09.0",
>> + "pci0014,7a09",
>> + "pciclass0b0300",
>> + "pciclass0b03";
>>
>> reg = <0x5800 0x0 0x0 0x0 0x0>;
>> #interrupt-cells = <1>;
>> @@ -193,10 +193,10 @@
>> };
>>
>> pci_bridge@c,0 {
>> - compatible = "pci0014,7a19.0",
>> - "pci0014,7a19",
>> - "pciclass060400",
>> - "pciclass0604";
>> + compatible = "pci0014,7a09.0",
>> + "pci0014,7a09",
>> + "pciclass0b0300",
>> + "pciclass0b03";
>>
>> reg = <0x6000 0x0 0x0 0x0 0x0>;
>> #interrupt-cells = <1>;
>> @@ -210,8 +210,8 @@
>> pci_bridge@d,0 {
>> compatible = "pci0014,7a19.0",
>> "pci0014,7a19",
>> - "pciclass060400",
>> - "pciclass0604";
>> + "pciclass0b0300",
>> + "pciclass0b03";
>>
>> reg = <0x6800 0x0 0x0 0x0 0x0>;
>> #interrupt-cells = <1>;
>> @@ -223,10 +223,10 @@
>> };
>>
>> pci_bridge@e,0 {
>> - compatible = "pci0014,7a19.0",
>> - "pci0014,7a19",
>> - "pciclass060400",
>> - "pciclass0604";
>> + compatible = "pci0014,7a09.0",
>> + "pci0014,7a09",
>> + "pciclass0b0300",
>> + "pciclass0b03";
>>
>> reg = <0x7000 0x0 0x0 0x0 0x0>;
>> #interrupt-cells = <1>;
>> --
>> 2.17.1
>>
>>
>
--
--xiaochuan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-25 12:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-25 5:28 [PATCH] MIPS:DTS:Correct device id and class code of pcie for Loongnon-2K Xiaochuan Mao
2021-04-25 10:39 ` Jiaxun Yang
2021-04-25 12:05 ` Xiaochuan Mao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®