From: Joe Perches <joe@perches.com>
To: MugilRaj <dmugil2000@gmail.com>
Cc: mugil2301 <110117057@nitt.edu>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Arve Hjønnevåg" <arve@android.com>,
"Todd Kjos" <tkjos@android.com>,
"Martijn Coenen" <maco@android.com>,
"Joel Fernandes" <joel@joelfernandes.org>,
"Christian Brauner" <christian@brauner.io>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] taging: android: ashmem: Declared const key
Date: Sat, 11 Apr 2020 12:41:26 -0700 [thread overview]
Message-ID: <8d097283a4676f7e1050c9d6664d89d710e21bcf.camel@perches.com> (raw)
In-Reply-To: <1586633396-24237-1-git-send-email-dmugil2000@gmail.com>
On Sun, 2020-04-12 at 00:59 +0530, MugilRaj wrote:
> From: mugil2301 <110117057@nitt.edu>
You need to verify the patch subject.
You need a change log message too.
> Signed-off-by: mugil2301 <110117057@nitt.edu>
You need to put your legal name here
> diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c
[]
> @@ -367,7 +367,7 @@ ashmem_vmfile_get_unmapped_area(struct file *file, unsigned long addr,
>
> static int ashmem_mmap(struct file *file, struct vm_area_struct *vma)
> {
> - static struct file_operations vmfile_fops;
> + static const struct file_operations vmfile_fops;
> struct ashmem_area *asma = file->private_data;
> int ret = 0;
(this won't compile)
checkpatch is not always right.
Do please compile the files changed by your patch
and verify change correctness before sending any
proposed patch.
next prev parent reply other threads:[~2020-04-11 19:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-11 19:29 MugilRaj
2020-04-11 19:41 ` Joe Perches [this message]
2020-04-11 20:44 ` kbuild test robot
2020-04-14 9:52 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d097283a4676f7e1050c9d6664d89d710e21bcf.camel@perches.com \
--to=joe@perches.com \
--cc=110117057@nitt.edu \
--cc=arve@android.com \
--cc=christian@brauner.io \
--cc=devel@driverdev.osuosl.org \
--cc=dmugil2000@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=joel@joelfernandes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maco@android.com \
--cc=tkjos@android.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®