* Re: [PATCH] drm/stm: add COMPILE_TEST to Kconfig (fwd)
@ 2017-05-19 7:49 Julia Lawall
2017-05-19 12:17 ` Philippe CORNU
0 siblings, 1 reply; 4+ messages in thread
From: Julia Lawall @ 2017-05-19 7:49 UTC (permalink / raw)
To: Masahiro Yamada
Cc: linux-kernel, Masahiro Yamada, Yannick Fertre, Philippe Cornu,
David Airlie, dri-devel, Daniel Vetter, linux-kernel,
Masahiro Yamada, Yannick Fertre, Philippe Cornu, David Airlie,
kbuild
On line 466, the preceeding comment suggests that the second constant
should start with VS rather than HS again.
julia
---------- Forwarded message ----------
Date: Fri, 19 May 2017 15:45:39 +0800
From: kbuild test robot <fengguang.wu@intel.com>
To: kbuild@01.org
Cc: Julia Lawall <julia.lawall@lip6.fr>
Subject: Re: [PATCH] drm/stm: add COMPILE_TEST to Kconfig
CC: kbuild-all@01.org
In-Reply-To: <1495082711-10535-1-git-send-email-yamada.masahiro@socionext.com>
TO: Masahiro Yamada <yamada.masahiro@socionext.com>
CC: dri-devel@lists.freedesktop.org, Daniel Vetter <daniel.vetter@intel.com>, linux-kernel@vger.kernel.org, Masahiro Yamada <yamada.masahiro@socionext.com>, Yannick Fertre <yannick.fertre@st.com>, Philippe Cornu <philippe.cornu@st.com>, David Airlie <airlied@linux.ie>
CC: linux-kernel@vger.kernel.org, Masahiro Yamada <yamada.masahiro@socionext.com>, Yannick Fertre <yannick.fertre@st.com>, Philippe Cornu <philippe.cornu@st.com>, David Airlie <airlied@linux.ie>
Hi Masahiro,
[auto build test WARNING on drm/drm-next]
[cannot apply to v4.12-rc1 next-20170518]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Masahiro-Yamada/drm-stm-add-COMPILE_TEST-to-Kconfig/20170519-131342
base: git://people.freedesktop.org/~airlied/linux.git drm-next
:::::: branch date: 3 hours ago
:::::: commit date: 3 hours ago
>> drivers/gpu/drm/stm/ltdc.c:466:7-15: duplicated argument to & or |
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout c669a25d907f95d3e13f1dae9812642330b4aa28
vim +466 drivers/gpu/drm/stm/ltdc.c
b759012c Yannick Fertre 2017-04-14 450 accum_vbp = vsync + vm.vback_porch;
b759012c Yannick Fertre 2017-04-14 451 accum_act_w = accum_hbp + vm.hactive;
b759012c Yannick Fertre 2017-04-14 452 accum_act_h = accum_vbp + vm.vactive;
b759012c Yannick Fertre 2017-04-14 453 total_width = accum_act_w + vm.hfront_porch;
b759012c Yannick Fertre 2017-04-14 454 total_height = accum_act_h + vm.vfront_porch;
b759012c Yannick Fertre 2017-04-14 455
b759012c Yannick Fertre 2017-04-14 456 clk_disable(ldev->pixel_clk);
b759012c Yannick Fertre 2017-04-14 457
b759012c Yannick Fertre 2017-04-14 458 if (clk_set_rate(ldev->pixel_clk, rate) < 0) {
b759012c Yannick Fertre 2017-04-14 459 DRM_ERROR("Cannot set rate (%dHz) for pixel clk\n", rate);
b759012c Yannick Fertre 2017-04-14 460 return;
b759012c Yannick Fertre 2017-04-14 461 }
b759012c Yannick Fertre 2017-04-14 462
b759012c Yannick Fertre 2017-04-14 463 clk_enable(ldev->pixel_clk);
b759012c Yannick Fertre 2017-04-14 464
b759012c Yannick Fertre 2017-04-14 465 /* Configures the HS, VS, DE and PC polarities. */
b759012c Yannick Fertre 2017-04-14 @466 val = HSPOL_AL | HSPOL_AL | DEPOL_AL | PCPOL_IPC;
b759012c Yannick Fertre 2017-04-14 467
b759012c Yannick Fertre 2017-04-14 468 if (vm.flags & DISPLAY_FLAGS_HSYNC_HIGH)
b759012c Yannick Fertre 2017-04-14 469 val |= HSPOL_AH;
b759012c Yannick Fertre 2017-04-14 470
b759012c Yannick Fertre 2017-04-14 471 if (vm.flags & DISPLAY_FLAGS_VSYNC_HIGH)
b759012c Yannick Fertre 2017-04-14 472 val |= VSPOL_AH;
b759012c Yannick Fertre 2017-04-14 473
b759012c Yannick Fertre 2017-04-14 474 if (vm.flags & DISPLAY_FLAGS_DE_HIGH)
:::::: The code at line 466 was first introduced by commit
:::::: b759012c5fa761ee08998c80fc4ad6343c258487 drm/stm: Add STM32 LTDC driver
:::::: TO: Yannick Fertre <yannick.fertre@st.com>
:::::: CC: Eric Anholt <eric@anholt.net>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/stm: add COMPILE_TEST to Kconfig (fwd)
2017-05-19 7:49 [PATCH] drm/stm: add COMPILE_TEST to Kconfig (fwd) Julia Lawall
@ 2017-05-19 12:17 ` Philippe CORNU
2017-05-20 17:32 ` Masahiro Yamada
0 siblings, 1 reply; 4+ messages in thread
From: Philippe CORNU @ 2017-05-19 12:17 UTC (permalink / raw)
To: Julia Lawall, Masahiro Yamada
Cc: linux-kernel, Yannick FERTRE, David Airlie, dri-devel,
Daniel Vetter, kbuild
On 05/19/2017 09:49 AM, Julia Lawall wrote:
> On line 466, the preceeding comment suggests that the second constant
> should start with VS rather than HS again.
>
> julia
>
> ---------- Forwarded message ----------
> Date: Fri, 19 May 2017 15:45:39 +0800
> From: kbuild test robot <fengguang.wu@intel.com>
> To: kbuild@01.org
> Cc: Julia Lawall <julia.lawall@lip6.fr>
> Subject: Re: [PATCH] drm/stm: add COMPILE_TEST to Kconfig
>
> CC: kbuild-all@01.org
> In-Reply-To: <1495082711-10535-1-git-send-email-yamada.masahiro@socionext.com>
> TO: Masahiro Yamada <yamada.masahiro@socionext.com>
> CC: dri-devel@lists.freedesktop.org, Daniel Vetter <daniel.vetter@intel.com>, linux-kernel@vger.kernel.org, Masahiro Yamada <yamada.masahiro@socionext.com>, Yannick Fertre <yannick.fertre@st.com>, Philippe Cornu <philippe.cornu@st.com>, David Airlie <airlied@linux.ie>
> CC: linux-kernel@vger.kernel.org, Masahiro Yamada <yamada.masahiro@socionext.com>, Yannick Fertre <yannick.fertre@st.com>, Philippe Cornu <philippe.cornu@st.com>, David Airlie <airlied@linux.ie>
>
> Hi Masahiro,
>
> [auto build test WARNING on drm/drm-next]
> [cannot apply to v4.12-rc1 next-20170518]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>
> url: https://github.com/0day-ci/linux/commits/Masahiro-Yamada/drm-stm-add-COMPILE_TEST-to-Kconfig/20170519-131342
> base: git://people.freedesktop.org/~airlied/linux.git drm-next
> :::::: branch date: 3 hours ago
> :::::: commit date: 3 hours ago
>
>>> drivers/gpu/drm/stm/ltdc.c:466:7-15: duplicated argument to & or |
>
> git remote add linux-review https://github.com/0day-ci/linux
> git remote update linux-review
> git checkout c669a25d907f95d3e13f1dae9812642330b4aa28
> vim +466 drivers/gpu/drm/stm/ltdc.c
>
> b759012c Yannick Fertre 2017-04-14 450 accum_vbp = vsync + vm.vback_porch;
> b759012c Yannick Fertre 2017-04-14 451 accum_act_w = accum_hbp + vm.hactive;
> b759012c Yannick Fertre 2017-04-14 452 accum_act_h = accum_vbp + vm.vactive;
> b759012c Yannick Fertre 2017-04-14 453 total_width = accum_act_w + vm.hfront_porch;
> b759012c Yannick Fertre 2017-04-14 454 total_height = accum_act_h + vm.vfront_porch;
> b759012c Yannick Fertre 2017-04-14 455
> b759012c Yannick Fertre 2017-04-14 456 clk_disable(ldev->pixel_clk);
> b759012c Yannick Fertre 2017-04-14 457
> b759012c Yannick Fertre 2017-04-14 458 if (clk_set_rate(ldev->pixel_clk, rate) < 0) {
> b759012c Yannick Fertre 2017-04-14 459 DRM_ERROR("Cannot set rate (%dHz) for pixel clk\n", rate);
> b759012c Yannick Fertre 2017-04-14 460 return;
> b759012c Yannick Fertre 2017-04-14 461 }
> b759012c Yannick Fertre 2017-04-14 462
> b759012c Yannick Fertre 2017-04-14 463 clk_enable(ldev->pixel_clk);
> b759012c Yannick Fertre 2017-04-14 464
> b759012c Yannick Fertre 2017-04-14 465 /* Configures the HS, VS, DE and PC polarities. */
> b759012c Yannick Fertre 2017-04-14 @466 val = HSPOL_AL | HSPOL_AL | DEPOL_AL | PCPOL_IPC;
Thanks Julia for your comments.
Masahiro, may I ask you please to propose a patch (simply rename the 2nd
HSPOL_AL to VSPOL_AL at line 466.) as the issue is revealed by your
patch named "drm/stm: add COMPILE_TEST to Kconfig".
Many thanks,
Philippe
> b759012c Yannick Fertre 2017-04-14 467
> b759012c Yannick Fertre 2017-04-14 468 if (vm.flags & DISPLAY_FLAGS_HSYNC_HIGH)
> b759012c Yannick Fertre 2017-04-14 469 val |= HSPOL_AH;
> b759012c Yannick Fertre 2017-04-14 470
> b759012c Yannick Fertre 2017-04-14 471 if (vm.flags & DISPLAY_FLAGS_VSYNC_HIGH)
> b759012c Yannick Fertre 2017-04-14 472 val |= VSPOL_AH;
> b759012c Yannick Fertre 2017-04-14 473
> b759012c Yannick Fertre 2017-04-14 474 if (vm.flags & DISPLAY_FLAGS_DE_HIGH)
>
> :::::: The code at line 466 was first introduced by commit
> :::::: b759012c5fa761ee08998c80fc4ad6343c258487 drm/stm: Add STM32 LTDC driver
>
> :::::: TO: Yannick Fertre <yannick.fertre@st.com>
> :::::: CC: Eric Anholt <eric@anholt.net>
>
> ---
> 0-DAY kernel test infrastructure Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all Intel Corporation
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/stm: add COMPILE_TEST to Kconfig (fwd)
2017-05-19 12:17 ` Philippe CORNU
@ 2017-05-20 17:32 ` Masahiro Yamada
2017-05-22 9:57 ` Philippe CORNU
0 siblings, 1 reply; 4+ messages in thread
From: Masahiro Yamada @ 2017-05-20 17:32 UTC (permalink / raw)
To: Philippe CORNU
Cc: Julia Lawall, linux-kernel, Yannick FERTRE, David Airlie,
dri-devel, Daniel Vetter, kbuild
Hi Philippe,
2017-05-19 21:17 GMT+09:00 Philippe CORNU <philippe.cornu@st.com>:
>
>
> On 05/19/2017 09:49 AM, Julia Lawall wrote:
>> On line 466, the preceeding comment suggests that the second constant
>> should start with VS rather than HS again.
>>
>> julia
>>
>> ---------- Forwarded message ----------
>> Date: Fri, 19 May 2017 15:45:39 +0800
>> From: kbuild test robot <fengguang.wu@intel.com>
>> To: kbuild@01.org
>> Cc: Julia Lawall <julia.lawall@lip6.fr>
>> Subject: Re: [PATCH] drm/stm: add COMPILE_TEST to Kconfig
>>
>> CC: kbuild-all@01.org
>> In-Reply-To: <1495082711-10535-1-git-send-email-yamada.masahiro@socionext.com>
>> TO: Masahiro Yamada <yamada.masahiro@socionext.com>
>> CC: dri-devel@lists.freedesktop.org, Daniel Vetter <daniel.vetter@intel.com>, linux-kernel@vger.kernel.org, Masahiro Yamada <yamada.masahiro@socionext.com>, Yannick Fertre <yannick.fertre@st.com>, Philippe Cornu <philippe.cornu@st.com>, David Airlie <airlied@linux.ie>
>> CC: linux-kernel@vger.kernel.org, Masahiro Yamada <yamada.masahiro@socionext.com>, Yannick Fertre <yannick.fertre@st.com>, Philippe Cornu <philippe.cornu@st.com>, David Airlie <airlied@linux.ie>
>>
>> Hi Masahiro,
>>
>> [auto build test WARNING on drm/drm-next]
>> [cannot apply to v4.12-rc1 next-20170518]
>> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>>
>> url: https://github.com/0day-ci/linux/commits/Masahiro-Yamada/drm-stm-add-COMPILE_TEST-to-Kconfig/20170519-131342
>> base: git://people.freedesktop.org/~airlied/linux.git drm-next
>> :::::: branch date: 3 hours ago
>> :::::: commit date: 3 hours ago
>>
>>>> drivers/gpu/drm/stm/ltdc.c:466:7-15: duplicated argument to & or |
>>
>> git remote add linux-review https://github.com/0day-ci/linux
>> git remote update linux-review
>> git checkout c669a25d907f95d3e13f1dae9812642330b4aa28
>> vim +466 drivers/gpu/drm/stm/ltdc.c
>>
>> b759012c Yannick Fertre 2017-04-14 450 accum_vbp = vsync + vm.vback_porch;
>> b759012c Yannick Fertre 2017-04-14 451 accum_act_w = accum_hbp + vm.hactive;
>> b759012c Yannick Fertre 2017-04-14 452 accum_act_h = accum_vbp + vm.vactive;
>> b759012c Yannick Fertre 2017-04-14 453 total_width = accum_act_w + vm.hfront_porch;
>> b759012c Yannick Fertre 2017-04-14 454 total_height = accum_act_h + vm.vfront_porch;
>> b759012c Yannick Fertre 2017-04-14 455
>> b759012c Yannick Fertre 2017-04-14 456 clk_disable(ldev->pixel_clk);
>> b759012c Yannick Fertre 2017-04-14 457
>> b759012c Yannick Fertre 2017-04-14 458 if (clk_set_rate(ldev->pixel_clk, rate) < 0) {
>> b759012c Yannick Fertre 2017-04-14 459 DRM_ERROR("Cannot set rate (%dHz) for pixel clk\n", rate);
>> b759012c Yannick Fertre 2017-04-14 460 return;
>> b759012c Yannick Fertre 2017-04-14 461 }
>> b759012c Yannick Fertre 2017-04-14 462
>> b759012c Yannick Fertre 2017-04-14 463 clk_enable(ldev->pixel_clk);
>> b759012c Yannick Fertre 2017-04-14 464
>> b759012c Yannick Fertre 2017-04-14 465 /* Configures the HS, VS, DE and PC polarities. */
>> b759012c Yannick Fertre 2017-04-14 @466 val = HSPOL_AL | HSPOL_AL | DEPOL_AL | PCPOL_IPC;
>
> Thanks Julia for your comments.
> Masahiro, may I ask you please to propose a patch (simply rename the 2nd
> HSPOL_AL to VSPOL_AL at line 466.) as the issue is revealed by your
> patch named "drm/stm: add COMPILE_TEST to Kconfig".
> Many thanks,
> Philippe
I added COMPILE_TEST, but my objective was to
easily test my ccflags-y cleanup works for Kbuild.
The change will not affect the behavior
(because both HSPOL_AL and HSPO_AL are defined as 0),
but I think it should be fixed by a person who is familiar with this driver.
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/stm: add COMPILE_TEST to Kconfig (fwd)
2017-05-20 17:32 ` Masahiro Yamada
@ 2017-05-22 9:57 ` Philippe CORNU
0 siblings, 0 replies; 4+ messages in thread
From: Philippe CORNU @ 2017-05-22 9:57 UTC (permalink / raw)
To: Masahiro Yamada
Cc: Julia Lawall, linux-kernel, Yannick FERTRE, David Airlie,
dri-devel, Daniel Vetter, kbuild
On 05/20/2017 07:32 PM, Masahiro Yamada wrote:
> Hi Philippe,
>
>
> 2017-05-19 21:17 GMT+09:00 Philippe CORNU <philippe.cornu@st.com>:
>>
>>
>> On 05/19/2017 09:49 AM, Julia Lawall wrote:
>>> On line 466, the preceeding comment suggests that the second constant
>>> should start with VS rather than HS again.
>>>
>>> julia
>>>
>>> ---------- Forwarded message ----------
>>> Date: Fri, 19 May 2017 15:45:39 +0800
>>> From: kbuild test robot <fengguang.wu@intel.com>
>>> To: kbuild@01.org
>>> Cc: Julia Lawall <julia.lawall@lip6.fr>
>>> Subject: Re: [PATCH] drm/stm: add COMPILE_TEST to Kconfig
>>>
>>> CC: kbuild-all@01.org
>>> In-Reply-To: <1495082711-10535-1-git-send-email-yamada.masahiro@socionext.com>
>>> TO: Masahiro Yamada <yamada.masahiro@socionext.com>
>>> CC: dri-devel@lists.freedesktop.org, Daniel Vetter <daniel.vetter@intel.com>, linux-kernel@vger.kernel.org, Masahiro Yamada <yamada.masahiro@socionext.com>, Yannick Fertre <yannick.fertre@st.com>, Philippe Cornu <philippe.cornu@st.com>, David Airlie <airlied@linux.ie>
>>> CC: linux-kernel@vger.kernel.org, Masahiro Yamada <yamada.masahiro@socionext.com>, Yannick Fertre <yannick.fertre@st.com>, Philippe Cornu <philippe.cornu@st.com>, David Airlie <airlied@linux.ie>
>>>
>>> Hi Masahiro,
>>>
>>> [auto build test WARNING on drm/drm-next]
>>> [cannot apply to v4.12-rc1 next-20170518]
>>> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>>>
>>> url: https://github.com/0day-ci/linux/commits/Masahiro-Yamada/drm-stm-add-COMPILE_TEST-to-Kconfig/20170519-131342
>>> base: git://people.freedesktop.org/~airlied/linux.git drm-next
>>> :::::: branch date: 3 hours ago
>>> :::::: commit date: 3 hours ago
>>>
>>>>> drivers/gpu/drm/stm/ltdc.c:466:7-15: duplicated argument to & or |
>>>
>>> git remote add linux-review https://github.com/0day-ci/linux
>>> git remote update linux-review
>>> git checkout c669a25d907f95d3e13f1dae9812642330b4aa28
>>> vim +466 drivers/gpu/drm/stm/ltdc.c
>>>
>>> b759012c Yannick Fertre 2017-04-14 450 accum_vbp = vsync + vm.vback_porch;
>>> b759012c Yannick Fertre 2017-04-14 451 accum_act_w = accum_hbp + vm.hactive;
>>> b759012c Yannick Fertre 2017-04-14 452 accum_act_h = accum_vbp + vm.vactive;
>>> b759012c Yannick Fertre 2017-04-14 453 total_width = accum_act_w + vm.hfront_porch;
>>> b759012c Yannick Fertre 2017-04-14 454 total_height = accum_act_h + vm.vfront_porch;
>>> b759012c Yannick Fertre 2017-04-14 455
>>> b759012c Yannick Fertre 2017-04-14 456 clk_disable(ldev->pixel_clk);
>>> b759012c Yannick Fertre 2017-04-14 457
>>> b759012c Yannick Fertre 2017-04-14 458 if (clk_set_rate(ldev->pixel_clk, rate) < 0) {
>>> b759012c Yannick Fertre 2017-04-14 459 DRM_ERROR("Cannot set rate (%dHz) for pixel clk\n", rate);
>>> b759012c Yannick Fertre 2017-04-14 460 return;
>>> b759012c Yannick Fertre 2017-04-14 461 }
>>> b759012c Yannick Fertre 2017-04-14 462
>>> b759012c Yannick Fertre 2017-04-14 463 clk_enable(ldev->pixel_clk);
>>> b759012c Yannick Fertre 2017-04-14 464
>>> b759012c Yannick Fertre 2017-04-14 465 /* Configures the HS, VS, DE and PC polarities. */
>>> b759012c Yannick Fertre 2017-04-14 @466 val = HSPOL_AL | HSPOL_AL | DEPOL_AL | PCPOL_IPC;
>>
>> Thanks Julia for your comments.
>> Masahiro, may I ask you please to propose a patch (simply rename the 2nd
>> HSPOL_AL to VSPOL_AL at line 466.) as the issue is revealed by your
>> patch named "drm/stm: add COMPILE_TEST to Kconfig".
>> Many thanks,
>> Philippe
>
>
> I added COMPILE_TEST, but my objective was to
> easily test my ccflags-y cleanup works for Kbuild.
>
> The change will not affect the behavior
> (because both HSPOL_AL and HSPO_AL are defined as 0),
> but I think it should be fixed by a person who is familiar with this driver.
>
>
>
>
I sent a patch to fix this small issue detected during COMPILE_TEST.
Many thanks
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-05-22 9:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-19 7:49 [PATCH] drm/stm: add COMPILE_TEST to Kconfig (fwd) Julia Lawall
2017-05-19 12:17 ` Philippe CORNU
2017-05-20 17:32 ` Masahiro Yamada
2017-05-22 9:57 ` Philippe CORNU
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®