mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sander Vanheule <sander@svanheule.net>
To: adilov <adilov@disroot.org>
Cc: Linus Walleij <linusw@kernel.org>,
	Bartosz Golaszewski <brgl@kernel.org>,
	 Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	 Bert Vermeulen	 <bert@biot.com>,
	linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
	 linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] gpio: realtek-otto: add rtl9607 support
Date: Thu, 05 Mar 2026 22:49:41 +0100	[thread overview]
Message-ID: <8d382a35b5e2304b4c869ced560c0c3880af5b84.camel@svanheule.net> (raw)
In-Reply-To: <6a8538a1990dc02a6a0bdbf60ebd747f@disroot.org>

Hi,

On Thu, 2026-03-05 at 19:54 +0000, adilov wrote:
> On 2026-03-05 19:04, Sander Vanheule wrote:
> > On Thu, 2026-03-05 at 21:11 +0500, Rustam Adilov wrote:,
> > > +	{
> > > +		.compatible = "realtek,rtl9607-gpio",
> > > +		.data = (void *)GPIO_PORTS_REVERSED,
> > > +	},
> > If I'm not mistaken, this SoC has a MIPS InterAptiv CPU like the 
> > RTL931x SoC
> > series. Were you able to validate that the interrupts are functioning 
> > as
> > expected?
> > 
> > Best,
> > Sander
> 
> Hi Sander,
> 
> Yes, this is correct. I played around with gpio-keys in OpenWrt (though 
> it
> has its own gpio-button-hotplug but it should not change things) and can
> verify that button presses and releases are working. I think this should
> confirm that interrupts are functional.

Thanks for the info. I was mainly wondering because there seemed to be some
initial confusion [1] about the port order. If you get the order wrong, you
would be getting spurious interrupts.

[1] https://forum.openwrt.org/t/240741/25

If the order is correct, you should see the key GPIO interrupt increase in
/proc/interrupts. So, assuming that's the case:

Reviewed-by: Sander Vanheule <sander@svanheule.net>

Best,
Sander

  reply	other threads:[~2026-03-05 21:49 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-05 16:11 [PATCH 0/2] support for RTL9607C GPIO Controller Rustam Adilov
2026-03-05 16:11 ` [PATCH 1/2] dt-bindings: gpio: realtek-otto: add rtl9607 compatible Rustam Adilov
2026-03-05 18:59   ` Sander Vanheule
2026-03-08 23:50   ` Linus Walleij
2026-03-05 16:11 ` [PATCH 2/2] gpio: realtek-otto: add rtl9607 support Rustam Adilov
2026-03-05 19:04   ` Sander Vanheule
2026-03-05 19:54     ` adilov
2026-03-05 21:49       ` Sander Vanheule [this message]
2026-03-06 17:39         ` Rustam Adilov
2026-03-10  9:10 ` [PATCH 0/2] support for RTL9607C GPIO Controller Bartosz Golaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8d382a35b5e2304b4c869ced560c0c3880af5b84.camel@svanheule.net \
    --to=sander@svanheule.net \
    --cc=adilov@disroot.org \
    --cc=bert@biot.com \
    --cc=brgl@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linusw@kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®