From: Stian Halseth <stian@itx.no>
To: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
Eric Biggers <ebiggers@kernel.org>,
linux-crypto@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Ard Biesheuvel <ardb@kernel.org>,
"Jason A . Donenfeld" <Jason@zx2c4.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
sparclinux@vger.kernel.org
Subject: Re: [PATCH v3] crypto: aes - Fix undesired override of some optimized AES modes
Date: Wed, 30 Sep 2026 16:07:16 +0200 [thread overview]
Message-ID: <8d3d3142d1ac323695a3ea2d5b3e2a10d2a129d6.camel@itx.no> (raw)
In-Reply-To: <3ea57d640ac7409fa37b15ec9e3f49126347e432.camel@physik.fu-berlin.de>
[-- Attachment #1: Type: text/plain, Size: 1360 bytes --]
Hi Adrian,
On Wed, 2026-09-30 at 11:27 +0200, John Paul Adrian Glaubitz wrote:
>
>
> > The T2 and T3 has a separate crypto unit, but not supported here.
> > Support was removed from the kernel in 6.14. Haven't tested it, as
> > I
> > don't have the hardware.
>
> Why was it removed? I'm not happy about such removals as long as the
> hardware is supported.
Looks like there were issues that prompted the removal:
https://github.com/torvalds/linux/commit/9cda46babdfe
>
> > Also worth noting, it's only used when the firmware lists the
> > machine
> > description's hwcap-list and the CFR has its bit set.
>
> Is that not the case by default?
Yes, on real hardware. Just mentioned to clarify that it doesn't cause
problems on hardware that doesn't support it.
> > I have no idea about Fujitsu's SPARC64 X family.
>
> I think SPARC64 X is not supported by the Linux kernel at all, is it?
>
There some chip detection for it, but I've never tested, or heard about
anyone actually using it.
sparc64: correctly recognize SPARC64-X chips
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=76950e6e54ccfc98a25b501dbb1bc879cce1aa29
cpu hw caps support for sparc64x:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=4e96377983d2e060dd89703f1846ad920af9e17f
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2026-09-30 14:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-29 22:27 Eric Biggers
2026-09-30 5:50 ` Ard Biesheuvel
2026-09-30 7:32 ` Stian Halseth
2026-09-30 7:41 ` John Paul Adrian Glaubitz
2026-09-30 9:15 ` Stian Halseth
2026-09-30 9:27 ` John Paul Adrian Glaubitz
2026-09-30 14:07 ` Stian Halseth [this message]
2026-09-30 16:03 ` Magnus Lindholm
2026-09-30 17:25 ` Stian Halseth
2026-09-30 20:12 ` John Paul Adrian Glaubitz
2026-09-30 16:34 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d3d3142d1ac323695a3ea2d5b3e2a10d2a129d6.camel@itx.no \
--to=stian@itx.no \
--cc=Jason@zx2c4.com \
--cc=ardb@kernel.org \
--cc=ebiggers@kernel.org \
--cc=glaubitz@physik.fu-berlin.de \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®