From: Babu Moger <babu.moger@amd.com>
To: <corbet@lwn.net>, <fenghua.yu@intel.com>,
<reinette.chatre@intel.com>, <tglx@linutronix.de>,
<mingo@redhat.com>, <bp@alien8.de>, <dave.hansen@linux.intel.com>
Cc: <x86@kernel.org>, <hpa@zytor.com>, <paulmck@kernel.org>,
<rdunlap@infradead.org>, <tj@kernel.org>, <peterz@infradead.org>,
<yanjiewtw@gmail.com>, <babu.moger@amd.com>,
<kim.phillips@amd.com>, <lukas.bulwahn@gmail.com>,
<seanjc@google.com>, <jmattson@google.com>, <leitao@debian.org>,
<jpoimboe@kernel.org>, <rick.p.edgecombe@intel.com>,
<kirill.shutemov@linux.intel.com>, <jithu.joseph@intel.com>,
<kai.huang@intel.com>, <kan.liang@linux.intel.com>,
<daniel.sneddon@linux.intel.com>, <pbonzini@redhat.com>,
<sandipan.das@amd.com>, <ilpo.jarvinen@linux.intel.com>,
<peternewman@google.com>, <maciej.wieczor-retman@intel.com>,
<linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<eranian@google.com>, <james.morse@arm.com>
Subject: [RFC PATCH v3 06/17] x86/resctrl: Introduce interface to display number of ABMC counters
Date: Thu, 28 Mar 2024 20:06:39 -0500 [thread overview]
Message-ID: <8d3e07ecaf178ca0a42894d6d07a4f047bb3e689.1711674410.git.babu.moger@amd.com> (raw)
In-Reply-To: <cover.1711674410.git.babu.moger@amd.com>
The ABMC feature provides an option to the user to pin (or assign) the
RMID to the hardware counter and monitor the bandwidth for a longer
duration. There are only a limited number of hardware counters.
Provide the interface to display the number of ABMC counters supported.
Signed-off-by: Babu Moger <babu.moger@amd.com>
---
v3: Changed the field name to mbm_assign_cntrs.
v2: Changed the field name to mbm_assignable_counters from abmc_counters.
---
Documentation/arch/x86/resctrl.rst | 4 ++++
arch/x86/kernel/cpu/resctrl/monitor.c | 1 +
arch/x86/kernel/cpu/resctrl/rdtgroup.c | 16 ++++++++++++++++
3 files changed, 21 insertions(+)
diff --git a/Documentation/arch/x86/resctrl.rst b/Documentation/arch/x86/resctrl.rst
index cd973a013525..e06ffddb64f6 100644
--- a/Documentation/arch/x86/resctrl.rst
+++ b/Documentation/arch/x86/resctrl.rst
@@ -262,6 +262,10 @@ with the following files:
Reports the list of assignable features supported and the enclosed brackets
indicate the feature is enabled.
+"mbm_assign_cntrs":
+ The number of assignable counters available when the assignable monitoring
+ feature is supported.
+
"max_threshold_occupancy":
Read/write file provides the largest value (in
bytes) at which a previously used LLC_occupancy
diff --git a/arch/x86/kernel/cpu/resctrl/monitor.c b/arch/x86/kernel/cpu/resctrl/monitor.c
index 48d1957ea5a3..56dc49021540 100644
--- a/arch/x86/kernel/cpu/resctrl/monitor.c
+++ b/arch/x86/kernel/cpu/resctrl/monitor.c
@@ -1061,6 +1061,7 @@ int __init rdt_get_mon_l3_config(struct rdt_resource *r)
if (resctrl_arch_has_abmc(r)) {
r->mbm_assign_capable = ABMC_ASSIGN;
resctrl_file_fflags_init("mbm_assign", RFTYPE_MON_INFO);
+ resctrl_file_fflags_init("mbm_assign_cntrs", RFTYPE_MON_INFO);
}
}
diff --git a/arch/x86/kernel/cpu/resctrl/rdtgroup.c b/arch/x86/kernel/cpu/resctrl/rdtgroup.c
index 5ec807e8dd38..05f551bc316e 100644
--- a/arch/x86/kernel/cpu/resctrl/rdtgroup.c
+++ b/arch/x86/kernel/cpu/resctrl/rdtgroup.c
@@ -857,6 +857,16 @@ static int rdtgroup_mbm_assign_show(struct kernfs_open_file *of,
return 0;
}
+static int rdtgroup_mbm_assign_cntrs_show(struct kernfs_open_file *of,
+ struct seq_file *s, void *v)
+{
+ struct rdt_resource *r = of->kn->parent->priv;
+
+ seq_printf(s, "%d\n", r->mbm_assign_cntrs);
+
+ return 0;
+}
+
#ifdef CONFIG_PROC_CPU_RESCTRL
/*
@@ -1920,6 +1930,12 @@ static struct rftype res_common_files[] = {
.kf_ops = &rdtgroup_kf_single_ops,
.seq_show = rdtgroup_mbm_assign_show,
},
+ {
+ .name = "mbm_assign_cntrs",
+ .mode = 0444,
+ .kf_ops = &rdtgroup_kf_single_ops,
+ .seq_show = rdtgroup_mbm_assign_cntrs_show,
+ },
{
.name = "cpus",
.mode = 0644,
--
2.34.1
next prev parent reply other threads:[~2024-03-29 1:07 UTC|newest]
Thread overview: 108+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-29 1:06 [RFC PATCH v3 00/17] x86/resctrl : Support AMD Assignable Bandwidth Monitoring Counters (ABMC) Babu Moger
2024-03-29 1:06 ` [RFC PATCH v3 01/17] x86/resctrl: Add support for " Babu Moger
2024-05-03 23:25 ` Reinette Chatre
2024-05-06 17:57 ` Moger, Babu
2024-03-29 1:06 ` [RFC PATCH v3 02/17] x86/resctrl: Add ABMC feature in the command line options Babu Moger
2024-03-29 1:06 ` [RFC PATCH v3 03/17] x86/resctrl: Detect Assignable Bandwidth Monitoring feature details Babu Moger
2024-05-03 23:26 ` Reinette Chatre
2024-05-06 19:09 ` Moger, Babu
2024-05-07 20:27 ` Reinette Chatre
2024-05-09 22:34 ` Moger, Babu
2024-05-10 3:18 ` Reinette Chatre
2024-05-10 17:01 ` Moger, Babu
2024-05-10 18:34 ` Reinette Chatre
2024-05-11 1:40 ` Moger, Babu
2024-03-29 1:06 ` [RFC PATCH v3 04/17] x86/resctrl: Introduce resctrl_file_fflags_init Babu Moger
2024-05-03 23:26 ` Reinette Chatre
2024-05-06 20:23 ` Moger, Babu
2024-05-07 20:27 ` Reinette Chatre
2024-05-10 0:23 ` Moger, Babu
2024-03-29 1:06 ` [RFC PATCH v3 05/17] x86/resctrl: Introduce the interface to display the assignment state Babu Moger
2024-05-03 23:28 ` Reinette Chatre
2024-05-07 16:28 ` Moger, Babu
2024-05-07 20:32 ` Reinette Chatre
2024-03-29 1:06 ` Babu Moger [this message]
2024-03-29 1:06 ` [RFC PATCH v3 07/17] x86/resctrl: Add support to enable/disable ABMC feature Babu Moger
2024-04-04 0:30 ` Peter Newman
2024-04-04 15:16 ` Moger, Babu
2024-04-04 17:36 ` Peter Newman
2024-04-04 18:35 ` Moger, Babu
2024-04-04 18:43 ` Reinette Chatre
2024-04-04 19:01 ` Peter Newman
2024-05-16 20:03 ` Moger, Babu
2024-05-03 23:30 ` Reinette Chatre
2024-05-07 19:12 ` Moger, Babu
2024-05-07 20:32 ` Reinette Chatre
2024-05-09 21:45 ` Moger, Babu
2024-03-29 1:06 ` [RFC PATCH v3 08/17] x86/resctrl: Initialize assignable counters bitmap Babu Moger
2024-05-03 23:31 ` Reinette Chatre
2024-05-07 20:03 ` Moger, Babu
2024-03-29 1:06 ` [RFC PATCH v3 09/17] x86/resctrl: Introduce assign state for the mon group Babu Moger
2024-04-16 18:52 ` Peter Newman
2024-04-16 19:52 ` Moger, Babu
2024-03-29 1:06 ` [RFC PATCH v3 10/17] x86/resctrl: Add data structures for ABMC assignment Babu Moger
2024-05-03 23:32 ` Reinette Chatre
2024-05-07 20:40 ` Moger, Babu
2024-05-07 23:06 ` Reinette Chatre
2024-05-10 0:28 ` Moger, Babu
2024-03-29 1:06 ` [RFC PATCH v3 11/17] x86/resctrl: Introduce mbm_total_cfg and mbm_local_cfg Babu Moger
2024-05-03 23:33 ` Reinette Chatre
2024-05-08 15:57 ` Moger, Babu
2024-03-29 1:06 ` [RFC PATCH v3 12/17] x86/resctrl: Add the functionality to assign the RMID Babu Moger
2024-05-03 23:33 ` Reinette Chatre
2024-05-08 17:40 ` Moger, Babu
2024-03-29 1:06 ` [RFC PATCH v3 13/17] x86/resctrl: Add the functionality to unassign " Babu Moger
2024-03-29 1:06 ` [RFC PATCH v3 14/17] x86/resctrl: Enable ABMC by default on resctrl mount Babu Moger
2024-03-29 1:06 ` [RFC PATCH v3 15/17] x86/resctrl: Introduce the interface switch between ABMC and legacy_mbm Babu Moger
2024-03-29 1:06 ` [RFC PATCH v3 16/17] x86/resctrl: Introduce interface to list assignment states of all the groups Babu Moger
2024-03-29 1:06 ` [RFC PATCH v3 17/17] x86/resctrl: Introduce interface to modify assignment states of " Babu Moger
2024-04-17 17:45 ` Peter Newman
2024-04-17 19:39 ` Moger, Babu
2024-04-17 20:56 ` Peter Newman
2024-04-17 22:52 ` Moger, Babu
2024-05-02 23:00 ` Reinette Chatre
2024-05-03 16:14 ` Moger, Babu
2024-05-03 21:16 ` Reinette Chatre
2024-05-06 18:09 ` Moger, Babu
2024-05-02 16:21 ` Dave Martin
2024-05-02 17:52 ` Reinette Chatre
2024-05-02 18:11 ` Moger, Babu
2024-05-03 14:53 ` Dave Martin
2024-05-03 21:15 ` Reinette Chatre
2024-04-04 19:08 ` [RFC PATCH v3 00/17] x86/resctrl : Support AMD Assignable Bandwidth Monitoring Counters (ABMC) Peter Newman
2024-04-04 20:02 ` Moger, Babu
2024-04-22 16:34 ` Dave Martin
2024-04-22 20:44 ` Moger, Babu
2024-04-23 12:37 ` Dave Martin
2024-04-24 4:15 ` Reinette Chatre
2024-04-24 14:16 ` Dave Martin
2024-04-24 19:10 ` Moger, Babu
2024-04-22 16:33 ` Dave Martin
2024-04-22 18:23 ` Peter Newman
2024-04-23 12:38 ` Dave Martin
2024-04-23 15:43 ` Moger, Babu
2024-04-23 16:17 ` Dave Martin
2024-05-01 17:48 ` Peter Newman
2024-05-02 16:25 ` Moger, Babu
2024-05-02 17:50 ` Peter Newman
2024-05-02 20:14 ` Moger, Babu
2024-05-02 23:21 ` Reinette Chatre
2024-05-03 0:57 ` Peter Newman
2024-05-03 20:44 ` Moger, Babu
2024-05-03 21:00 ` Peter Newman
2024-05-03 21:15 ` Reinette Chatre
2024-05-17 21:51 ` Peter Newman
2024-05-20 14:25 ` Moger, Babu
2024-05-20 16:00 ` Peter Newman
2024-05-20 18:03 ` Moger, Babu
2024-05-10 0:57 ` Moger, Babu
2024-05-10 2:47 ` Reinette Chatre
2024-05-03 21:14 ` Reinette Chatre
2024-05-03 23:24 ` Reinette Chatre
2024-05-06 17:18 ` Moger, Babu
2024-05-07 20:26 ` Reinette Chatre
2024-05-08 20:07 ` Moger, Babu
2024-05-08 20:41 ` Reinette Chatre
2024-05-08 23:29 ` Moger, Babu
2024-05-09 18:07 ` Reinette Chatre
2024-05-09 20:34 ` Moger, Babu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d3e07ecaf178ca0a42894d6d07a4f047bb3e689.1711674410.git.babu.moger@amd.com \
--to=babu.moger@amd.com \
--cc=bp@alien8.de \
--cc=corbet@lwn.net \
--cc=daniel.sneddon@linux.intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=eranian@google.com \
--cc=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=james.morse@arm.com \
--cc=jithu.joseph@intel.com \
--cc=jmattson@google.com \
--cc=jpoimboe@kernel.org \
--cc=kai.huang@intel.com \
--cc=kan.liang@linux.intel.com \
--cc=kim.phillips@amd.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=leitao@debian.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=maciej.wieczor-retman@intel.com \
--cc=mingo@redhat.com \
--cc=paulmck@kernel.org \
--cc=pbonzini@redhat.com \
--cc=peternewman@google.com \
--cc=peterz@infradead.org \
--cc=rdunlap@infradead.org \
--cc=reinette.chatre@intel.com \
--cc=rick.p.edgecombe@intel.com \
--cc=sandipan.das@amd.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=x86@kernel.org \
--cc=yanjiewtw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®