From: Randy Dunlap <rdunlap@infradead.org>
To: AristoChen <jj251510319013@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix typo in f_printer.c
Date: Sat, 13 Feb 2021 23:05:56 -0800 [thread overview]
Message-ID: <8d5e7e34-b9ff-c1fa-1447-112bdbf6f2c7@infradead.org> (raw)
In-Reply-To: <20210214065354.5490-1-jj251510319013@gmail.com>
On 2/13/21 10:53 PM, AristoChen wrote:
> In line 824, it is trying to open `out_ep`, so
> I believe in line 826, it should print `out_ep`
> instead of `in_ep`
>
> Signed-off-by: AristoChen <jj251510319013@gmail.com>
> ---
> drivers/usb/gadget/function/f_printer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/gadget/function/f_printer.c b/drivers/usb/gadget/function/f_printer.c
> index 2f1eb2e81d30..a3b17ec00bf0 100644
> --- a/drivers/usb/gadget/function/f_printer.c
> +++ b/drivers/usb/gadget/function/f_printer.c
> @@ -823,7 +823,7 @@ set_printer_interface(struct printer_dev *dev)
>
> result = usb_ep_enable(dev->out_ep);
> if (result != 0) {
> - DBG(dev, "enable %s --> %d\n", dev->in_ep->name, result);
> + DBG(dev, "enable %s --> %d\n", dev->out_ep->name, result);
> goto done;
> }
>
>
Hi,
The patch makes sense.
You should Cc: the USB gadget maintainer and the linux-usb mailing list.
Thanks.
next prev parent reply other threads:[~2021-02-14 7:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-14 6:53 AristoChen
2021-02-14 7:05 ` Randy Dunlap [this message]
2021-02-14 9:40 AristoChen
2021-02-14 9:47 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d5e7e34-b9ff-c1fa-1447-112bdbf6f2c7@infradead.org \
--to=rdunlap@infradead.org \
--cc=jj251510319013@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®