mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: AristoChen <jj251510319013@gmail.com>
Cc: linux-kernel@vger.kernel.org, balbi@kernel.org,
	linux-usb@vger.kernel.org
Subject: Re: [PATCH] Fix typo in f_printer.c
Date: Sun, 14 Feb 2021 10:47:22 +0100	[thread overview]
Message-ID: <YCjxqontDxHYq+cH@kroah.com> (raw)
In-Reply-To: <20210214094025.7380-1-jj251510319013@gmail.com>

On Sun, Feb 14, 2021 at 05:40:25PM +0800, AristoChen wrote:
> In line 824, it is trying to open `out_ep`, so
> I believe in line 826, it should print `out_ep`
> instead of `in_ep`
> 
> Signed-off-by: AristoChen <jj251510319013@gmail.com>
> ---
>  drivers/usb/gadget/function/f_printer.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/gadget/function/f_printer.c b/drivers/usb/gadget/function/f_printer.c
> index 2f1eb2e81d30..a3b17ec00bf0 100644
> --- a/drivers/usb/gadget/function/f_printer.c
> +++ b/drivers/usb/gadget/function/f_printer.c
> @@ -823,7 +823,7 @@ set_printer_interface(struct printer_dev *dev)
>  
>  	result = usb_ep_enable(dev->out_ep);
>  	if (result != 0) {
> -		DBG(dev, "enable %s --> %d\n", dev->in_ep->name, result);
> +		DBG(dev, "enable %s --> %d\n", dev->out_ep->name, result);
>  		goto done;
>  	}
>  
> -- 
> 2.25.1
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- You did not write a descriptive Subject: for the patch, allowing Greg,
  and everyone else, to know what this patch is all about.  Please read
  the section entitled "The canonical patch format" in the kernel file,
  Documentation/SubmittingPatches for what a proper Subject: line should
  look like.

- It looks like you did not use your "real" name for the patch on either
  the Signed-off-by: line, or the From: line (both of which have to
  match).  Please read the kernel file, Documentation/SubmittingPatches
  for how to do this correctly.


If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot

  reply	other threads:[~2021-02-14  9:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-14  9:40 AristoChen
2021-02-14  9:47 ` Greg KH [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-02-14  6:53 AristoChen
2021-02-14  7:05 ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YCjxqontDxHYq+cH@kroah.com \
    --to=greg@kroah.com \
    --cc=balbi@kernel.org \
    --cc=jj251510319013@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®