* [PATCH] arm64: dts: qcom: sm8650: Fix CDSP context banks unit addresses
@ 2024-11-04 14:42 Krzysztof Kozlowski
2024-11-04 14:45 ` Konrad Dybcio
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2024-11-04 14:42 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Ling Xu, linux-arm-msm, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
There is a mismatch between 'reg' property and unit address for last
there CDSP compute context banks. Current values were taken as-is from
downstream source. Considering that 'reg' is used by Linux driver as
SID of context bank and that least significant bytes of IOMMU value
match the 'reg', assume the unit-address is wrong and needs fixing.
This also won't have any practical impact, except adhering to Devicetree
spec.
Fixes: dae8cdb0a9e1 ("arm64: dts: qcom: sm8650: Add three missing fastrpc-compute-cb nodes")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/qcom/sm8650.dtsi | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sm8650.dtsi b/arch/arm64/boot/dts/qcom/sm8650.dtsi
index 3d8a807a81c9..367fdd090768 100644
--- a/arch/arm64/boot/dts/qcom/sm8650.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8650.dtsi
@@ -5622,7 +5622,7 @@ compute-cb@8 {
/* note: secure cb9 in downstream */
- compute-cb@10 {
+ compute-cb@12 {
compatible = "qcom,fastrpc-compute-cb";
reg = <12>;
@@ -5632,7 +5632,7 @@ compute-cb@10 {
dma-coherent;
};
- compute-cb@11 {
+ compute-cb@13 {
compatible = "qcom,fastrpc-compute-cb";
reg = <13>;
@@ -5642,7 +5642,7 @@ compute-cb@11 {
dma-coherent;
};
- compute-cb@12 {
+ compute-cb@14 {
compatible = "qcom,fastrpc-compute-cb";
reg = <14>;
--
2.43.0
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: qcom: sm8650: Fix CDSP context banks unit addresses
2024-11-04 14:42 [PATCH] arm64: dts: qcom: sm8650: Fix CDSP context banks unit addresses Krzysztof Kozlowski
@ 2024-11-04 14:45 ` Konrad Dybcio
2024-11-04 15:04 ` neil.armstrong
2024-12-27 4:40 ` Bjorn Andersson
2 siblings, 0 replies; 4+ messages in thread
From: Konrad Dybcio @ 2024-11-04 14:45 UTC (permalink / raw)
To: Krzysztof Kozlowski, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Ling Xu, linux-arm-msm,
devicetree, linux-kernel
On 4.11.2024 3:42 PM, Krzysztof Kozlowski wrote:
> There is a mismatch between 'reg' property and unit address for last
> there CDSP compute context banks. Current values were taken as-is from
> downstream source. Considering that 'reg' is used by Linux driver as
> SID of context bank and that least significant bytes of IOMMU value
> match the 'reg', assume the unit-address is wrong and needs fixing.
> This also won't have any practical impact, except adhering to Devicetree
> spec.
>
> Fixes: dae8cdb0a9e1 ("arm64: dts: qcom: sm8650: Add three missing fastrpc-compute-cb nodes")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: qcom: sm8650: Fix CDSP context banks unit addresses
2024-11-04 14:42 [PATCH] arm64: dts: qcom: sm8650: Fix CDSP context banks unit addresses Krzysztof Kozlowski
2024-11-04 14:45 ` Konrad Dybcio
@ 2024-11-04 15:04 ` neil.armstrong
2024-12-27 4:40 ` Bjorn Andersson
2 siblings, 0 replies; 4+ messages in thread
From: neil.armstrong @ 2024-11-04 15:04 UTC (permalink / raw)
To: Krzysztof Kozlowski, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Ling Xu, linux-arm-msm,
devicetree, linux-kernel
On 04/11/2024 15:42, Krzysztof Kozlowski wrote:
> There is a mismatch between 'reg' property and unit address for last
> there CDSP compute context banks. Current values were taken as-is from
> downstream source. Considering that 'reg' is used by Linux driver as
> SID of context bank and that least significant bytes of IOMMU value
> match the 'reg', assume the unit-address is wrong and needs fixing.
> This also won't have any practical impact, except adhering to Devicetree
> spec.
>
> Fixes: dae8cdb0a9e1 ("arm64: dts: qcom: sm8650: Add three missing fastrpc-compute-cb nodes")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/sm8650.dtsi | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8650.dtsi b/arch/arm64/boot/dts/qcom/sm8650.dtsi
> index 3d8a807a81c9..367fdd090768 100644
> --- a/arch/arm64/boot/dts/qcom/sm8650.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8650.dtsi
> @@ -5622,7 +5622,7 @@ compute-cb@8 {
>
> /* note: secure cb9 in downstream */
>
> - compute-cb@10 {
> + compute-cb@12 {
> compatible = "qcom,fastrpc-compute-cb";
> reg = <12>;
>
> @@ -5632,7 +5632,7 @@ compute-cb@10 {
> dma-coherent;
> };
>
> - compute-cb@11 {
> + compute-cb@13 {
> compatible = "qcom,fastrpc-compute-cb";
> reg = <13>;
>
> @@ -5642,7 +5642,7 @@ compute-cb@11 {
> dma-coherent;
> };
>
> - compute-cb@12 {
> + compute-cb@14 {
> compatible = "qcom,fastrpc-compute-cb";
> reg = <14>;
>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: qcom: sm8650: Fix CDSP context banks unit addresses
2024-11-04 14:42 [PATCH] arm64: dts: qcom: sm8650: Fix CDSP context banks unit addresses Krzysztof Kozlowski
2024-11-04 14:45 ` Konrad Dybcio
2024-11-04 15:04 ` neil.armstrong
@ 2024-12-27 4:40 ` Bjorn Andersson
2 siblings, 0 replies; 4+ messages in thread
From: Bjorn Andersson @ 2024-12-27 4:40 UTC (permalink / raw)
To: Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Ling Xu, linux-arm-msm, devicetree, linux-kernel,
Krzysztof Kozlowski
On Mon, 04 Nov 2024 15:42:04 +0100, Krzysztof Kozlowski wrote:
> There is a mismatch between 'reg' property and unit address for last
> there CDSP compute context banks. Current values were taken as-is from
> downstream source. Considering that 'reg' is used by Linux driver as
> SID of context bank and that least significant bytes of IOMMU value
> match the 'reg', assume the unit-address is wrong and needs fixing.
> This also won't have any practical impact, except adhering to Devicetree
> spec.
>
> [...]
Applied, thanks!
[1/1] arm64: dts: qcom: sm8650: Fix CDSP context banks unit addresses
commit: ff2b76ae689b71e2d7a2e70bfd8d71537c39164d
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-12-27 4:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-11-04 14:42 [PATCH] arm64: dts: qcom: sm8650: Fix CDSP context banks unit addresses Krzysztof Kozlowski
2024-11-04 14:45 ` Konrad Dybcio
2024-11-04 15:04 ` neil.armstrong
2024-12-27 4:40 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®