Re: [PATCH v2 2/7] xen: introduce generic helper checking for memory map conflicts

["Jürgen Groß" <jgross@suse.com>]

[-- Attachment #1.1.1: Type: text/plain, Size: 1334 bytes --]

On 20.08.24 10:35, Jan Beulich wrote:
> On 20.08.2024 10:20, Juergen Gross wrote:
>> When booting as a Xen PV dom0 the memory layout of the dom0 is
>> modified to match that of the host, as this requires less changes in
>> the kernel for supporting Xen.
>>
>> There are some cases, though, which are problematic, as it is the Xen
>> hypervisor selecting the kernel's load address plus some other data,
>> which might conflict with the host's memory map.
>>
>> These conflicts are detected at boot time and result in a boot error.
>> In order to support handling at least some of these conflicts in
>> future, introduce a generic helper function which will later gain the
>> ability to adapt the memory layout when possible.
>>
>> Add the missing check for the xen_start_info area.
>>
>> Signed-off-by: Juergen Gross <jgross@suse.com>
>> Tested-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
> 
> Reviewed-by: Jan Beulich <jbeulich@suse.com>
> 
> However, since you mention the start_info area it may be worth adding half
> a sentence to the description also mentioning why the hypervisor allocated
> stack page doesn't need checking. In fact this may want to extend to
> initrd and phys-mach map as well, to cover everything Xen sets up on behalf
> of the kernel.

Okay.


Juergen


[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3743 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]