Re: [PATCH v2 4/7] xen: move max_pfn in xen_memory_setup() out of function scope

["Jürgen Groß" <jgross@suse.com>]

[-- Attachment #1.1.1: Type: text/plain, Size: 1278 bytes --]

On 20.08.24 10:44, Jan Beulich wrote:
> On 20.08.2024 10:20, Juergen Gross wrote:
>> Instead of having max_pfn as a local variable of xen_memory_setup(),
>> make it a static variable in setup.c instead. This avoids having to
>> pass it to subfunctions, which will be needed in more cases in future.
>>
>> Rename it to ini_nr_pages, as the value denotes the currently usable
>> number of memory pages as passed from the hypervisor at boot time.
>>
>> Signed-off-by: Juergen Gross <jgross@suse.com>
>> Tested-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
> 
> Reviewed-by: Jan Beulich <jbeulich@suse.com>
> 
> I wonder though why ...
> 
>> @@ -712,9 +713,9 @@ char * __init xen_memory_setup(void)
>>   	int op;
>>   
>>   	xen_parse_512gb();
>> -	max_pfn = xen_get_pages_limit();
>> -	max_pfn = min(max_pfn, xen_start_info->nr_pages);
>> -	mem_end = PFN_PHYS(max_pfn);
>> +	ini_nr_pages = xen_get_pages_limit();
>> +	ini_nr_pages = min(ini_nr_pages, xen_start_info->nr_pages);
> 
> ... this can't be just
> 
> 	ini_nr_pages = min(xen_get_pages_limit(), xen_start_info->nr_pages);

I just did a mechanical change for all uses of max_pfn.

I agree that your suggestion is an improvement, so I'll modify the
code.


Juergen


[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3743 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]