mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH net-next] net: pse-pd: realtek-pse-mcu: add RTL8238C device ID
@ 2026-11-15  9:40 John
  2026-11-16  9:40 ` netdev-bot+sashiko
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: John @ 2026-11-15  9:40 UTC (permalink / raw)
  To: Jonas Jelonek, Jonas Jelonek
  Cc: leksij Rempel, Kory Maincent, Andrew Lunn, David S. Miller,
	Eric Dumazet, Jakub Kicinski, Paolo Abeni, netdev, linux-kernel

From: John Audia <therealgraysky@proton.me>

Some Ubiquiti USW Pro Max 16 PoE units (boardrevision 3) carry a PSE
MCU that reports device id 0x0238, so probe fails with "unknown PSE id
0x238". poemgr names this id RTL8238C.

The high byte of the id follows the chip revision, as with RTL8239
(0x0039) and RTL8239C (0x0139), so add RTL8238C with the same power
limits and power limit command as the RTL8238B (0x0138). Tested on such
a unit, PoE works on all ports used.

Link: https://github.com/blocktrron/poemgr/blob/17771dd7b3a74a64c14351d1cbf8e61676934cbe/rtl8239.h#L13
Signed-off-by: John Audia <therealgraysky@proton.me>
---
 drivers/net/pse-pd/realtek-pse-mcu-core.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/drivers/net/pse-pd/realtek-pse-mcu-core.c b/drivers/net/pse-pd/realtek-pse-mcu-core.c
index c70b09ca2012..9ae61184b573 100644
--- a/drivers/net/pse-pd/realtek-pse-mcu-core.c
+++ b/drivers/net/pse-pd/realtek-pse-mcu-core.c
@@ -43,6 +43,7 @@
 #include "realtek-pse-mcu.h"
 
 #define RTPSE_MCU_DEVICE_ID_RTL8238B		0x0138
+#define RTPSE_MCU_DEVICE_ID_RTL8238C		0x0238
 #define RTPSE_MCU_DEVICE_ID_RTL8239		0x0039
 #define RTPSE_MCU_DEVICE_ID_RTL8239C		0x0139
 #define RTPSE_MCU_DEVICE_ID_BCM59111		0xe111
@@ -159,6 +160,14 @@ static const struct rtpse_mcu_chip_info rtl8238b_info = {
 	.pw_set_lsb_mW = 200,
 };
 
+static const struct rtpse_mcu_chip_info rtl8238c_info = {
+	.max_mW_per_port = 30000,
+	.name = "RTL8238C",
+	.pw_read_lsb_mW = 200,
+	.pw_set_cmd = RTPSE_MCU_CMD_PORT_SET_POWER_LIMIT,
+	.pw_set_lsb_mW = 200,
+};
+
 static const struct rtpse_mcu_chip_info rtl8239_info = {
 	.max_mW_per_port = 90000,
 	.name = "RTL8239",
@@ -746,6 +755,9 @@ static int rtpse_mcu_discover(struct rtpse_mcu_ctrl *pse, struct rtpse_mcu_info
 	case RTPSE_MCU_DEVICE_ID_RTL8238B:
 		pse->chip = &rtl8238b_info;
 		break;
+	case RTPSE_MCU_DEVICE_ID_RTL8238C:
+		pse->chip = &rtl8238c_info;
+		break;
 	case RTPSE_MCU_DEVICE_ID_RTL8239:
 		pse->chip = &rtl8239_info;
 		break;


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-11-16 12:00 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-15  9:40 [PATCH net-next] net: pse-pd: realtek-pse-mcu: add RTL8238C device ID John
2026-11-16  9:40 ` netdev-bot+sashiko
2026-11-16  9:52 ` Kory Maincent
2026-11-16 12:00 ` Jonas Jelonek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®