* [PATCH 02/87] ata: acard-ahci: Remove call to memset after dmam_alloc_coherent
@ 2019-06-27 17:33 Fuqian Huang
2019-06-29 15:43 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Fuqian Huang @ 2019-06-27 17:33 UTC (permalink / raw)
Cc: Fuqian Huang, Jens Axboe, linux-ide, linux-kernel
In commit af7ddd8a627c
("Merge tag 'dma-mapping-4.21' of git://git.infradead.org/users/hch/dma-mapping"),
dmam_alloc_coherent has already zeroed the memory.
So memset is not needed.
Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>
---
drivers/ata/acard-ahci.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/ata/acard-ahci.c b/drivers/ata/acard-ahci.c
index b1b49dbd0b14..85357f27a66b 100644
--- a/drivers/ata/acard-ahci.c
+++ b/drivers/ata/acard-ahci.c
@@ -344,7 +344,6 @@ static int acard_ahci_port_start(struct ata_port *ap)
mem = dmam_alloc_coherent(dev, dma_sz, &mem_dma, GFP_KERNEL);
if (!mem)
return -ENOMEM;
- memset(mem, 0, dma_sz);
/*
* First item in chunk of DMA memory: 32-slot command table,
--
2.11.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 02/87] ata: acard-ahci: Remove call to memset after dmam_alloc_coherent
2019-06-27 17:33 [PATCH 02/87] ata: acard-ahci: Remove call to memset after dmam_alloc_coherent Fuqian Huang
@ 2019-06-29 15:43 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2019-06-29 15:43 UTC (permalink / raw)
To: Fuqian Huang; +Cc: linux-ide, linux-kernel
On 6/27/19 11:33 AM, Fuqian Huang wrote:
> In commit af7ddd8a627c
> ("Merge tag 'dma-mapping-4.21' of git://git.infradead.org/users/hch/dma-mapping"),
> dmam_alloc_coherent has already zeroed the memory.
> So memset is not needed.
Applied this, and the rest of the ATA related patches, for 5.3. Thanks.
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-06-29 15:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-27 17:33 [PATCH 02/87] ata: acard-ahci: Remove call to memset after dmam_alloc_coherent Fuqian Huang
2019-06-29 15:43 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®