* [PATCH] net: 8021q: use netdev_info() instead of pr_info()
@ 2020-12-02 12:45 Enrico Weigelt, metux IT consult
2020-12-02 16:50 ` Julian Wiedmann
0 siblings, 1 reply; 2+ messages in thread
From: Enrico Weigelt, metux IT consult @ 2020-12-02 12:45 UTC (permalink / raw)
To: linux-kernel; +Cc: davem, kuba, netdev
Use netdev_info() instead of pr_info() for more consistent log output.
Signed-off-by: Enrico Weigelt <info@metux.net>
---
net/8021q/vlan.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/8021q/vlan.c b/net/8021q/vlan.c
index f292e0267bb9..d3a6f4ffdaef 100644
--- a/net/8021q/vlan.c
+++ b/net/8021q/vlan.c
@@ -132,7 +132,7 @@ int vlan_check_real_dev(struct net_device *real_dev,
const char *name = real_dev->name;
if (real_dev->features & NETIF_F_VLAN_CHALLENGED) {
- pr_info("VLANs not supported on %s\n", name);
+ netdev_info(real_dev, "VLANs not supported on %s\n", name);
NL_SET_ERR_MSG_MOD(extack, "VLANs not supported on device");
return -EOPNOTSUPP;
}
@@ -385,7 +385,7 @@ static int vlan_device_event(struct notifier_block *unused, unsigned long event,
if ((event == NETDEV_UP) &&
(dev->features & NETIF_F_HW_VLAN_CTAG_FILTER)) {
- pr_info("adding VLAN 0 to HW filter on device %s\n",
+ netdev_info(dev, "adding VLAN 0 to HW filter on device %s\n",
dev->name);
vlan_vid_add(dev, htons(ETH_P_8021Q), 0);
}
--
2.11.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] net: 8021q: use netdev_info() instead of pr_info()
2020-12-02 12:45 [PATCH] net: 8021q: use netdev_info() instead of pr_info() Enrico Weigelt, metux IT consult
@ 2020-12-02 16:50 ` Julian Wiedmann
0 siblings, 0 replies; 2+ messages in thread
From: Julian Wiedmann @ 2020-12-02 16:50 UTC (permalink / raw)
To: Enrico Weigelt, metux IT consult, linux-kernel; +Cc: davem, kuba, netdev
On 02.12.20 14:45, Enrico Weigelt, metux IT consult wrote:
> Use netdev_info() instead of pr_info() for more consistent log output.
>
> Signed-off-by: Enrico Weigelt <info@metux.net>
> ---
> net/8021q/vlan.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/net/8021q/vlan.c b/net/8021q/vlan.c
> index f292e0267bb9..d3a6f4ffdaef 100644
> --- a/net/8021q/vlan.c
> +++ b/net/8021q/vlan.c
> @@ -132,7 +132,7 @@ int vlan_check_real_dev(struct net_device *real_dev,
> const char *name = real_dev->name;
>
> if (real_dev->features & NETIF_F_VLAN_CHALLENGED) {
> - pr_info("VLANs not supported on %s\n", name);
> + netdev_info(real_dev, "VLANs not supported on %s\n", name);
Could you please also remove the real_dev->name string here?
netdev_info() should insert it automatically. Same below.
> NL_SET_ERR_MSG_MOD(extack, "VLANs not supported on device");
> return -EOPNOTSUPP;
> }
> @@ -385,7 +385,7 @@ static int vlan_device_event(struct notifier_block *unused, unsigned long event,
>
> if ((event == NETDEV_UP) &&
> (dev->features & NETIF_F_HW_VLAN_CTAG_FILTER)) {
> - pr_info("adding VLAN 0 to HW filter on device %s\n",
> + netdev_info(dev, "adding VLAN 0 to HW filter on device %s\n",
> dev->name);
> vlan_vid_add(dev, htons(ETH_P_8021Q), 0);
> }
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-12-02 16:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-02 12:45 [PATCH] net: 8021q: use netdev_info() instead of pr_info() Enrico Weigelt, metux IT consult
2020-12-02 16:50 ` Julian Wiedmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®