* [PATCH] KVM: arm64: Remove unreachable break after return
@ 2025-09-30 13:56 Osama Abdelkader
2025-09-30 17:58 ` Zenghui Yu
2025-10-01 8:55 ` Marc Zyngier
0 siblings, 2 replies; 3+ messages in thread
From: Osama Abdelkader @ 2025-09-30 13:56 UTC (permalink / raw)
To: maz, oliver.upton, joey.gouly, suzuki.poulose, yuzenghui,
catalin.marinas, will
Cc: linux-arm-kernel, kvmarm, linux-kernel, Osama Abdelkader
Remove an unnecessary 'break' statement that follows a 'return'
in arch/arm64/kvm/at.c. The break is unreachable.
Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>
---
arch/arm64/kvm/at.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/kvm/at.c b/arch/arm64/kvm/at.c
index d71ca4ddc9d1..b04c00f95944 100644
--- a/arch/arm64/kvm/at.c
+++ b/arch/arm64/kvm/at.c
@@ -43,7 +43,6 @@ static enum trans_regime compute_translation_regime(struct kvm_vcpu *vcpu, u32 o
case OP_AT_S1E2W:
case OP_AT_S1E2A:
return vcpu_el2_e2h_is_set(vcpu) ? TR_EL20 : TR_EL2;
- break;
default:
return (vcpu_el2_e2h_is_set(vcpu) &&
vcpu_el2_tge_is_set(vcpu)) ? TR_EL20 : TR_EL10;
--
2.43.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] KVM: arm64: Remove unreachable break after return
2025-09-30 13:56 [PATCH] KVM: arm64: Remove unreachable break after return Osama Abdelkader
@ 2025-09-30 17:58 ` Zenghui Yu
2025-10-01 8:55 ` Marc Zyngier
1 sibling, 0 replies; 3+ messages in thread
From: Zenghui Yu @ 2025-09-30 17:58 UTC (permalink / raw)
To: Osama Abdelkader
Cc: maz, oliver.upton, joey.gouly, suzuki.poulose, catalin.marinas,
will, linux-arm-kernel, kvmarm, linux-kernel
On 2025/9/30 21:56, Osama Abdelkader wrote:
> Remove an unnecessary 'break' statement that follows a 'return'
> in arch/arm64/kvm/at.c. The break is unreachable.
>
> Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>
> ---
> arch/arm64/kvm/at.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/kvm/at.c b/arch/arm64/kvm/at.c
> index d71ca4ddc9d1..b04c00f95944 100644
> --- a/arch/arm64/kvm/at.c
> +++ b/arch/arm64/kvm/at.c
> @@ -43,7 +43,6 @@ static enum trans_regime compute_translation_regime(struct kvm_vcpu *vcpu, u32 o
> case OP_AT_S1E2W:
> case OP_AT_S1E2A:
> return vcpu_el2_e2h_is_set(vcpu) ? TR_EL20 : TR_EL2;
> - break;
> default:
> return (vcpu_el2_e2h_is_set(vcpu) &&
> vcpu_el2_tge_is_set(vcpu)) ? TR_EL20 : TR_EL10;
Reviewed-by: Zenghui Yu <yuzenghui@huawei.com>
Thanks,
Zenghui
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] KVM: arm64: Remove unreachable break after return
2025-09-30 13:56 [PATCH] KVM: arm64: Remove unreachable break after return Osama Abdelkader
2025-09-30 17:58 ` Zenghui Yu
@ 2025-10-01 8:55 ` Marc Zyngier
1 sibling, 0 replies; 3+ messages in thread
From: Marc Zyngier @ 2025-10-01 8:55 UTC (permalink / raw)
To: oliver.upton, joey.gouly, suzuki.poulose, yuzenghui,
catalin.marinas, will, Osama Abdelkader
Cc: linux-arm-kernel, kvmarm, linux-kernel
On Tue, 30 Sep 2025 16:56:21 +0300, Osama Abdelkader wrote:
> Remove an unnecessary 'break' statement that follows a 'return'
> in arch/arm64/kvm/at.c. The break is unreachable.
>
>
Applied to fixes, thanks!
[1/1] KVM: arm64: Remove unreachable break after return
commit: 55eeaa24c9ac3a22f9c220500e23ee8b6ddff751
Cheers,
M.
--
Without deviation from the norm, progress is not possible.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-10-01 8:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-09-30 13:56 [PATCH] KVM: arm64: Remove unreachable break after return Osama Abdelkader
2025-09-30 17:58 ` Zenghui Yu
2025-10-01 8:55 ` Marc Zyngier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®