* [PATCH v3] arm64: dts: qcom: hamoa-iot-evk: enable pwm rg leds
@ 2025-11-14 8:13 Tingguo Cheng
2025-11-14 11:09 ` Dmitry Baryshkov
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Tingguo Cheng @ 2025-11-14 8:13 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: Tingguo Cheng, kernel, linux-arm-msm, devicetree, linux-kernel,
Kamal Wadhwa, Rakesh Kota, Fenglin Wu
From: Tingguo Cheng <tingguo.cheng@oss.qualcomm.com>
Add RED and GREEN LED channels for the RGB device connected to PMC8380C
PWM-LED pins. Omit BLUE channel to match default hardware setup where
it's tied to EDL indicator.
Signed-off-by: Tingguo Cheng <tingguo.cheng@oss.qualcomm.com>
---
Changes in v3:
- Rebased on next-20251113.
- Validated the function based on the patch "[PATCH] leds: rgb: leds-qcom-lpg: Allow LED_COLOR_ID_MULTI".
- Link to v2: https://lore.kernel.org/r/20251030-add-rgb-led-for-hamoa-iot-evk-v2-1-3b3326784d7b@oss.qualcomm.com
Changes in v2:
- Rebased on next-20251030.
- Remove BLUE led channel to align with the default hardware configuration.
- Link to v1: https://lore.kernel.org/r/20251017-add-rgb-led-for-hamoa-iot-evk-v1-1-6df8c109da57@oss.qualcomm.com
---
arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts | 23 +++++++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts b/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts
index 36dd6599402b4650b7f8ad2c0cd22212116a25fe..e0d427b7a207c097a19f454ec3d7d6c3edc8f79f 100644
--- a/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts
+++ b/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts
@@ -5,6 +5,7 @@
/dts-v1/;
+#include <dt-bindings/leds/common.h>
#include "hamoa-iot-som.dtsi"
/ {
@@ -879,6 +880,28 @@ usb0_1p8_reg_en: usb0-1p8-reg-en-state {
};
};
+&pm8550_pwm {
+ status = "okay";
+
+ multi-led {
+ color = <LED_COLOR_ID_MULTI>;
+ function = LED_FUNCTION_STATUS;
+
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ led@1 {
+ reg = <1>;
+ color = <LED_COLOR_ID_RED>;
+ };
+
+ led@2 {
+ reg = <2>;
+ color = <LED_COLOR_ID_GREEN>;
+ };
+ };
+};
+
&pmc8380_5_gpios {
usb0_pwr_1p15_reg_en: usb0-pwr-1p15-reg-en-state {
pins = "gpio8";
---
base-commit: ce649144bbb174abb260a3f9d77f480d8d56e813
change-id: 20251017-add-rgb-led-for-hamoa-iot-evk-43ed6bda73a5
Best regards,
--
Tingguo Cheng <tingguo.cheng@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v3] arm64: dts: qcom: hamoa-iot-evk: enable pwm rg leds
2025-11-14 8:13 [PATCH v3] arm64: dts: qcom: hamoa-iot-evk: enable pwm rg leds Tingguo Cheng
@ 2025-11-14 11:09 ` Dmitry Baryshkov
2025-11-17 13:50 ` Konrad Dybcio
2026-01-05 14:07 ` Bjorn Andersson
2 siblings, 0 replies; 4+ messages in thread
From: Dmitry Baryshkov @ 2025-11-14 11:09 UTC (permalink / raw)
To: Tingguo Cheng
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Tingguo Cheng, kernel, linux-arm-msm, devicetree,
linux-kernel, Kamal Wadhwa, Rakesh Kota, Fenglin Wu
On Fri, Nov 14, 2025 at 12:13:03AM -0800, Tingguo Cheng wrote:
> From: Tingguo Cheng <tingguo.cheng@oss.qualcomm.com>
>
> Add RED and GREEN LED channels for the RGB device connected to PMC8380C
> PWM-LED pins. Omit BLUE channel to match default hardware setup where
> it's tied to EDL indicator.
>
> Signed-off-by: Tingguo Cheng <tingguo.cheng@oss.qualcomm.com>
> ---
> Changes in v3:
> - Rebased on next-20251113.
> - Validated the function based on the patch "[PATCH] leds: rgb: leds-qcom-lpg: Allow LED_COLOR_ID_MULTI".
> - Link to v2: https://lore.kernel.org/r/20251030-add-rgb-led-for-hamoa-iot-evk-v2-1-3b3326784d7b@oss.qualcomm.com
>
> Changes in v2:
> - Rebased on next-20251030.
> - Remove BLUE led channel to align with the default hardware configuration.
> - Link to v1: https://lore.kernel.org/r/20251017-add-rgb-led-for-hamoa-iot-evk-v1-1-6df8c109da57@oss.qualcomm.com
> ---
> arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts | 23 +++++++++++++++++++++++
> 1 file changed, 23 insertions(+)
>
Commit subject: PWM, RG, LEDs.
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v3] arm64: dts: qcom: hamoa-iot-evk: enable pwm rg leds
2025-11-14 8:13 [PATCH v3] arm64: dts: qcom: hamoa-iot-evk: enable pwm rg leds Tingguo Cheng
2025-11-14 11:09 ` Dmitry Baryshkov
@ 2025-11-17 13:50 ` Konrad Dybcio
2026-01-05 14:07 ` Bjorn Andersson
2 siblings, 0 replies; 4+ messages in thread
From: Konrad Dybcio @ 2025-11-17 13:50 UTC (permalink / raw)
To: Tingguo Cheng, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: Tingguo Cheng, kernel, linux-arm-msm, devicetree, linux-kernel,
Kamal Wadhwa, Rakesh Kota, Fenglin Wu
On 11/14/25 9:13 AM, 'Tingguo Cheng' via kernel wrote:
> From: Tingguo Cheng <tingguo.cheng@oss.qualcomm.com>
>
> Add RED and GREEN LED channels for the RGB device connected to PMC8380C
> PWM-LED pins. Omit BLUE channel to match default hardware setup where
> it's tied to EDL indicator.
>
> Signed-off-by: Tingguo Cheng <tingguo.cheng@oss.qualcomm.com>
> ---
> Changes in v3:
> - Rebased on next-20251113.
> - Validated the function based on the patch "[PATCH] leds: rgb: leds-qcom-lpg: Allow LED_COLOR_ID_MULTI".
I sent the patch now, thanks
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v3] arm64: dts: qcom: hamoa-iot-evk: enable pwm rg leds
2025-11-14 8:13 [PATCH v3] arm64: dts: qcom: hamoa-iot-evk: enable pwm rg leds Tingguo Cheng
2025-11-14 11:09 ` Dmitry Baryshkov
2025-11-17 13:50 ` Konrad Dybcio
@ 2026-01-05 14:07 ` Bjorn Andersson
2 siblings, 0 replies; 4+ messages in thread
From: Bjorn Andersson @ 2026-01-05 14:07 UTC (permalink / raw)
To: Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Tingguo Cheng
Cc: Tingguo Cheng, kernel, linux-arm-msm, devicetree, linux-kernel,
Kamal Wadhwa, Rakesh Kota, Fenglin Wu
On Fri, 14 Nov 2025 00:13:03 -0800, Tingguo Cheng wrote:
> Add RED and GREEN LED channels for the RGB device connected to PMC8380C
> PWM-LED pins. Omit BLUE channel to match default hardware setup where
> it's tied to EDL indicator.
>
>
Applied, thanks!
[1/1] arm64: dts: qcom: hamoa-iot-evk: enable pwm rg leds
commit: e50c63e89236beb249507f986c3458b2b670cfd6
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-01-05 14:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-11-14 8:13 [PATCH v3] arm64: dts: qcom: hamoa-iot-evk: enable pwm rg leds Tingguo Cheng
2025-11-14 11:09 ` Dmitry Baryshkov
2025-11-17 13:50 ` Konrad Dybcio
2026-01-05 14:07 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®