From: Krzysztof Kozlowski <krzk@kernel.org>
To: Roy Luo <royluo@google.com>
Cc: "Vinod Koul" <vkoul@kernel.org>,
"Kishon Vijay Abraham I" <kishon@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
"Peter Griffin" <peter.griffin@linaro.org>,
"André Draszik" <andre.draszik@linaro.org>,
"Tudor Ambarus" <tudor.ambarus@linaro.org>,
"Joy Chakraborty" <joychakr@google.com>,
"Naveen Kumar" <mnkumar@google.com>,
"Badhri Jagan Sridharan" <badhri@google.com>,
linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH v4 1/2] dt-bindings: phy: google: Add Google Tensor G5 USB PHY
Date: Mon, 27 Oct 2025 15:02:48 +0100 [thread overview]
Message-ID: <8e4c8875-10bc-4f4c-a675-a7cefc68c863@kernel.org> (raw)
In-Reply-To: <CA+zupgwQTLEs8_7i-VsGbGV7O2Y3XFA1C3aV7iuv2HLOwKns3w@mail.gmail.com>
On 24/10/2025 00:22, Roy Luo wrote:
>>> +
>>> + clocks:
>>> + items:
>>> + - description: USB2 PHY clock.
>>> + - description: USB2 PHY APB clock.
>>> +
>>> + clock-names:
>>> + items:
>>> + - const: usb2_phy
>>
>> core
>>
>>> + - const: u2phy_apb
>>
>> apb
>>
>
> Just to provide the full context, these two clocks/resets
> (usb2_phy and u2phy_apb) are specifically for eUSB2 PHY.
> USB3/DP combo PHY has its own clock/reset that hasn't
> been added yet, we would have to differentiate them once
That's confusing a bit. You must add all clocks, all resets, all power
domains, all pins etc. Bindings are supposed to be complete, see writing
bindings doc.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-10-27 14:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-17 23:51 [PATCH v4 0/2] Add Google Tensor SoC USB PHY support Roy Luo
2025-10-17 23:51 ` [PATCH v4 1/2] dt-bindings: phy: google: Add Google Tensor G5 USB PHY Roy Luo
2025-10-23 6:43 ` Krzysztof Kozlowski
2025-10-23 6:57 ` Krzysztof Kozlowski
2025-10-23 21:54 ` Roy Luo
2025-10-23 22:22 ` Roy Luo
2025-10-27 14:02 ` Krzysztof Kozlowski [this message]
2025-10-27 23:21 ` Roy Luo
2025-10-17 23:51 ` [PATCH v4 2/2] phy: Add Google Tensor SoC USB PHY driver Roy Luo
2025-10-18 8:13 ` Ivaylo Ivanov
2025-10-20 19:55 ` Roy Luo
2025-10-29 21:56 ` Roy Luo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e4c8875-10bc-4f4c-a675-a7cefc68c863@kernel.org \
--to=krzk@kernel.org \
--cc=andre.draszik@linaro.org \
--cc=badhri@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=joychakr@google.com \
--cc=kishon@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mnkumar@google.com \
--cc=p.zabel@pengutronix.de \
--cc=peter.griffin@linaro.org \
--cc=robh@kernel.org \
--cc=royluo@google.com \
--cc=tudor.ambarus@linaro.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®