mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* Re: [PATCH] ASoC: qcom: Fix NULL Dereference in asoc_qcom_lpass_cpu_platform_probe()
       [not found] <20241003152739.9650-1-zichenxie0106@gmail.com>
@ 2024-10-05 15:40 ` Markus Elfring
  2024-10-06  8:29   ` Greg Kroah-Hartman
  0 siblings, 1 reply; 6+ messages in thread
From: Markus Elfring @ 2024-10-05 15:40 UTC (permalink / raw)
  To: Zichen Xie, alsa-devel, linux-sound, linux-arm-msm,
	Greg Kroah-Hartman, Jaroslav Kysela, Liam Girdwood, Mark Brown,
	Rohit kumar, Srinivas Kandagatla, Takashi Iwai
  Cc: stable, LKML, Chenyuan Yang, Zijie Zhao

> A devm_kzalloc() in asoc_qcom_lpass_cpu_platform_probe() could

                   call?


> possibly return NULL pointer. NULL Pointer Dereference may be
> triggerred without addtional check.
…

* How do you think about to use the term “null pointer dereference”
  for the final commit message (including the summary phrase)?

* Would you like to avoid any typos here?


…
> ---
>  sound/soc/qcom/lpass-cpu.c | 2 ++

Did you overlook to add a version description behind the marker line?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.12-rc1#n723

Regards,
Markus

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] ASoC: qcom: Fix NULL Dereference in asoc_qcom_lpass_cpu_platform_probe()
  2024-10-05 15:40 ` [PATCH] ASoC: qcom: Fix NULL Dereference in asoc_qcom_lpass_cpu_platform_probe() Markus Elfring
@ 2024-10-06  8:29   ` Greg Kroah-Hartman
  2024-10-06  8:56     ` Markus Elfring
  0 siblings, 1 reply; 6+ messages in thread
From: Greg Kroah-Hartman @ 2024-10-06  8:29 UTC (permalink / raw)
  To: Markus Elfring
  Cc: Zichen Xie, alsa-devel, linux-sound, linux-arm-msm,
	Jaroslav Kysela, Liam Girdwood, Mark Brown, Rohit kumar,
	Srinivas Kandagatla, Takashi Iwai, stable, LKML, Chenyuan Yang,
	Zijie Zhao

On Sat, Oct 05, 2024 at 05:40:53PM +0200, Markus Elfring wrote:
> > A devm_kzalloc() in asoc_qcom_lpass_cpu_platform_probe() could
> 
>                    call?
> 
> 
> > possibly return NULL pointer. NULL Pointer Dereference may be
> > triggerred without addtional check.
> …
> 
> * How do you think about to use the term “null pointer dereference”
>   for the final commit message (including the summary phrase)?
> 
> * Would you like to avoid any typos here?
> 
> 
> …
> > ---
> >  sound/soc/qcom/lpass-cpu.c | 2 ++
> 
> Did you overlook to add a version description behind the marker line?
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.12-rc1#n723
> 
> Regards,
> Markus

Hi,

This is the semi-friendly patch-bot of Greg Kroah-Hartman.

Markus, you seem to have sent a nonsensical or otherwise pointless
review comment to a patch submission on a Linux kernel developer mailing
list.  I strongly suggest that you not do this anymore.  Please do not
bother developers who are actively working to produce patches and
features with comments that, in the end, are a waste of time.

Patch submitter, please ignore Markus's suggestion; you do not need to
follow it at all.  The person/bot/AI that sent it is being ignored by
almost all Linux kernel maintainers for having a persistent pattern of
behavior of producing distracting and pointless commentary, and
inability to adapt to feedback.  Please feel free to also ignore emails
from them.

thanks,

greg k-h's patch email bot

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] ASoC: qcom: Fix NULL Dereference in asoc_qcom_lpass_cpu_platform_probe()
  2024-10-06  8:29   ` Greg Kroah-Hartman
@ 2024-10-06  8:56     ` Markus Elfring
  2024-10-06 10:08       ` Greg Kroah-Hartman
  0 siblings, 1 reply; 6+ messages in thread
From: Markus Elfring @ 2024-10-06  8:56 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Zichen Xie, alsa-devel, linux-sound, linux-arm-msm
  Cc: Jaroslav Kysela, Liam Girdwood, Mark Brown, Rohit kumar,
	Srinivas Kandagatla, Takashi Iwai, stable, LKML, Chenyuan Yang,
	Zijie Zhao

>>> A devm_kzalloc() in asoc_qcom_lpass_cpu_platform_probe() could
>>
>>                    call?
>>
>>
>>> possibly return NULL pointer. NULL Pointer Dereference may be
>>> triggerred without addtional check.
>> …
>>
>> * How do you think about to use the term “null pointer dereference”
>>   for the final commit message (including the summary phrase)?
>>
>> * Would you like to avoid any typos here?
>>
>>
>> …
>>> ---
>>>  sound/soc/qcom/lpass-cpu.c | 2 ++
>>
>> Did you overlook to add a version description behind the marker line?
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.12-rc1#n723
…
> This is the semi-friendly patch-bot of Greg Kroah-Hartman.
>
> Markus, you seem to have sent a nonsensical or otherwise pointless
> review comment to a patch submission on a Linux kernel developer mailing
> list.  I strongly suggest that you not do this anymore.  Please do not
> bother developers who are actively working to produce patches and
> features with comments that, in the end, are a waste of time.
>
> Patch submitter, please ignore Markus's suggestion; you do not need to
> follow it at all.  The person/bot/AI that sent it is being ignored by
> almost all Linux kernel maintainers for having a persistent pattern of
> behavior of producing distracting and pointless commentary, and
> inability to adapt to feedback.  Please feel free to also ignore emails
> from them.
* Do you care for any spell checking?

* Do you find any related advice (from other automated responses) helpful?


Regards,
Markus

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] ASoC: qcom: Fix NULL Dereference in asoc_qcom_lpass_cpu_platform_probe()
  2024-10-06  8:56     ` Markus Elfring
@ 2024-10-06 10:08       ` Greg Kroah-Hartman
  2024-10-06 11:12         ` Markus Elfring
  0 siblings, 1 reply; 6+ messages in thread
From: Greg Kroah-Hartman @ 2024-10-06 10:08 UTC (permalink / raw)
  To: Markus Elfring
  Cc: Zichen Xie, alsa-devel, linux-sound, linux-arm-msm,
	Jaroslav Kysela, Liam Girdwood, Mark Brown, Rohit kumar,
	Srinivas Kandagatla, Takashi Iwai, stable, LKML, Chenyuan Yang,
	Zijie Zhao

On Sun, Oct 06, 2024 at 10:56:51AM +0200, Markus Elfring wrote:
> >>> A devm_kzalloc() in asoc_qcom_lpass_cpu_platform_probe() could
> >>
> >>                    call?
> >>
> >>
> >>> possibly return NULL pointer. NULL Pointer Dereference may be
> >>> triggerred without addtional check.
> >> …
> >>
> >> * How do you think about to use the term “null pointer dereference”
> >>   for the final commit message (including the summary phrase)?
> >>
> >> * Would you like to avoid any typos here?
> >>
> >>
> >> …
> >>> ---
> >>>  sound/soc/qcom/lpass-cpu.c | 2 ++
> >>
> >> Did you overlook to add a version description behind the marker line?
> >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.12-rc1#n723
> …
> > This is the semi-friendly patch-bot of Greg Kroah-Hartman.
> >
> > Markus, you seem to have sent a nonsensical or otherwise pointless
> > review comment to a patch submission on a Linux kernel developer mailing
> > list.  I strongly suggest that you not do this anymore.  Please do not
> > bother developers who are actively working to produce patches and
> > features with comments that, in the end, are a waste of time.
> >
> > Patch submitter, please ignore Markus's suggestion; you do not need to
> > follow it at all.  The person/bot/AI that sent it is being ignored by
> > almost all Linux kernel maintainers for having a persistent pattern of
> > behavior of producing distracting and pointless commentary, and
> > inability to adapt to feedback.  Please feel free to also ignore emails
> > from them.
> * Do you care for any spell checking?

No.

> * Do you find any related advice (from other automated responses) helpful?

No.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: ASoC: qcom: Fix NULL Dereference in asoc_qcom_lpass_cpu_platform_probe()
  2024-10-06 10:08       ` Greg Kroah-Hartman
@ 2024-10-06 11:12         ` Markus Elfring
  2024-10-07 12:20           ` Markus Elfring
  0 siblings, 1 reply; 6+ messages in thread
From: Markus Elfring @ 2024-10-06 11:12 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Zichen Xie, alsa-devel, linux-sound, linux-arm-msm
  Cc: Jaroslav Kysela, Liam Girdwood, Mark Brown, Rohit kumar,
	Srinivas Kandagatla, Takashi Iwai, stable, LKML, Chenyuan Yang,
	Zijie Zhao

>>>>> A devm_kzalloc() in asoc_qcom_lpass_cpu_platform_probe() could
>>>>
>>>>                    call?
>>>>
>>>>
>>>>> possibly return NULL pointer. NULL Pointer Dereference may be
>>>>> triggerred without addtional check.
>>>> …
>>>>
>>>> * How do you think about to use the term “null pointer dereference”
>>>>   for the final commit message (including the summary phrase)?
>>>>
>>>> * Would you like to avoid any typos here?
>>>>
>>>>
>>>> …
>>>>> ---
>>>>>  sound/soc/qcom/lpass-cpu.c | 2 ++
>>>>
>>>> Did you overlook to add a version description behind the marker line?
>>>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.12-rc1#n723
>> …
>>> This is the semi-friendly patch-bot of Greg Kroah-Hartman.
…
>> * Do you care for any spell checking?
>
> No.

I find such a feedback surprising.
Does it indicate any recurring communication difficulties?


>> * Do you find any related advice (from other automated responses) helpful?
>
> No.

I wonder how this answer fits to reminders for the Linux patch review process
(which were also automatically sent) according to your inbox filter rules.

Regards,
Markus

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: ASoC: qcom: Fix NULL Dereference in asoc_qcom_lpass_cpu_platform_probe()
  2024-10-06 11:12         ` Markus Elfring
@ 2024-10-07 12:20           ` Markus Elfring
  0 siblings, 0 replies; 6+ messages in thread
From: Markus Elfring @ 2024-10-07 12:20 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Zichen Xie, alsa-devel, linux-sound, linux-arm-msm
  Cc: Jaroslav Kysela, Liam Girdwood, Mark Brown, Rohit kumar,
	Srinivas Kandagatla, Takashi Iwai, stable, LKML, Chenyuan Yang,
	Zijie Zhao

>>> * Do you find any related advice (from other automated responses) helpful?
>>
>> No.
>
> I wonder how this answer fits to reminders for the Linux patch review process
> (which were also automatically sent) according to your inbox filter rules.

See also:
https://lore.kernel.org/all/?q=%22This+looks+like+a+new+version+of+a+previously+submitted+patch%22

Regards,
Markus

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2024-10-07 12:20 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20241003152739.9650-1-zichenxie0106@gmail.com>
2024-10-05 15:40 ` [PATCH] ASoC: qcom: Fix NULL Dereference in asoc_qcom_lpass_cpu_platform_probe() Markus Elfring
2024-10-06  8:29   ` Greg Kroah-Hartman
2024-10-06  8:56     ` Markus Elfring
2024-10-06 10:08       ` Greg Kroah-Hartman
2024-10-06 11:12         ` Markus Elfring
2024-10-07 12:20           ` Markus Elfring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®