Re: [PATCH v2 3/3] net: stmmac: dwmac-nuvoton: Add dwmac support for MA35 family

[Joey Lu <a0987203069@gmail.com>]

Dear Andrew,

Thank you for your reply.

On 11/14/24 10:56, Andrew Lunn wrote:
>> +	if (of_property_read_u32(dev->of_node, "tx-internal-delay-ps", &arg)) {
>> +		tx_delay = 0; /* Default value is 0 */
>> +	} else {
>> +		if (arg > 0 && arg <= 2000) {
>> +			tx_delay = (arg == 2000) ? 0xF : (arg / PATHDLY_DEC);
>> +			dev_dbg(dev, "Set Tx path delay to 0x%x\n", tx_delay);
>> +		} else {
>> +			tx_delay = 0;
>> +			dev_err(dev, "Invalid Tx path delay argument. Setting to default.\n");
>> +		}
>> +	}
> The device tree binding says that only [0, 2000] are valid. You should
> enforce this here, return -EINVAL of any other value.
>
> 	Andrew

This will be fixed in the next version. And I will correct error messages.

Thanks!

BR,

Joey