From: Paolo Bonzini <pbonzini@redhat.com>
To: Sean Christopherson <sean.j.christopherson@intel.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
"Nikita Leshchenko" <nikita.leshchenko@oracle.com>,
"Liran Alon" <liran.alon@oracle.com>,
"Radim Krčmář" <rkrcmar@redhat.com>
Subject: Re: [PATCH] kvm: nVMX: fix entry with pending interrupt if APICv is enabled
Date: Wed, 3 Oct 2018 16:54:46 +0200 [thread overview]
Message-ID: <8e6e1929-5b09-0a6f-60ea-993f758ab2fe@redhat.com> (raw)
In-Reply-To: <20181003145324.GA23518@linux.intel.com>
On 03/10/2018 16:53, Sean Christopherson wrote:
> Isn't enable_apicv redundant with kvm_vcpu_apicv_active()? And since
> getting RVI requires a VMREAD, I think it would make sense to only
> fall into this code if !evaluate_pending_interrupts, e.g.:
>
> if (!evaluate_pending_interrupts && kvm_vcpu_apicv_active(vcpu))
> evaluate_pending_interrupts |= vmx_get_rvi() > 0;
Yes, both suggestions make sense. I'll make it
likely(!evaluate_pending_interrupts).
Thanks to both you and Nikita for the quick review!
Paolo
prev parent reply other threads:[~2018-10-03 14:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-03 11:47 Paolo Bonzini
2018-10-03 14:36 ` Nikita Leshenko
2018-10-03 14:41 ` Paolo Bonzini
2018-10-03 14:51 ` Paolo Bonzini
2018-10-03 14:53 ` Sean Christopherson
2018-10-03 14:54 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e6e1929-5b09-0a6f-60ea-993f758ab2fe@redhat.com \
--to=pbonzini@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liran.alon@oracle.com \
--cc=nikita.leshchenko@oracle.com \
--cc=rkrcmar@redhat.com \
--cc=sean.j.christopherson@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®