* [PATCH] drm/mgag200: Fix a warning reported by Fi.CI.SPARSE
@ 2023-06-21 19:11 Sui Jingfeng
2023-06-22 12:35 ` Jocelyn Falempe
0 siblings, 1 reply; 3+ messages in thread
From: Sui Jingfeng @ 2023-06-21 19:11 UTC (permalink / raw)
To: Dave Airlie, Thomas Zimmermann, David Airlie, Daniel Vetter
Cc: dri-devel, linux-kernel
drivers/gpu/drm/mgag200/mgag200_drv.c:23:5: warning: symbol 'mgag200_modeset' was not declared. Should it be static?
Found in the log of Fi.CI.SPARSE test [1]
[1] https://patchwork.freedesktop.org/series/119249/
Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn>
---
drivers/gpu/drm/mgag200/mgag200_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/mgag200/mgag200_drv.c b/drivers/gpu/drm/mgag200/mgag200_drv.c
index 976f0ab2006b..abddf37f0ea1 100644
--- a/drivers/gpu/drm/mgag200/mgag200_drv.c
+++ b/drivers/gpu/drm/mgag200/mgag200_drv.c
@@ -20,7 +20,7 @@
#include "mgag200_drv.h"
-int mgag200_modeset = -1;
+static int mgag200_modeset = -1;
MODULE_PARM_DESC(modeset, "Disable/Enable modesetting");
module_param_named(modeset, mgag200_modeset, int, 0400);
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/mgag200: Fix a warning reported by Fi.CI.SPARSE
2023-06-21 19:11 [PATCH] drm/mgag200: Fix a warning reported by Fi.CI.SPARSE Sui Jingfeng
@ 2023-06-22 12:35 ` Jocelyn Falempe
2023-06-22 13:32 ` Sui Jingfeng
0 siblings, 1 reply; 3+ messages in thread
From: Jocelyn Falempe @ 2023-06-22 12:35 UTC (permalink / raw)
To: Sui Jingfeng, Dave Airlie, Thomas Zimmermann, David Airlie,
Daniel Vetter, Tom Rix
Cc: linux-kernel, dri-devel
This patch was already sent by Tom Rix last month:
https://patchwork.freedesktop.org/series/117881/
I can push it to drm-misc-next, if Thomas is ok.
Best regards,
--
Jocelyn
On 21/06/2023 21:11, Sui Jingfeng wrote:
> drivers/gpu/drm/mgag200/mgag200_drv.c:23:5: warning: symbol 'mgag200_modeset' was not declared. Should it be static?
>
> Found in the log of Fi.CI.SPARSE test [1]
>
> [1] https://patchwork.freedesktop.org/series/119249/
>
> Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn>
> ---
> drivers/gpu/drm/mgag200/mgag200_drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/mgag200/mgag200_drv.c b/drivers/gpu/drm/mgag200/mgag200_drv.c
> index 976f0ab2006b..abddf37f0ea1 100644
> --- a/drivers/gpu/drm/mgag200/mgag200_drv.c
> +++ b/drivers/gpu/drm/mgag200/mgag200_drv.c
> @@ -20,7 +20,7 @@
>
> #include "mgag200_drv.h"
>
> -int mgag200_modeset = -1;
> +static int mgag200_modeset = -1;
> MODULE_PARM_DESC(modeset, "Disable/Enable modesetting");
> module_param_named(modeset, mgag200_modeset, int, 0400);
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/mgag200: Fix a warning reported by Fi.CI.SPARSE
2023-06-22 12:35 ` Jocelyn Falempe
@ 2023-06-22 13:32 ` Sui Jingfeng
0 siblings, 0 replies; 3+ messages in thread
From: Sui Jingfeng @ 2023-06-22 13:32 UTC (permalink / raw)
To: Jocelyn Falempe, Dave Airlie, Thomas Zimmermann, David Airlie,
Daniel Vetter, Tom Rix
Cc: linux-kernel, dri-devel
Hi,
Ah, I forgot to check that before send a patch, sorry for the noise :-)
On 2023/6/22 20:35, Jocelyn Falempe wrote:
> This patch was already sent by Tom Rix last month:
> https://patchwork.freedesktop.org/series/117881/
>
> I can push it to drm-misc-next, if Thomas is ok.
>
That sounds fine.
> Best regards,
>
--
Jingfeng
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-06-22 13:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-21 19:11 [PATCH] drm/mgag200: Fix a warning reported by Fi.CI.SPARSE Sui Jingfeng
2023-06-22 12:35 ` Jocelyn Falempe
2023-06-22 13:32 ` Sui Jingfeng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®