From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Mrinmay Sarkar <mrinmay.sarkar@oss.qualcomm.com>,
Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
krishna.chundru@oss.qualcomm.com, quic_vbadigan@quicinc.com,
quic_nayiluri@quicinc.com, quic_ramkri@quicinc.com,
quic_nitegupt@quicinc.com,
Mrinmay Sarkar <quic_msarkar@quicinc.com>
Subject: Re: [PATCH v2 1/2] phy: qcom: qmp-pcie: Update PHY settings for SA8775P
Date: Sat, 17 May 2025 20:16:28 +0200 [thread overview]
Message-ID: <8e900d20-009b-4cc7-ba1d-52582e414402@oss.qualcomm.com> (raw)
In-Reply-To: <20250514-update_phy-v2-1-d4f319221474@quicinc.com>
On 5/14/25 1:37 PM, Mrinmay Sarkar wrote:
> From: Mrinmay Sarkar <mrinmay.sarkar@oss.qualcomm.com>
>
> Make changes to update the PHY settings to align with the latest
> PCIe PHY Hardware Programming Guide for both PCIe controllers
> on the SA8775P platform.
>
> Add the ln_shrd region for SA8775P, incorporating new register
> writes as specified in the updated Hardware Programming Guide.
>
> Update pcs table for QCS8300, since both QCS8300 and SA8775P are
> closely related and share same pcs settings.
>
> Signed-off-by: Mrinmay Sarkar <mrinmay.sarkar@oss.qualcomm.com>
> ---
So I took a closer look and please re-validate the changes, I
checked one write randomly and it turned out to be inconsistent
[...]
> - QMP_PHY_INIT_CFG(QSERDES_V5_20_RX_VGA_CAL_MAN_VAL, 0x08),
> - QMP_PHY_INIT_CFG(QSERDES_V5_20_RX_RX_EQU_ADAPTOR_CNTRL4, 0x0b),
> + QMP_PHY_INIT_CFG(QSERDES_V5_20_RX_VGA_CAL_MAN_VAL, 0x03),
^ this should be 0x0a according to reference v1.19 for RC mode
Konrad
next prev parent reply other threads:[~2025-05-17 18:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-14 11:37 [PATCH v2 0/2] Update PCIe " Mrinmay Sarkar
2025-05-14 11:37 ` [PATCH v2 1/2] phy: qcom: qmp-pcie: Update " Mrinmay Sarkar
2025-05-14 16:40 ` neil.armstrong
2025-05-17 18:16 ` Konrad Dybcio [this message]
[not found] ` <CAMyL0qPmMVt1Wd4fkQsf_pt8ggJhpR=u7GbXtifczK4Xp8yRJA@mail.gmail.com>
2025-05-20 11:03 ` Konrad Dybcio
2025-05-14 11:37 ` [PATCH v2 2/2] arm64: dts: qcom: sa8775p: Remove max link speed property for PCIe EP Mrinmay Sarkar
2025-05-14 16:38 ` neil.armstrong
2025-05-16 9:00 ` Konrad Dybcio
2025-05-16 10:29 ` Mrinmay Sarkar
2025-05-16 22:03 ` Dmitry Baryshkov
2025-05-19 12:16 ` Mrinmay Sarkar
2025-05-20 7:25 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e900d20-009b-4cc7-ba1d-52582e414402@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kishon@kernel.org \
--cc=konradybcio@kernel.org \
--cc=krishna.chundru@oss.qualcomm.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=mrinmay.sarkar@oss.qualcomm.com \
--cc=quic_msarkar@quicinc.com \
--cc=quic_nayiluri@quicinc.com \
--cc=quic_nitegupt@quicinc.com \
--cc=quic_ramkri@quicinc.com \
--cc=quic_vbadigan@quicinc.com \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®