[PATCH 2/2] staging/iio: Make IIO depend on GENERIC_HARDIRQS

[PATCH 2/2] staging/iio: Make IIO depend on GENERIC_HARDIRQS

[Geert Uytterhoeven]

On m68k (which doesn't support generic hardirqs yet):

drivers/staging/iio/industrialio-trigger.c: In function ‘iio_trigger_poll’:
drivers/staging/iio/industrialio-trigger.c:180: error: implicit declaration of function ‘generic_handle_irq’
drivers/staging/iio/industrialio-trigger.c: In function ‘iio_trigger_poll_chained’:
drivers/staging/iio/industrialio-trigger.c:200: error: implicit declaration of function ‘handle_nested_irq’
drivers/staging/iio/industrialio-trigger.c: In function ‘iio_trig_release’:
drivers/staging/iio/industrialio-trigger.c:379: error: implicit declaration of function ‘irq_modify_status’
drivers/staging/iio/industrialio-trigger.c:382: error: implicit declaration of function ‘irq_set_chip’
drivers/staging/iio/industrialio-trigger.c:384: error: implicit declaration of function ‘irq_set_handler’
drivers/staging/iio/industrialio-trigger.c:388: error: implicit declaration of function ‘irq_free_descs’
drivers/staging/iio/industrialio-trigger.c: In function ‘iio_trig_subirqmask’:
drivers/staging/iio/industrialio-trigger.c:402: error: implicit declaration of function ‘irq_data_get_irq_chip’
drivers/staging/iio/industrialio-trigger.c:402: warning: initialization makes pointer from integer without a cast
drivers/staging/iio/industrialio-trigger.c: In function ‘iio_trig_subirqunmask’:
drivers/staging/iio/industrialio-trigger.c:411: warning: initialization makes pointer from integer without a cast
drivers/staging/iio/industrialio-trigger.c: In function ‘iio_allocate_trigger’:
drivers/staging/iio/industrialio-trigger.c:432: error: implicit declaration of function ‘irq_alloc_descs’
drivers/staging/iio/industrialio-trigger.c:455: error: ‘handle_simple_irq’ undeclared (first use in this function)
drivers/staging/iio/industrialio-trigger.c:455: error: (Each undeclared identifier is reported only once
drivers/staging/iio/industrialio-trigger.c:455: error: for each function it appears in.)

Hence IIO_TRIGGER should depend on GENERIC_HARDIRQS.
But as IIO_TRIGGER and IIO_RING_BUFFER form a maze of dependencies and selects,
just make the whole IIO subsystem depend on GENERIC_HARDIRQS.

This dependency also covers !S390, so that one can be removed again.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 drivers/staging/iio/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/staging/iio/Kconfig b/drivers/staging/iio/Kconfig
index f96d5b5..d329635 100644
--- a/drivers/staging/iio/Kconfig
+++ b/drivers/staging/iio/Kconfig
@@ -4,7 +4,7 @@
 
 menuconfig IIO
 	tristate "Industrial I/O support"
-	depends on !S390
+	depends on GENERIC_HARDIRQS
 	help
 	  The industrial I/O subsystem provides a unified framework for
 	  drivers for many different types of embedded sensors using a
-- 
1.7.0.4

Re: [PATCH 2/2] staging/iio: Make IIO depend on GENERIC_HARDIRQS

[jonathan.cameron@gmail.com]

Geert Uytterhoeven <geert@linux-m68k.org> wrote:

>On m68k (which doesn't support generic hardirqs yet):
>
>drivers/staging/iio/industrialio-trigger.c: In function
>‘iio_trigger_poll’:
>drivers/staging/iio/industrialio-trigger.c:180: error: implicit
>declaration of function ‘generic_handle_irq’
>drivers/staging/iio/industrialio-trigger.c: In function
>‘iio_trigger_poll_chained’:
>drivers/staging/iio/industrialio-trigger.c:200: error: implicit
>declaration of function ‘handle_nested_irq’
>drivers/staging/iio/industrialio-trigger.c: In function
>‘iio_trig_release’:
>drivers/staging/iio/industrialio-trigger.c:379: error: implicit
>declaration of function ‘irq_modify_status’
>drivers/staging/iio/industrialio-trigger.c:382: error: implicit
>declaration of function ‘irq_set_chip’
>drivers/staging/iio/industrialio-trigger.c:384: error: implicit
>declaration of function ‘irq_set_handler’
>drivers/staging/iio/industrialio-trigger.c:388: error: implicit
>declaration of function ‘irq_free_descs’
>drivers/staging/iio/industrialio-trigger.c: In function
>‘iio_trig_subirqmask’:
>drivers/staging/iio/industrialio-trigger.c:402: error: implicit
>declaration of function ‘irq_data_get_irq_chip’
>drivers/staging/iio/industrialio-trigger.c:402: warning: initialization
>makes pointer from integer without a cast
>drivers/staging/iio/industrialio-trigger.c: In function
>‘iio_trig_subirqunmask’:
>drivers/staging/iio/industrialio-trigger.c:411: warning: initialization
>makes pointer from integer without a cast
>drivers/staging/iio/industrialio-trigger.c: In function
>‘iio_allocate_trigger’:
>drivers/staging/iio/industrialio-trigger.c:432: error: implicit
>declaration of function ‘irq_alloc_descs’
>drivers/staging/iio/industrialio-trigger.c:455: error:
>‘handle_simple_irq’ undeclared (first use in this function)
>drivers/staging/iio/industrialio-trigger.c:455: error: (Each undeclared
>identifier is reported only once
>drivers/staging/iio/industrialio-trigger.c:455: error: for each
>function it appears in.)
>
>Hence IIO_TRIGGER should depend on GENERIC_HARDIRQS.
>But as IIO_TRIGGER and IIO_RING_BUFFER form a maze of dependencies and
>selects,
>just make the whole IIO subsystem depend on GENERIC_HARDIRQS.
>
>This dependency also covers !S390, so that one can be removed again.
Dratt  We talked about this and thought S390 was the only non generic hard irq left.  Should have played safe sorry!
>Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Jonathan Cameron <jic23@cam.ac.uk>
>---
> drivers/staging/iio/Kconfig |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/drivers/staging/iio/Kconfig b/drivers/staging/iio/Kconfig
>index f96d5b5..d329635 100644
>--- a/drivers/staging/iio/Kconfig
>+++ b/drivers/staging/iio/Kconfig
>@@ -4,7 +4,7 @@
> 
> menuconfig IIO
> 	tristate "Industrial I/O support"
>-	depends on !S390
>+	depends on GENERIC_HARDIRQS
> 	help
> 	  The industrial I/O subsystem provides a unified framework for
> 	  drivers for many different types of embedded sensors using a
>-- 
>1.7.0.4

-- 
Sent from my Android phone with K-9 Mail. Please excuse my brevity.

Re: [PATCH 2/2] staging/iio: Make IIO depend on GENERIC_HARDIRQS

[Geert Uytterhoeven]

On Tue, May 31, 2011 at 13:01, jonathan.cameron@gmail.com
<jic23@cam.ac.uk> wrote:
> Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>>On m68k (which doesn't support generic hardirqs yet):

[...]

>>Hence IIO_TRIGGER should depend on GENERIC_HARDIRQS.
>>But as IIO_TRIGGER and IIO_RING_BUFFER form a maze of dependencies and
>>selects,
>>just make the whole IIO subsystem depend on GENERIC_HARDIRQS.
>>
>>This dependency also covers !S390, so that one can be removed again.
> Dratt  We talked about this and thought S390 was the only non generic hard irq left.  Should have played safe sorry!

I hope s390 will be the only one soon ;-)

>>Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Acked-by: Jonathan Cameron <jic23@cam.ac.uk>

Thanks!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 2/2] staging/iio: Make IIO depend on GENERIC_HARDIRQS

[Geert Uytterhoeven]

On Tue, May 31, 2011 at 21:34, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> On Tue, May 31, 2011 at 13:01, jonathan.cameron@gmail.com
> <jic23@cam.ac.uk> wrote:
>> Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>>>On m68k (which doesn't support generic hardirqs yet):
>
> [...]
>
>>>Hence IIO_TRIGGER should depend on GENERIC_HARDIRQS.
>>>But as IIO_TRIGGER and IIO_RING_BUFFER form a maze of dependencies and
>>>selects,
>>>just make the whole IIO subsystem depend on GENERIC_HARDIRQS.
>>>
>>>This dependency also covers !S390, so that one can be removed again.
>> Dratt  We talked about this and thought S390 was the only non generic hard irq left.  Should have played safe sorry!
>
> I hope s390 will be the only one soon ;-)
>
>>>Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
>> Acked-by: Jonathan Cameron <jic23@cam.ac.uk>
>
> Thanks!

Ping? Still broken in -next (and linus, FWIM).

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds