mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v2 1/2] arm64: dts: imx8-ss-img: Assign slot for imx jpeg encoder/decoder
@ 2023-09-21  6:36 Ming Qian
  2023-09-21  6:36 ` [PATCH v2 2/2] dt-bindings: media: imx-jpeg: " Ming Qian
  2023-09-21  9:56 ` [PATCH v2 1/2] arm64: dts: imx8-ss-img: " Krzysztof Kozlowski
  0 siblings, 2 replies; 6+ messages in thread
From: Ming Qian @ 2023-09-21  6:36 UTC (permalink / raw)
  To: mirela.rabulea, robh+dt, shawnguo
  Cc: mchehab, hverkuil-cisco, s.hauer, kernel, festevam, xiahong.bao,
	eagle.zhou, tao.jiang_2, linux-imx, linux-media, linux-kernel,
	linux-arm-kernel

assign a single slot,
configure interrupt and power domain only for 1 slot,
not for the all 4 slots.

Signed-off-by: Ming Qian <ming.qian@nxp.com>
---
 .../arm64/boot/dts/freescale/imx8-ss-img.dtsi | 22 +++++--------------
 1 file changed, 6 insertions(+), 16 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8-ss-img.dtsi b/arch/arm64/boot/dts/freescale/imx8-ss-img.dtsi
index a90654155a88..176dcce24b64 100644
--- a/arch/arm64/boot/dts/freescale/imx8-ss-img.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8-ss-img.dtsi
@@ -18,10 +18,7 @@ img_ipg_clk: clock-img-ipg {
 
 	jpegdec: jpegdec@58400000 {
 		reg = <0x58400000 0x00050000>;
-		interrupts = <GIC_SPI 309 IRQ_TYPE_LEVEL_HIGH>,
-			     <GIC_SPI 310 IRQ_TYPE_LEVEL_HIGH>,
-			     <GIC_SPI 311 IRQ_TYPE_LEVEL_HIGH>,
-			     <GIC_SPI 312 IRQ_TYPE_LEVEL_HIGH>;
+		interrupts = <GIC_SPI 309 IRQ_TYPE_LEVEL_HIGH>;
 		clocks = <&img_jpeg_dec_lpcg IMX_LPCG_CLK_0>,
 			 <&img_jpeg_dec_lpcg IMX_LPCG_CLK_4>;
 		clock-names = "per", "ipg";
@@ -29,18 +26,13 @@ jpegdec: jpegdec@58400000 {
 				  <&img_jpeg_dec_lpcg IMX_LPCG_CLK_4>;
 		assigned-clock-rates = <200000000>, <200000000>;
 		power-domains = <&pd IMX_SC_R_MJPEG_DEC_MP>,
-				<&pd IMX_SC_R_MJPEG_DEC_S0>,
-				<&pd IMX_SC_R_MJPEG_DEC_S1>,
-				<&pd IMX_SC_R_MJPEG_DEC_S2>,
-				<&pd IMX_SC_R_MJPEG_DEC_S3>;
+				<&pd IMX_SC_R_MJPEG_DEC_S0>;
+		slot = <0>;
 	};
 
 	jpegenc: jpegenc@58450000 {
 		reg = <0x58450000 0x00050000>;
-		interrupts = <GIC_SPI 305 IRQ_TYPE_LEVEL_HIGH>,
-			     <GIC_SPI 306 IRQ_TYPE_LEVEL_HIGH>,
-			     <GIC_SPI 307 IRQ_TYPE_LEVEL_HIGH>,
-			     <GIC_SPI 308 IRQ_TYPE_LEVEL_HIGH>;
+		interrupts = <GIC_SPI 305 IRQ_TYPE_LEVEL_HIGH>;
 		clocks = <&img_jpeg_enc_lpcg IMX_LPCG_CLK_0>,
 			 <&img_jpeg_enc_lpcg IMX_LPCG_CLK_4>;
 		clock-names = "per", "ipg";
@@ -48,10 +40,8 @@ jpegenc: jpegenc@58450000 {
 				  <&img_jpeg_enc_lpcg IMX_LPCG_CLK_4>;
 		assigned-clock-rates = <200000000>, <200000000>;
 		power-domains = <&pd IMX_SC_R_MJPEG_ENC_MP>,
-				<&pd IMX_SC_R_MJPEG_ENC_S0>,
-				<&pd IMX_SC_R_MJPEG_ENC_S1>,
-				<&pd IMX_SC_R_MJPEG_ENC_S2>,
-				<&pd IMX_SC_R_MJPEG_ENC_S3>;
+				<&pd IMX_SC_R_MJPEG_ENC_S0>;
+		slot = <0>;
 	};
 
 	img_jpeg_dec_lpcg: clock-controller@585d0000 {
-- 
2.38.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH v2 2/2] dt-bindings: media: imx-jpeg: Assign slot for imx jpeg encoder/decoder
  2023-09-21  6:36 [PATCH v2 1/2] arm64: dts: imx8-ss-img: Assign slot for imx jpeg encoder/decoder Ming Qian
@ 2023-09-21  6:36 ` Ming Qian
  2023-09-21  9:54   ` Krzysztof Kozlowski
  2023-09-21  9:56 ` [PATCH v2 1/2] arm64: dts: imx8-ss-img: " Krzysztof Kozlowski
  1 sibling, 1 reply; 6+ messages in thread
From: Ming Qian @ 2023-09-21  6:36 UTC (permalink / raw)
  To: mirela.rabulea, robh+dt, shawnguo
  Cc: mchehab, hverkuil-cisco, s.hauer, kernel, festevam, xiahong.bao,
	eagle.zhou, tao.jiang_2, linux-imx, linux-media, linux-kernel,
	linux-arm-kernel

There are total 4 slots available in the IP,
and we only need to use one slot in one os,
assign a single slot,
configure interrupt and power domain only for 1 slot,
not for the all 4 slots.

Signed-off-by: Ming Qian <ming.qian@nxp.com>
---
 .../bindings/media/nxp,imx8-jpeg.yaml         | 40 ++++++++-----------
 1 file changed, 16 insertions(+), 24 deletions(-)

diff --git a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
index 3d9d1db37040..5f0e2fc1ea9c 100644
--- a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
+++ b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
@@ -32,25 +32,27 @@ properties:
     maxItems: 1
 
   interrupts:
-    description: |
-      There are 4 slots available in the IP, which the driver may use
-      If a certain slot is used, it should have an associated interrupt
-      The interrupt with index i is assumed to be for slot i
-    minItems: 1               # At least one slot is needed by the driver
-    maxItems: 4               # The IP has 4 slots available for use
+    description:
+      Interrupt number for slot
+    maxItems: 1
 
   power-domains:
     description:
       List of phandle and PM domain specifier as documented in
       Documentation/devicetree/bindings/power/power_domain.txt
-    minItems: 2               # Wrapper and 1 slot
-    maxItems: 5               # Wrapper and 4 slots
+    minItems: 1               # VPUMIX
+    maxItems: 2               # Wrapper and 1 slot
+
+  slot:
+    description:
+      Integer number of slot index used. the value range is from 0 to 3
 
 required:
   - compatible
   - reg
   - interrupts
   - power-domains
+  - slot
 
 additionalProperties: false
 
@@ -62,28 +64,18 @@ examples:
     jpegdec: jpegdec@58400000 {
         compatible = "nxp,imx8qxp-jpgdec";
         reg = <0x58400000 0x00050000 >;
-        interrupts = <GIC_SPI 309 IRQ_TYPE_LEVEL_HIGH>,
-                     <GIC_SPI 310 IRQ_TYPE_LEVEL_HIGH>,
-                     <GIC_SPI 311 IRQ_TYPE_LEVEL_HIGH>,
-                     <GIC_SPI 312 IRQ_TYPE_LEVEL_HIGH>;
+        interrupts = <GIC_SPI 309 IRQ_TYPE_LEVEL_HIGH>;
         power-domains = <&pd IMX_SC_R_MJPEG_DEC_MP>,
-                        <&pd IMX_SC_R_MJPEG_DEC_S0>,
-                        <&pd IMX_SC_R_MJPEG_DEC_S1>,
-                        <&pd IMX_SC_R_MJPEG_DEC_S2>,
-                        <&pd IMX_SC_R_MJPEG_DEC_S3>;
+                        <&pd IMX_SC_R_MJPEG_DEC_S0>;
+        slot = <0>;
     };
 
     jpegenc: jpegenc@58450000 {
         compatible = "nxp,imx8qm-jpgenc", "nxp,imx8qxp-jpgenc";
         reg = <0x58450000 0x00050000 >;
-        interrupts = <GIC_SPI 305 IRQ_TYPE_LEVEL_HIGH>,
-                     <GIC_SPI 306 IRQ_TYPE_LEVEL_HIGH>,
-                     <GIC_SPI 307 IRQ_TYPE_LEVEL_HIGH>,
-                     <GIC_SPI 308 IRQ_TYPE_LEVEL_HIGH>;
+        interrupts = <GIC_SPI 305 IRQ_TYPE_LEVEL_HIGH>;
         power-domains = <&pd IMX_SC_R_MJPEG_ENC_MP>,
-                        <&pd IMX_SC_R_MJPEG_ENC_S0>,
-                        <&pd IMX_SC_R_MJPEG_ENC_S1>,
-                        <&pd IMX_SC_R_MJPEG_ENC_S2>,
-                        <&pd IMX_SC_R_MJPEG_ENC_S3>;
+                        <&pd IMX_SC_R_MJPEG_ENC_S0>;
+        slot = <0>;
     };
 ...
-- 
2.38.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v2 2/2] dt-bindings: media: imx-jpeg: Assign slot for imx jpeg encoder/decoder
  2023-09-21  6:36 ` [PATCH v2 2/2] dt-bindings: media: imx-jpeg: " Ming Qian
@ 2023-09-21  9:54   ` Krzysztof Kozlowski
  2023-09-22  1:33     ` [EXT] " Ming Qian
  0 siblings, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2023-09-21  9:54 UTC (permalink / raw)
  To: Ming Qian, mirela.rabulea, robh+dt, shawnguo
  Cc: mchehab, hverkuil-cisco, s.hauer, kernel, festevam, xiahong.bao,
	eagle.zhou, tao.jiang_2, linux-imx, linux-media, linux-kernel,
	linux-arm-kernel

On 21/09/2023 08:36, Ming Qian wrote:
> There are total 4 slots available in the IP,
> and we only need to use one slot in one os,
> assign a single slot,
> configure interrupt and power domain only for 1 slot,
> not for the all 4 slots.

Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.

You missed at least devicetree list (maybe more), so this won't be
tested by automated tooling. Performing review on untested code might be
a waste of time, thus I will skip this patch entirely till you follow
the process allowing the patch to be tested.

Please kindly resend and include all necessary To/Cc entries.

> 
> Signed-off-by: Ming Qian <ming.qian@nxp.com>
> ---
>  .../bindings/media/nxp,imx8-jpeg.yaml         | 40 ++++++++-----------
>  1 file changed, 16 insertions(+), 24 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
> index 3d9d1db37040..5f0e2fc1ea9c 100644
> --- a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
> +++ b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
> @@ -32,25 +32,27 @@ properties:
>      maxItems: 1
>  
>    interrupts:
> -    description: |
> -      There are 4 slots available in the IP, which the driver may use
> -      If a certain slot is used, it should have an associated interrupt
> -      The interrupt with index i is assumed to be for slot i
> -    minItems: 1               # At least one slot is needed by the driver
> -    maxItems: 4               # The IP has 4 slots available for use
> +    description:
> +      Interrupt number for slot
> +    maxItems: 1
>  
>    power-domains:
>      description:
>        List of phandle and PM domain specifier as documented in
>        Documentation/devicetree/bindings/power/power_domain.txt
> -    minItems: 2               # Wrapper and 1 slot
> -    maxItems: 5               # Wrapper and 4 slots
> +    minItems: 1               # VPUMIX
> +    maxItems: 2               # Wrapper and 1 slot
> +
> +  slot:
> +    description:
> +      Integer number of slot index used. the value range is from 0 to 3

Don't you have here obvious errors reported by testing? Did you test this?

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v2 1/2] arm64: dts: imx8-ss-img: Assign slot for imx jpeg encoder/decoder
  2023-09-21  6:36 [PATCH v2 1/2] arm64: dts: imx8-ss-img: Assign slot for imx jpeg encoder/decoder Ming Qian
  2023-09-21  6:36 ` [PATCH v2 2/2] dt-bindings: media: imx-jpeg: " Ming Qian
@ 2023-09-21  9:56 ` Krzysztof Kozlowski
  1 sibling, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2023-09-21  9:56 UTC (permalink / raw)
  To: Ming Qian, mirela.rabulea, robh+dt, shawnguo
  Cc: mchehab, hverkuil-cisco, s.hauer, kernel, festevam, xiahong.bao,
	eagle.zhou, tao.jiang_2, linux-imx, linux-media, linux-kernel,
	linux-arm-kernel

On 21/09/2023 08:36, Ming Qian wrote:
> assign a single slot,
> configure interrupt and power domain only for 1 slot,
> not for the all 4 slots.

Please wrap commit message according to Linux coding style / submission
process (neither too early nor over the limit):
https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597

Meke these proper sentences, so starting with capital letter and ending
with full stop.

Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.


Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 6+ messages in thread

* RE: [EXT] Re: [PATCH v2 2/2] dt-bindings: media: imx-jpeg: Assign slot for imx jpeg encoder/decoder
  2023-09-21  9:54   ` Krzysztof Kozlowski
@ 2023-09-22  1:33     ` Ming Qian
  2023-09-23 11:41       ` Krzysztof Kozlowski
  0 siblings, 1 reply; 6+ messages in thread
From: Ming Qian @ 2023-09-22  1:33 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Mirela Rabulea (OSS), robh+dt, shawnguo
  Cc: mchehab, hverkuil-cisco, s.hauer, kernel, festevam, X.H. Bao,
	Eagle Zhou, Tao Jiang, dl-linux-imx, linux-media, linux-kernel,
	linux-arm-kernel

>From: Krzysztof Kozlowski <krzk@kernel.org>
>Sent: 2023年9月21日 17:55
>To: Ming Qian <ming.qian@nxp.com>; Mirela Rabulea (OSS)
><mirela.rabulea@oss.nxp.com>; robh+dt@kernel.org; shawnguo@kernel.org
>Cc: mchehab@kernel.org; hverkuil-cisco@xs4all.nl; s.hauer@pengutronix.de;
>kernel@pengutronix.de; festevam@gmail.com; X.H. Bao
><xiahong.bao@nxp.com>; Eagle Zhou <eagle.zhou@nxp.com>; Tao Jiang
><tao.jiang_2@nxp.com>; dl-linux-imx <linux-imx@nxp.com>; linux-
>media@vger.kernel.org; linux-kernel@vger.kernel.org; linux-arm-
>kernel@lists.infradead.org
>Subject: [EXT] Re: [PATCH v2 2/2] dt-bindings: media: imx-jpeg: Assign slot for
>imx jpeg encoder/decoder
>
>Caution: This is an external email. Please take care when clicking links or
>opening attachments. When in doubt, report the message using the 'Report
>this email' button
>
>
>On 21/09/2023 08:36, Ming Qian wrote:
>> There are total 4 slots available in the IP, and we only need to use
>> one slot in one os, assign a single slot, configure interrupt and
>> power domain only for 1 slot, not for the all 4 slots.
>
>Please use scripts/get_maintainers.pl to get a list of necessary people and lists
>to CC. It might happen, that command when run on an older kernel, gives you
>outdated entries. Therefore please be sure you base your patches on recent
>Linux kernel.
>
>You missed at least devicetree list (maybe more), so this won't be tested by
>automated tooling. Performing review on untested code might be a waste of
>time, thus I will skip this patch entirely till you follow the process allowing the
>patch to be tested.
>
>Please kindly resend and include all necessary To/Cc entries.
>
>>
>> Signed-off-by: Ming Qian <ming.qian@nxp.com>
>> ---
>>  .../bindings/media/nxp,imx8-jpeg.yaml         | 40 ++++++++-----------
>>  1 file changed, 16 insertions(+), 24 deletions(-)
>>
>> diff --git
>> a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
>> b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
>> index 3d9d1db37040..5f0e2fc1ea9c 100644
>> --- a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
>> +++ b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
>> @@ -32,25 +32,27 @@ properties:
>>      maxItems: 1
>>
>>    interrupts:
>> -    description: |
>> -      There are 4 slots available in the IP, which the driver may use
>> -      If a certain slot is used, it should have an associated interrupt
>> -      The interrupt with index i is assumed to be for slot i
>> -    minItems: 1               # At least one slot is needed by the driver
>> -    maxItems: 4               # The IP has 4 slots available for use
>> +    description:
>> +      Interrupt number for slot
>> +    maxItems: 1
>>
>>    power-domains:
>>      description:
>>        List of phandle and PM domain specifier as documented in
>>        Documentation/devicetree/bindings/power/power_domain.txt
>> -    minItems: 2               # Wrapper and 1 slot
>> -    maxItems: 5               # Wrapper and 4 slots
>> +    minItems: 1               # VPUMIX
>> +    maxItems: 2               # Wrapper and 1 slot
>> +
>> +  slot:
>> +    description:
>> +      Integer number of slot index used. the value range is from 0 to
>> + 3
>
>Don't you have here obvious errors reported by testing? Did you test this?
>
>Best regards,
>Krzysztof

Hi Krzysztof,
    Can you point out which test error? I run the dt_binding_check and didn't get any error.

make DT_CHECKER_FLAGS=-m dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
  LINT    Documentation/devicetree/bindings
  CHKDT   Documentation/devicetree/bindings/processed-schema.json
  SCHEMA  Documentation/devicetree/bindings/processed-schema.json
  DTEX    Documentation/devicetree/bindings/media/nxp,imx8-jpeg.example.dts
  DTC_CHK Documentation/devicetree/bindings/media/nxp,imx8-jpeg.example.dtb


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [EXT] Re: [PATCH v2 2/2] dt-bindings: media: imx-jpeg: Assign slot for imx jpeg encoder/decoder
  2023-09-22  1:33     ` [EXT] " Ming Qian
@ 2023-09-23 11:41       ` Krzysztof Kozlowski
  0 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2023-09-23 11:41 UTC (permalink / raw)
  To: Ming Qian, Mirela Rabulea (OSS), robh+dt, shawnguo
  Cc: mchehab, hverkuil-cisco, s.hauer, kernel, festevam, X.H. Bao,
	Eagle Zhou, Tao Jiang, dl-linux-imx, linux-media, linux-kernel,
	linux-arm-kernel

On 22/09/2023 03:33, Ming Qian wrote:
>> From: Krzysztof Kozlowski <krzk@kernel.org>
>> Sent: 2023年9月21日 17:55
>> To: Ming Qian <ming.qian@nxp.com>; Mirela Rabulea (OSS)
>> <mirela.rabulea@oss.nxp.com>; robh+dt@kernel.org; shawnguo@kernel.org
>> Cc: mchehab@kernel.org; hverkuil-cisco@xs4all.nl; s.hauer@pengutronix.de;
>> kernel@pengutronix.de; festevam@gmail.com; X.H. Bao
>> <xiahong.bao@nxp.com>; Eagle Zhou <eagle.zhou@nxp.com>; Tao Jiang
>> <tao.jiang_2@nxp.com>; dl-linux-imx <linux-imx@nxp.com>; linux-
>> media@vger.kernel.org; linux-kernel@vger.kernel.org; linux-arm-
>> kernel@lists.infradead.org
>> Subject: [EXT] Re: [PATCH v2 2/2] dt-bindings: media: imx-jpeg: Assign slot for
>> imx jpeg encoder/decoder
>>
>> Caution: This is an external email. Please take care when clicking links or
>> opening attachments. When in doubt, report the message using the 'Report
>> this email' button
>>
>>
>> On 21/09/2023 08:36, Ming Qian wrote:
>>> There are total 4 slots available in the IP, and we only need to use
>>> one slot in one os, assign a single slot, configure interrupt and
>>> power domain only for 1 slot, not for the all 4 slots.
>>
>> Please use scripts/get_maintainers.pl to get a list of necessary people and lists
>> to CC. It might happen, that command when run on an older kernel, gives you
>> outdated entries. Therefore please be sure you base your patches on recent
>> Linux kernel.
>>
>> You missed at least devicetree list (maybe more), so this won't be tested by
>> automated tooling. Performing review on untested code might be a waste of
>> time, thus I will skip this patch entirely till you follow the process allowing the
>> patch to be tested.
>>
>> Please kindly resend and include all necessary To/Cc entries.
>>
>>>
>>> Signed-off-by: Ming Qian <ming.qian@nxp.com>
>>> ---
>>>  .../bindings/media/nxp,imx8-jpeg.yaml         | 40 ++++++++-----------
>>>  1 file changed, 16 insertions(+), 24 deletions(-)
>>>
>>> diff --git
>>> a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
>>> b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
>>> index 3d9d1db37040..5f0e2fc1ea9c 100644
>>> --- a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
>>> +++ b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
>>> @@ -32,25 +32,27 @@ properties:
>>>      maxItems: 1
>>>
>>>    interrupts:
>>> -    description: |
>>> -      There are 4 slots available in the IP, which the driver may use
>>> -      If a certain slot is used, it should have an associated interrupt
>>> -      The interrupt with index i is assumed to be for slot i
>>> -    minItems: 1               # At least one slot is needed by the driver
>>> -    maxItems: 4               # The IP has 4 slots available for use
>>> +    description:
>>> +      Interrupt number for slot
>>> +    maxItems: 1
>>>
>>>    power-domains:
>>>      description:
>>>        List of phandle and PM domain specifier as documented in
>>>        Documentation/devicetree/bindings/power/power_domain.txt
>>> -    minItems: 2               # Wrapper and 1 slot
>>> -    maxItems: 5               # Wrapper and 4 slots
>>> +    minItems: 1               # VPUMIX
>>> +    maxItems: 2               # Wrapper and 1 slot
>>> +
>>> +  slot:
>>> +    description:
>>> +      Integer number of slot index used. the value range is from 0 to
>>> + 3
>>
>> Don't you have here obvious errors reported by testing? Did you test this?
>>
>> Best regards,
>> Krzysztof
> 
> Hi Krzysztof,
>     Can you point out which test error? I run the dt_binding_check and didn't get any error.

Hm, I guess we need to add some checks for this... You miss type and
vendor prefix. This does not look like generic property. Constraints are
also missing, but that's minor. The main point is that this does not
look suitable for DT at all. Your description says nothing - copies
property name. Commit msg also does not explain it.

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2023-09-23 11:41 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-21  6:36 [PATCH v2 1/2] arm64: dts: imx8-ss-img: Assign slot for imx jpeg encoder/decoder Ming Qian
2023-09-21  6:36 ` [PATCH v2 2/2] dt-bindings: media: imx-jpeg: " Ming Qian
2023-09-21  9:54   ` Krzysztof Kozlowski
2023-09-22  1:33     ` [EXT] " Ming Qian
2023-09-23 11:41       ` Krzysztof Kozlowski
2023-09-21  9:56 ` [PATCH v2 1/2] arm64: dts: imx8-ss-img: " Krzysztof Kozlowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome