mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alex Elder <elder@riscstar.com>
To: "Rob Herring (Arm)" <robh@kernel.org>
Cc: lpieralisi@kernel.org, quic_schintav@quicinc.com,
	devicetree@vger.kernel.org, conor+dt@kernel.org,
	krzk+dt@kernel.org, p.zabel@pengutronix.de,
	linux-kernel@vger.kernel.org, inochiama@gmail.com,
	fan.ni@samsung.com, aou@eecs.berkeley.edu, alex@ghiti.fr,
	palmer@dabbelt.com, paul.walmsley@sifive.com,
	spacemit@lists.linux.dev, thippeswamy.havalige@amd.com,
	namcao@linutronix.de, linux-pci@vger.kernel.org,
	shradha.t@samsung.com, vkoul@kernel.org, dlan@gentoo.org,
	johan+linaro@kernel.org, kishon@kernel.org, mani@kernel.org,
	mayank.rana@oss.qualcomm.com, tglx@linutronix.de,
	bhelgaas@google.com, linux-phy@lists.infradead.org,
	kwilczynski@kernel.org, linux-riscv@lists.infradead.org
Subject: Re: [PATCH 3/6] dt-bindings: phy: spacemit: introduce PCIe root complex
Date: Wed, 13 Aug 2025 16:21:22 -0500	[thread overview]
Message-ID: <8ebc466c-1b9f-4ba3-a38e-bda6007c5b97@riscstar.com> (raw)
In-Reply-To: <175511815210.798605.10564052572461813362.robh@kernel.org>

On 8/13/25 3:49 PM, Rob Herring (Arm) wrote:
> 
> On Wed, 13 Aug 2025 13:46:57 -0500, Alex Elder wrote:
>> Add the Device Tree binding for the PCIe root complex found on the
>> SpacemiT K1 SoC.  This device is derived from the Synopsys Designware
>> PCIe IP.  It supports up to three PCIe ports operating at PCIe gen 2
>> link speeds (5 GT/sec).  One of the ports uses a combo PHY, which is
>> typically used to support a USB 3 port.
>>
>> Signed-off-by: Alex Elder <elder@riscstar.com>
>> ---
>>   .../bindings/pci/spacemit,k1-pcie-rc.yaml     | 141 ++++++++++++++++++
>>   1 file changed, 141 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/pci/spacemit,k1-pcie-rc.yaml
>>
> 
> My bot found errors running 'make dt_binding_check' on your patch:

Mine didn't for some reason, so I must be doing something wrong.

Simple inspection shows my compatible string contains ".yaml"!

I'll fix in a new version.  Sorry I missed this.

					-Alex

> yamllint warnings/errors:
> 
> dtschema/dtc warnings/errors:
> Documentation/devicetree/bindings/pci/spacemit,k1-pcie-rc.example.dtb: /example-0/pcie@ca000000: failed to match any schema with compatible: ['spacemit,k1-pcie-rc']
> 
> doc reference errors (make refcheckdocs):
> 
> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250813184701.2444372-4-elder@riscstar.com
> 
> The base for the series is generally the latest rc1. A different dependency
> should be noted in *this* patch.
> 
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
> 
> pip3 install dtschema --upgrade
> 
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your schema.
> 


  reply	other threads:[~2025-08-13 21:21 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-13 18:46 [PATCH 0/6] Introduce SpacemiT K1 PCIe phy and host controller Alex Elder
2025-08-13 18:46 ` [PATCH 1/6] dt-bindings: phy: spacemit: add SpacemiT PCIe/combo PHY Alex Elder
2025-08-14  2:52   ` Yao Zi
2025-08-14 12:30     ` Alex Elder
2025-08-14  6:11   ` Krzysztof Kozlowski
2025-08-14 11:59     ` Alex Elder
2025-08-14 20:51   ` Rob Herring
2025-08-14 21:48     ` Alex Elder
2025-08-13 18:46 ` [PATCH 2/6] dt-bindings: phy: spacemit: introduce PCIe PHY Alex Elder
2025-08-14  6:17   ` Krzysztof Kozlowski
2025-08-13 18:46 ` [PATCH 3/6] dt-bindings: phy: spacemit: introduce PCIe root complex Alex Elder
2025-08-13 20:49   ` Rob Herring (Arm)
2025-08-13 21:21     ` Alex Elder [this message]
2025-09-15  8:14   ` Manivannan Sadhasivam
2025-09-19 20:14     ` Alex Elder
2025-09-20  5:55       ` Manivannan Sadhasivam
2025-10-01  2:40         ` Alex Elder
2025-08-13 18:46 ` [PATCH 4/6] phy: spacemit: introduce PCIe/combo PHY Alex Elder
2025-08-13 23:42   ` Inochi Amaoto
2025-08-14 12:15     ` Alex Elder
2025-08-14 22:49       ` Inochi Amaoto
2025-08-14 23:57       ` Yixun Lan
2025-08-13 18:46 ` [PATCH 5/6] PCI: spacemit: introduce SpacemiT PCIe host driver Alex Elder
2025-08-13 21:22   ` Bjorn Helgaas
2025-08-13 21:27     ` Alex Elder
2025-09-19 18:06       ` Alex Elder
2025-09-15  8:09   ` Manivannan Sadhasivam
2025-09-19 22:10     ` Alex Elder
2025-09-20  5:33       ` Manivannan Sadhasivam
2025-10-01  2:40       ` Alex Elder
2025-08-13 18:47 ` [PATCH 6/6] riscv: dts: spacemit: PCIe and PHY-related updates Alex Elder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8ebc466c-1b9f-4ba3-a38e-bda6007c5b97@riscstar.com \
    --to=elder@riscstar.com \
    --cc=alex@ghiti.fr \
    --cc=aou@eecs.berkeley.edu \
    --cc=bhelgaas@google.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlan@gentoo.org \
    --cc=fan.ni@samsung.com \
    --cc=inochiama@gmail.com \
    --cc=johan+linaro@kernel.org \
    --cc=kishon@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=kwilczynski@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=lpieralisi@kernel.org \
    --cc=mani@kernel.org \
    --cc=mayank.rana@oss.qualcomm.com \
    --cc=namcao@linutronix.de \
    --cc=p.zabel@pengutronix.de \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=quic_schintav@quicinc.com \
    --cc=robh@kernel.org \
    --cc=shradha.t@samsung.com \
    --cc=spacemit@lists.linux.dev \
    --cc=tglx@linutronix.de \
    --cc=thippeswamy.havalige@amd.com \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®