mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chanwoo Choi <chanwoo@kernel.org>
To: Yue Haibing <yuehaibing@huawei.com>,
	cw00.choi@samsung.com, krzysztof.kozlowski@linaro.org,
	lee@kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] mfd: max77686: Remove unused extern declarations
Date: Sat, 29 Jul 2023 06:55:21 +0900	[thread overview]
Message-ID: <8ec9fc9c-a68e-422b-9b5e-c280652bc5b5@kernel.org> (raw)
In-Reply-To: <20230728132709.27052-1-yuehaibing@huawei.com>

On 23. 7. 28. 22:27, Yue Haibing wrote:
> max77686_irq_init() and max77686_irq_exit() are not used since
> commit 6f1c1e71d933 ("mfd: max77686: Convert to use regmap_irq").
> And max77686_irq_resume() never be implemented since introduced in
> commit dae8a969d512 ("mfd: Add Maxim 77686 driver").
> 
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
> ---
>  include/linux/mfd/max77686-private.h | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/include/linux/mfd/max77686-private.h b/include/linux/mfd/max77686-private.h
> index 3acceeedbaba..ea635d12a741 100644
> --- a/include/linux/mfd/max77686-private.h
> +++ b/include/linux/mfd/max77686-private.h
> @@ -441,8 +441,4 @@ enum max77686_types {
>  	TYPE_MAX77802,
>  };
>  
> -extern int max77686_irq_init(struct max77686_dev *max77686);
> -extern void max77686_irq_exit(struct max77686_dev *max77686);
> -extern int max77686_irq_resume(struct max77686_dev *max77686);
> -
>  #endif /*  __LINUX_MFD_MAX77686_PRIV_H */

Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
-- 
Best Regards,
Samsung Electronics
Chanwoo Choi


  parent reply	other threads:[~2023-07-28 21:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-28 13:27 Yue Haibing
2023-07-28 13:28 ` Krzysztof Kozlowski
2023-07-28 21:55 ` Chanwoo Choi [this message]
2023-08-16  9:57 ` (subset) " Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8ec9fc9c-a68e-422b-9b5e-c280652bc5b5@kernel.org \
    --to=chanwoo@kernel.org \
    --cc=cw00.choi@samsung.com \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=lee@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yuehaibing@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®