* [PATCH -next] mfd: max77686: Remove unused extern declarations
@ 2023-07-28 13:27 Yue Haibing
2023-07-28 13:28 ` Krzysztof Kozlowski
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Yue Haibing @ 2023-07-28 13:27 UTC (permalink / raw)
To: cw00.choi, krzysztof.kozlowski, lee, yuehaibing; +Cc: linux-kernel
max77686_irq_init() and max77686_irq_exit() are not used since
commit 6f1c1e71d933 ("mfd: max77686: Convert to use regmap_irq").
And max77686_irq_resume() never be implemented since introduced in
commit dae8a969d512 ("mfd: Add Maxim 77686 driver").
Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
---
include/linux/mfd/max77686-private.h | 4 ----
1 file changed, 4 deletions(-)
diff --git a/include/linux/mfd/max77686-private.h b/include/linux/mfd/max77686-private.h
index 3acceeedbaba..ea635d12a741 100644
--- a/include/linux/mfd/max77686-private.h
+++ b/include/linux/mfd/max77686-private.h
@@ -441,8 +441,4 @@ enum max77686_types {
TYPE_MAX77802,
};
-extern int max77686_irq_init(struct max77686_dev *max77686);
-extern void max77686_irq_exit(struct max77686_dev *max77686);
-extern int max77686_irq_resume(struct max77686_dev *max77686);
-
#endif /* __LINUX_MFD_MAX77686_PRIV_H */
--
2.34.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH -next] mfd: max77686: Remove unused extern declarations
2023-07-28 13:27 [PATCH -next] mfd: max77686: Remove unused extern declarations Yue Haibing
@ 2023-07-28 13:28 ` Krzysztof Kozlowski
2023-07-28 21:55 ` Chanwoo Choi
2023-08-16 9:57 ` (subset) " Lee Jones
2 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2023-07-28 13:28 UTC (permalink / raw)
To: Yue Haibing, cw00.choi, lee; +Cc: linux-kernel
On 28/07/2023 15:27, Yue Haibing wrote:
> max77686_irq_init() and max77686_irq_exit() are not used since
> commit 6f1c1e71d933 ("mfd: max77686: Convert to use regmap_irq").
> And max77686_irq_resume() never be implemented since introduced in
> commit dae8a969d512 ("mfd: Add Maxim 77686 driver").
>
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH -next] mfd: max77686: Remove unused extern declarations
2023-07-28 13:27 [PATCH -next] mfd: max77686: Remove unused extern declarations Yue Haibing
2023-07-28 13:28 ` Krzysztof Kozlowski
@ 2023-07-28 21:55 ` Chanwoo Choi
2023-08-16 9:57 ` (subset) " Lee Jones
2 siblings, 0 replies; 4+ messages in thread
From: Chanwoo Choi @ 2023-07-28 21:55 UTC (permalink / raw)
To: Yue Haibing, cw00.choi, krzysztof.kozlowski, lee; +Cc: linux-kernel
On 23. 7. 28. 22:27, Yue Haibing wrote:
> max77686_irq_init() and max77686_irq_exit() are not used since
> commit 6f1c1e71d933 ("mfd: max77686: Convert to use regmap_irq").
> And max77686_irq_resume() never be implemented since introduced in
> commit dae8a969d512 ("mfd: Add Maxim 77686 driver").
>
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
> ---
> include/linux/mfd/max77686-private.h | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/include/linux/mfd/max77686-private.h b/include/linux/mfd/max77686-private.h
> index 3acceeedbaba..ea635d12a741 100644
> --- a/include/linux/mfd/max77686-private.h
> +++ b/include/linux/mfd/max77686-private.h
> @@ -441,8 +441,4 @@ enum max77686_types {
> TYPE_MAX77802,
> };
>
> -extern int max77686_irq_init(struct max77686_dev *max77686);
> -extern void max77686_irq_exit(struct max77686_dev *max77686);
> -extern int max77686_irq_resume(struct max77686_dev *max77686);
> -
> #endif /* __LINUX_MFD_MAX77686_PRIV_H */
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
--
Best Regards,
Samsung Electronics
Chanwoo Choi
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: (subset) [PATCH -next] mfd: max77686: Remove unused extern declarations
2023-07-28 13:27 [PATCH -next] mfd: max77686: Remove unused extern declarations Yue Haibing
2023-07-28 13:28 ` Krzysztof Kozlowski
2023-07-28 21:55 ` Chanwoo Choi
@ 2023-08-16 9:57 ` Lee Jones
2 siblings, 0 replies; 4+ messages in thread
From: Lee Jones @ 2023-08-16 9:57 UTC (permalink / raw)
To: cw00.choi, krzysztof.kozlowski, lee, Yue Haibing; +Cc: linux-kernel
On Fri, 28 Jul 2023 21:27:09 +0800, Yue Haibing wrote:
> max77686_irq_init() and max77686_irq_exit() are not used since
> commit 6f1c1e71d933 ("mfd: max77686: Convert to use regmap_irq").
> And max77686_irq_resume() never be implemented since introduced in
> commit dae8a969d512 ("mfd: Add Maxim 77686 driver").
>
>
Applied, thanks!
[1/1] mfd: max77686: Remove unused extern declarations
commit: 23f033eb371762d7f8d78172ab0bddd4d3bec626
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-08-16 9:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-28 13:27 [PATCH -next] mfd: max77686: Remove unused extern declarations Yue Haibing
2023-07-28 13:28 ` Krzysztof Kozlowski
2023-07-28 21:55 ` Chanwoo Choi
2023-08-16 9:57 ` (subset) " Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®