mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jeremy Kerr <jk@codeconstruct.com.au>
To: Karl Mehltretter <kmehltretter@gmail.com>,
	Matt Johnston <matt@codeconstruct.com.au>
Cc: "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	 Jakub Kicinski	 <kuba@kernel.org>,
	Paolo Abeni <pabeni@redhat.com>, Simon Horman	 <horms@kernel.org>,
	netdev@vger.kernel.org,
	Geert Uytterhoeven	 <geert@linux-m68k.org>,
	Brendan Higgins <brendan.higgins@linux.dev>,
	David Gow	 <david@davidgow.net>, Rae Moar <raemoar63@gmail.com>,
		linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com,
		linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net: mctp: Stop selecting flow support for KUnit tests
Date: Sat, 26 Sep 2026 15:53:28 +0800	[thread overview]
Message-ID: <8edc4e71edceb124e2dca233cddb75e198b53a51.camel@codeconstruct.com.au> (raw)
In-Reply-To: <20260925192510.93840-1-kmehltretter@gmail.com>

Hi Karl,

> MCTP_TEST selects MCTP_FLOWS, which also enables SKB_EXTENSIONS when no
> transport requires them.

But we want to test the flows support, why disable this (and
consequently skip the flow tests in the vast majority of test runs)?

> Remove the selection to follow the dependency
> rule in Documentation/dev-tools/kunit/style.rst.

That suggests "depending on", rather than removing the coverage.

Cheers,


Jeremy

  reply	other threads:[~2026-09-26  7:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-25 19:25 Karl Mehltretter
2026-09-26  7:53 ` Jeremy Kerr [this message]
2026-09-26  8:43   ` Karl Mehltretter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8edc4e71edceb124e2dca233cddb75e198b53a51.camel@codeconstruct.com.au \
    --to=jk@codeconstruct.com.au \
    --cc=brendan.higgins@linux.dev \
    --cc=davem@davemloft.net \
    --cc=david@davidgow.net \
    --cc=edumazet@google.com \
    --cc=geert@linux-m68k.org \
    --cc=horms@kernel.org \
    --cc=kmehltretter@gmail.com \
    --cc=kuba@kernel.org \
    --cc=kunit-dev@googlegroups.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=matt@codeconstruct.com.au \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=raemoar63@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®