[PATCH net-next] net: mctp: Stop selecting flow support for KUnit tests

[PATCH net-next] net: mctp: Stop selecting flow support for KUnit tests

[Karl Mehltretter]

MCTP_TEST selects MCTP_FLOWS, which also enables SKB_EXTENSIONS when no
transport requires them. Remove the selection to follow the dependency
rule in Documentation/dev-tools/kunit/style.rst.

The two flow-specific tests already skip when MCTP_FLOWS is disabled.
The remaining tests can run in either configuration.

Fixes: 109a5331143d ("net: mctp: tests: Test that outgoing skbs have flow data populated")
Assisted-by: LLM
Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
---
Validation on net-next 42a9fb3382fc: x86_64 LLVM builds and QEMU runs
with MCTP_FLOWS disabled and enabled. Both suites pass. With flow support
disabled, only the two flow-specific cases skip. The enabled configuration
uses the I2C transport to select MCTP_FLOWS.

 net/mctp/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/net/mctp/Kconfig b/net/mctp/Kconfig
index d8d3413a37f7..3a5c0e70da77 100644
--- a/net/mctp/Kconfig
+++ b/net/mctp/Kconfig
@@ -14,7 +14,6 @@ menuconfig MCTP
 
 config MCTP_TEST
         bool "MCTP core tests" if !KUNIT_ALL_TESTS
-        select MCTP_FLOWS
         depends on MCTP=y && KUNIT=y
         default KUNIT_ALL_TESTS
 

base-commit: 42a9fb3382fc2573e92f41d203b095d9a372cfc9

Re: [PATCH net-next] net: mctp: Stop selecting flow support for KUnit tests

[Jeremy Kerr]

Hi Karl,

> MCTP_TEST selects MCTP_FLOWS, which also enables SKB_EXTENSIONS when no
> transport requires them.

But we want to test the flows support, why disable this (and
consequently skip the flow tests in the vast majority of test runs)?

> Remove the selection to follow the dependency
> rule in Documentation/dev-tools/kunit/style.rst.

That suggests "depending on", rather than removing the coverage.

Cheers,


Jeremy

Re: [PATCH net-next] net: mctp: Stop selecting flow support for KUnit tests

[Karl Mehltretter]

On Sat, Sep 26, 2026 at 03:53:28PM +0100, Jeremy Kerr wrote:
> Hi Karl,
> 
> > MCTP_TEST selects MCTP_FLOWS, which also enables SKB_EXTENSIONS when no
> > transport requires them.
> 
> But we want to test the flows support, why disable this (and
> consequently skip the flow tests in the vast majority of test runs)?
> 
> > Remove the selection to follow the dependency
> > rule in Documentation/dev-tools/kunit/style.rst.
> 
> That suggests "depending on", rather than removing the coverage.
> 

Hi Jeremy,

Thanks for the review!

OK, I can change that.

I was confused by the existing !MCTP_FLOWS fallbacks, but now understand
that you want the suite to retain full flow-test coverage.

Karl