From: David Hildenbrand <david@redhat.com>
To: Alexander Atanasov <alexander.atanasov@virtuozzo.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>
Cc: kernel@openvz.org, virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 2/2] Unify how inflated memory is accounted in virtio balloon driver
Date: Mon, 1 Aug 2022 17:13:17 +0200 [thread overview]
Message-ID: <8ee986d7-0e3e-6b66-8c13-61fc70fa538e@redhat.com> (raw)
In-Reply-To: <20220726141047.72913-1-alexander.atanasov@virtuozzo.com>
On 26.07.22 16:10, Alexander Atanasov wrote:
> Always account inflated memory as used for both cases - with and
> without deflate on oom. Do not change total ram which can confuse
> userspace and users.
Sorry, but NAK.
This would affect existing users / user space / balloon stats. For example
HV just recently switch to properly using adjust_managed_page_count()
commit d1df458cbfdb0c3384c03c7fbcb1689bc02a746c
Author: Vitaly Kuznetsov <vkuznets@redhat.com>
Date: Wed Dec 2 17:12:45 2020 +0100
hv_balloon: do adjust_managed_page_count() when ballooning/un-ballooning
Unlike virtio_balloon/virtio_mem/xen balloon drivers, Hyper-V balloon driver
does not adjust managed pages count when ballooning/un-ballooning and this leads
to incorrect stats being reported, e.g. unexpected 'free' output.
Note, the calculation in post_status() seems to remain correct: ballooned out
pages are never 'available' and we manually add dm->num_pages_ballooned to
'commited'.
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2022-08-01 15:13 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-05 8:36 [PATCH v4 1/1] Create debugfs file with virtio balloon usage information Alexander Atanasov
2022-07-05 8:59 ` Michael S. Tsirkin
2022-07-05 9:01 ` Alexander Atanasov
2022-08-09 10:35 ` Michael S. Tsirkin
2022-08-09 13:33 ` Alexander Atanasov
2022-07-13 16:25 ` Alexander Atanasov
2022-07-14 11:35 ` David Hildenbrand
2022-07-14 13:20 ` Alexander Atanasov
2022-07-14 13:24 ` David Hildenbrand
2022-07-14 13:35 ` Alexander Atanasov
2022-07-14 13:20 ` [PATCH v5 " Alexander Atanasov
2022-07-18 11:35 ` David Hildenbrand
2022-07-25 11:27 ` Alexander Atanasov
2022-07-25 11:36 ` David Hildenbrand
2022-07-26 14:08 ` [PATCH v6 1/2] " Alexander Atanasov
2022-07-26 14:10 ` [PATCH v6 2/2] Unify how inflated memory is accounted in virtio balloon driver Alexander Atanasov
2022-08-01 15:13 ` David Hildenbrand [this message]
2022-08-09 10:42 ` Michael S. Tsirkin
2022-08-01 15:18 ` [PATCH v6 1/2] Create debugfs file with virtio balloon usage information David Hildenbrand
2022-08-01 16:34 ` Alexander Atanasov
2022-08-01 20:12 ` David Hildenbrand
2022-08-02 8:53 ` [RFC] how the ballooned memory should be accounted by the drivers inside the guests? (was:[PATCH v6 1/2] Create debugfs file with virtio balloon usage information) Alexander Atanasov
2022-08-02 13:48 ` David Hildenbrand
2022-08-09 9:36 ` Alexander Atanasov
2022-08-09 9:49 ` [PATCH v1 1/2] Enable balloon drivers to report inflated memory Alexander Atanasov
2022-08-09 9:53 ` [PATCH v1 2/2] Drivers: virtio: balloon: Report " Alexander Atanasov
2022-08-09 17:44 ` Nadav Amit
2022-08-15 12:52 ` Alexander Atanasov
2022-08-15 16:05 ` Nadav Amit
2022-08-16 7:50 ` Alexander Atanasov
2022-08-09 10:32 ` [PATCH v1 1/2] Enable balloon drivers to report " Michael S. Tsirkin
2022-08-10 5:54 ` Alexander Atanasov
2022-08-10 6:05 ` Michael S. Tsirkin
2022-08-10 7:50 ` Alexander Atanasov
2022-08-10 9:16 ` Michael S. Tsirkin
2022-08-10 3:05 ` Muchun Song
2022-08-10 5:14 ` Alexander Atanasov
2022-08-09 10:03 ` [RFC] how the ballooned memory should be accounted by the drivers inside the guests? (was:[PATCH v6 1/2] Create debugfs file with virtio balloon usage information) David Hildenbrand
2022-08-09 10:44 ` [PATCH v6 1/2] Create debugfs file with virtio balloon usage information Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ee986d7-0e3e-6b66-8c13-61fc70fa538e@redhat.com \
--to=david@redhat.com \
--cc=alexander.atanasov@virtuozzo.com \
--cc=jasowang@redhat.com \
--cc=kernel@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®