Re: [PATCH v5 6/8] serial: qcom-geni: move clock-rate logic to separate function

[Praveen Talari <quic_ptalari@quicinc.com>]

Hi Bryan,

On 6/3/2025 8:11 PM, Bryan O'Donoghue wrote:
> On 06/05/2025 19:02, Praveen Talari wrote:
>> -            "Couldn't find suitable clock rate for %u\n",
>> +            "Couldn't find suitable clock rate for %lu\n",
>>               baud * sampling_rate);
>> -        return;
>> +        return -EINVAL;
>>       }
>>
>> -    dev_dbg(port->se.dev, "desired_rate = %u, clk_rate = %lu, clk_div 
>> = %u\n",
>> -            baud * sampling_rate, clk_rate, clk_div);
>> +    dev_dbg(port->se.dev, "desired_rate = %lu, clk_rate = %lu, 
>> clk_div = %u\n",
>> +        baud * sampling_rate, clk_rate, clk_div);
> 
> Separate this stuff out.
> 
> Your code should match the commit log. If you want to convert %u to %lu 
> make a patch to do that, even if it seems trivial, it is better to make 
> granular submissions.

It comes under newly added API. Do we still need to make separate patch?

Thanks,
Praveen Talari
> 
> ---
> bod