From: Praveen Talari <quic_ptalari@quicinc.com>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
<linux-arm-msm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-serial@vger.kernel.org>, <devicetree@vger.kernel.org>
Cc: <psodagud@quicinc.com>, <djaggi@quicinc.com>,
<quic_msavaliy@quicinc.com>, <quic_vtanuku@quicinc.com>,
<quic_arandive@quicinc.com>, <quic_mnaresh@quicinc.com>,
<quic_shazhuss@quicinc.com>
Subject: Re: [PATCH v5 5/8] serial: qcom-geni: move resource control logic to separate functions
Date: Wed, 4 Jun 2025 21:40:47 +0530 [thread overview]
Message-ID: <ad91876e-508c-4f98-9b7c-c2e4a05a8276@quicinc.com> (raw)
In-Reply-To: <0daf396a-29af-458b-a7ba-3b711b22cde9@quicinc.com>
Hi Bryan
On 6/4/2025 7:39 PM, Praveen Talari wrote:
> Hi Bryan
>
> On 6/3/2025 8:16 PM, Bryan O'Donoghue wrote:
>> On 03/06/2025 15:29, Bryan O'Donoghue wrote:
>>> On 03/06/2025 15:28, Bryan O'Donoghue wrote:
>>>>> 2.17.1
>>>>>
>>>>>
>>>> Assuming you address my points.
>>>
>>> [sic]
>>>
>>> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
>>>
>>
>> Oh please fix this in the next version
> can i fix this in separate patch since i haven't touch these two lines
Sorry bit confused.
Will fix this in the same patch.
Thanks,
Praveen Talari
> or
> fix within same patch?
>
> Thanks,
> Praveen Talari
>>
>> checkpatch.pl --strict mypatch.patch
>>
>> CHECK: Alignment should match open parenthesis
>> #92: FILE: drivers/tty/serial/qcom_geni_serial.c:1675:
>> + else if (new_state == UART_PM_STATE_OFF &&
>> + old_state == UART_PM_STATE_ON)
>>
>> total: 0 errors, 0 warnings, 1 checks, 71 lines checked
>>
>> NOTE: For some of the reported defects, checkpatch may be able to
>> mechanically convert to the typical style using --fix or
>> --fix-inplace.
>>
>> 0005-serial-qcom-geni-move-resource-control-logic-to-sepa.patch has
>> style problems, please review.
>>
>> ---
>> bod
next prev parent reply other threads:[~2025-06-04 16:11 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-06 18:02 [PATCH v5 0/8] Enable QUPs and Serial on SA8255p Qualcomm platforms Praveen Talari
2025-05-06 18:02 ` [PATCH v5 1/8] dt-bindings: serial: describe SA8255p Praveen Talari
2025-05-06 18:23 ` Krzysztof Kozlowski
2025-05-08 5:45 ` Praveen Talari
2025-05-09 4:32 ` Praveen Talari
2025-05-16 6:36 ` Praveen Talari
2025-05-28 5:10 ` Praveen Talari
2025-05-06 18:02 ` [PATCH v5 2/8] dt-bindings: qcom: geni-se: " Praveen Talari
2025-05-06 18:25 ` Krzysztof Kozlowski
2025-05-06 18:02 ` [PATCH v5 3/8] soc: qcom: geni-se: Enable QUPs on SA8255p Qualcomm platforms Praveen Talari
2025-06-03 14:21 ` Bryan O'Donoghue
2025-06-04 7:28 ` Praveen Talari
2025-06-04 8:23 ` Bryan O'Donoghue
2025-05-06 18:02 ` [PATCH v5 4/8] serial: qcom-geni: move resource initialization to separate function Praveen Talari
2025-06-03 14:24 ` Bryan O'Donoghue
2025-05-06 18:02 ` [PATCH v5 5/8] serial: qcom-geni: move resource control logic to separate functions Praveen Talari
2025-06-03 14:28 ` Bryan O'Donoghue
2025-06-03 14:29 ` Bryan O'Donoghue
2025-06-03 14:46 ` Bryan O'Donoghue
2025-06-04 14:09 ` Praveen Talari
2025-06-04 16:10 ` Praveen Talari [this message]
2025-05-06 18:02 ` [PATCH v5 6/8] serial: qcom-geni: move clock-rate logic to separate function Praveen Talari
2025-06-03 14:41 ` Bryan O'Donoghue
2025-06-04 17:11 ` Praveen Talari
2025-06-04 23:49 ` Bryan O'Donoghue
2025-06-05 3:34 ` Praveen Talari
2025-05-06 18:02 ` [PATCH v5 7/8] serial: qcom-geni: Enable PM runtime for serial driver Praveen Talari
2025-06-03 14:42 ` Bryan O'Donoghue
2025-05-06 18:02 ` [PATCH v5 8/8] serial: qcom-geni: Enable Serial on SA8255p Qualcomm platforms Praveen Talari
2025-06-03 14:47 ` Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad91876e-508c-4f98-9b7c-c2e4a05a8276@quicinc.com \
--to=quic_ptalari@quicinc.com \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=djaggi@quicinc.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=psodagud@quicinc.com \
--cc=quic_arandive@quicinc.com \
--cc=quic_mnaresh@quicinc.com \
--cc=quic_msavaliy@quicinc.com \
--cc=quic_shazhuss@quicinc.com \
--cc=quic_vtanuku@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®