* [PATCH] xen/x86/vpmu: Zero struct pt_regs before calling into sample handling code
@ 2018-07-12 17:27 Boris Ostrovsky
2018-07-13 8:41 ` Juergen Gross
0 siblings, 1 reply; 3+ messages in thread
From: Boris Ostrovsky @ 2018-07-12 17:27 UTC (permalink / raw)
To: xen-devel, linux-kernel; +Cc: mark.rutland, jgross, Boris Ostrovsky, stable
Otherwise we may leak kernel stack for events that sample user
registers.
Reported-by: Mark Rutland <mark.rutland@arm.com>
Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: stable@vger.kernel.org
---
arch/x86/xen/pmu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/xen/pmu.c b/arch/x86/xen/pmu.c
index 7d00d4a..95997e6 100644
--- a/arch/x86/xen/pmu.c
+++ b/arch/x86/xen/pmu.c
@@ -478,7 +478,7 @@ static void xen_convert_regs(const struct xen_pmu_regs *xen_regs,
irqreturn_t xen_pmu_irq_handler(int irq, void *dev_id)
{
int err, ret = IRQ_NONE;
- struct pt_regs regs;
+ struct pt_regs regs = {0};
const struct xen_pmu_data *xenpmu_data = get_xenpmu_data();
uint8_t xenpmu_flags = get_xenpmu_flags();
--
1.8.3.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] xen/x86/vpmu: Zero struct pt_regs before calling into sample handling code
2018-07-12 17:27 [PATCH] xen/x86/vpmu: Zero struct pt_regs before calling into sample handling code Boris Ostrovsky
@ 2018-07-13 8:41 ` Juergen Gross
2018-09-20 16:57 ` Boris Ostrovsky
0 siblings, 1 reply; 3+ messages in thread
From: Juergen Gross @ 2018-07-13 8:41 UTC (permalink / raw)
To: Boris Ostrovsky, xen-devel, linux-kernel; +Cc: mark.rutland, stable
On 12/07/18 19:27, Boris Ostrovsky wrote:
> Otherwise we may leak kernel stack for events that sample user
> registers.
>
> Reported-by: Mark Rutland <mark.rutland@arm.com>
> Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> Cc: stable@vger.kernel.org
Reviewed-by: Juergen Gross <jgross@suse.com>
Juergen
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] xen/x86/vpmu: Zero struct pt_regs before calling into sample handling code
2018-07-13 8:41 ` Juergen Gross
@ 2018-09-20 16:57 ` Boris Ostrovsky
0 siblings, 0 replies; 3+ messages in thread
From: Boris Ostrovsky @ 2018-09-20 16:57 UTC (permalink / raw)
To: Juergen Gross, xen-devel, linux-kernel; +Cc: mark.rutland, stable
On 7/13/18 4:41 AM, Juergen Gross wrote:
> On 12/07/18 19:27, Boris Ostrovsky wrote:
>> Otherwise we may leak kernel stack for events that sample user
>> registers.
>>
>> Reported-by: Mark Rutland <mark.rutland@arm.com>
>> Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
>> Cc: stable@vger.kernel.org
> Reviewed-by: Juergen Gross <jgross@suse.com>
>
Belatedly, applied to for-linus-4.19d
-boris
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-09-20 16:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-12 17:27 [PATCH] xen/x86/vpmu: Zero struct pt_regs before calling into sample handling code Boris Ostrovsky
2018-07-13 8:41 ` Juergen Gross
2018-09-20 16:57 ` Boris Ostrovsky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®