* [PATCH v2 1/3] media: atomisp: Remove unused any_virq_signal()
2026-11-16 17:08 [PATCH v2 0/3] media: atomisp: remove unused functions Avishek Chaulagain
@ 2026-11-16 17:08 ` Avishek Chaulagain
2026-11-16 17:08 ` [PATCH v2 2/3] media: atomisp: Remove unused get_sp_code_addr() Avishek Chaulagain
2026-11-16 17:08 ` [PATCH v2 3/3] media: atomisp: Remove unused hmm_flush() Avishek Chaulagain
2 siblings, 0 replies; 4+ messages in thread
From: Avishek Chaulagain @ 2026-11-16 17:08 UTC (permalink / raw)
To: Hans de Goede, Mauro Carvalho Chehab, Greg Kroah-Hartman
Cc: Sakari Ailus, Andy Shevchenko, Dan Carpenter, linux-media,
linux-staging, linux-kernel, Avishek Chaulagain
any_virq_signal() has no callers anywhere in the tree. Remove the
unused function and its declaration.
Signed-off-by: Avishek Chaulagain <chaulagainavishek14@gmail.com>
---
.../media/atomisp/pci/hive_isp_css_common/host/irq.c | 8 --------
.../atomisp/pci/hive_isp_css_include/host/irq_public.h | 6 ------
2 files changed, 14 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/irq.c b/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/irq.c
index 61dea3863..f1b01f5f9 100644
--- a/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/irq.c
+++ b/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/irq.c
@@ -215,14 +215,6 @@ void irq_raise(
return;
}
-bool any_virq_signal(void)
-{
- unsigned int irq_status = irq_reg_load(IRQ0_ID,
- _HRT_IRQ_CONTROLLER_STATUS_REG_IDX);
-
- return (irq_status != 0);
-}
-
void cnd_virq_enable_channel(
const enum virq_id irq_ID,
const bool en)
diff --git a/drivers/staging/media/atomisp/pci/hive_isp_css_include/host/irq_public.h b/drivers/staging/media/atomisp/pci/hive_isp_css_include/host/irq_public.h
index 901e10f87..b487b7f31 100644
--- a/drivers/staging/media/atomisp/pci/hive_isp_css_include/host/irq_public.h
+++ b/drivers/staging/media/atomisp/pci/hive_isp_css_include/host/irq_public.h
@@ -103,12 +103,6 @@ void irq_raise(
const irq_ID_t ID,
const irq_sw_channel_id_t irq_id);
-/*! Test if any IRQ channel of the virtual super IRQ has raised a signal
-
- \return any(VIRQ.channel[irq_ID] != 0)
- */
-bool any_virq_signal(void);
-
/*! Enable an IRQ channel of the virtual super IRQ
\param irq[in] IRQ (channel) identifier
--
2.43.0
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH v2 2/3] media: atomisp: Remove unused get_sp_code_addr()
2026-11-16 17:08 [PATCH v2 0/3] media: atomisp: remove unused functions Avishek Chaulagain
2026-11-16 17:08 ` [PATCH v2 1/3] media: atomisp: Remove unused any_virq_signal() Avishek Chaulagain
@ 2026-11-16 17:08 ` Avishek Chaulagain
2026-11-16 17:08 ` [PATCH v2 3/3] media: atomisp: Remove unused hmm_flush() Avishek Chaulagain
2 siblings, 0 replies; 4+ messages in thread
From: Avishek Chaulagain @ 2026-11-16 17:08 UTC (permalink / raw)
To: Hans de Goede, Mauro Carvalho Chehab, Greg Kroah-Hartman
Cc: Sakari Ailus, Andy Shevchenko, Dan Carpenter, linux-media,
linux-staging, linux-kernel, Avishek Chaulagain
get_sp_code_addr() has no callers anywhere in the tree. Remove the
unused function and its declaration.
Signed-off-by: Avishek Chaulagain <chaulagainavishek14@gmail.com>
---
.../atomisp/pci/runtime/spctrl/interface/ia_css_spctrl.h | 3 ---
.../staging/media/atomisp/pci/runtime/spctrl/src/spctrl.c | 5 -----
2 files changed, 8 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/runtime/spctrl/interface/ia_css_spctrl.h b/drivers/staging/media/atomisp/pci/runtime/spctrl/interface/ia_css_spctrl.h
index 3cd69284f..f8be93e03 100644
--- a/drivers/staging/media/atomisp/pci/runtime/spctrl/interface/ia_css_spctrl.h
+++ b/drivers/staging/media/atomisp/pci/runtime/spctrl/interface/ia_css_spctrl.h
@@ -25,9 +25,6 @@ typedef struct {
char *program_name; /** not used on hardware, only for simulation */
} ia_css_spctrl_cfg;
-/* Get the code addr in DDR of SP */
-ia_css_ptr get_sp_code_addr(sp_ID_t sp_id);
-
/* ! Load firmware on to specfied SP
*/
int ia_css_spctrl_load_fw(sp_ID_t sp_id,
diff --git a/drivers/staging/media/atomisp/pci/runtime/spctrl/src/spctrl.c b/drivers/staging/media/atomisp/pci/runtime/spctrl/src/spctrl.c
index 78f00f07b..49b986351 100644
--- a/drivers/staging/media/atomisp/pci/runtime/spctrl/src/spctrl.c
+++ b/drivers/staging/media/atomisp/pci/runtime/spctrl/src/spctrl.c
@@ -104,11 +104,6 @@ void sh_css_spctrl_reload_fw(sp_ID_t sp_id)
spctrl_loaded[sp_id] = true;
}
-ia_css_ptr get_sp_code_addr(sp_ID_t sp_id)
-{
- return spctrl_cofig_info[sp_id].code_addr;
-}
-
int ia_css_spctrl_unload_fw(sp_ID_t sp_id)
{
if ((sp_id >= N_SP_ID) || ((sp_id < N_SP_ID) && (!spctrl_loaded[sp_id])))
--
2.43.0
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH v2 3/3] media: atomisp: Remove unused hmm_flush()
2026-11-16 17:08 [PATCH v2 0/3] media: atomisp: remove unused functions Avishek Chaulagain
2026-11-16 17:08 ` [PATCH v2 1/3] media: atomisp: Remove unused any_virq_signal() Avishek Chaulagain
2026-11-16 17:08 ` [PATCH v2 2/3] media: atomisp: Remove unused get_sp_code_addr() Avishek Chaulagain
@ 2026-11-16 17:08 ` Avishek Chaulagain
2 siblings, 0 replies; 4+ messages in thread
From: Avishek Chaulagain @ 2026-11-16 17:08 UTC (permalink / raw)
To: Hans de Goede, Mauro Carvalho Chehab, Greg Kroah-Hartman
Cc: Sakari Ailus, Andy Shevchenko, Dan Carpenter, linux-media,
linux-staging, linux-kernel, Avishek Chaulagain
hmm_flush() has no callers anywhere in the tree. Remove the
unused function and its declaration.
Signed-off-by: Avishek Chaulagain <chaulagainavishek14@gmail.com>
---
drivers/staging/media/atomisp/include/hmm/hmm.h | 1 -
drivers/staging/media/atomisp/pci/hmm/hmm.c | 6 ------
2 files changed, 7 deletions(-)
diff --git a/drivers/staging/media/atomisp/include/hmm/hmm.h b/drivers/staging/media/atomisp/include/hmm/hmm.h
index a7aef27f5..545bb52c5 100644
--- a/drivers/staging/media/atomisp/include/hmm/hmm.h
+++ b/drivers/staging/media/atomisp/include/hmm/hmm.h
@@ -32,7 +32,6 @@ void hmm_free(ia_css_ptr ptr);
int hmm_load(ia_css_ptr virt, void *data, unsigned int bytes);
int hmm_store(ia_css_ptr virt, const void *data, unsigned int bytes);
int hmm_set(ia_css_ptr virt, int c, unsigned int bytes);
-int hmm_flush(ia_css_ptr virt, unsigned int bytes);
/*
* get kernel memory physical address from ISP virtual address.
diff --git a/drivers/staging/media/atomisp/pci/hmm/hmm.c b/drivers/staging/media/atomisp/pci/hmm/hmm.c
index f998b57f9..5dff2edb5 100644
--- a/drivers/staging/media/atomisp/pci/hmm/hmm.c
+++ b/drivers/staging/media/atomisp/pci/hmm/hmm.c
@@ -262,12 +262,6 @@ int hmm_load(ia_css_ptr virt, void *data, unsigned int bytes)
return load_and_flush(virt, data, bytes);
}
-/* Flush hmm data from the data cache */
-int hmm_flush(ia_css_ptr virt, unsigned int bytes)
-{
- return load_and_flush(virt, NULL, bytes);
-}
-
/* Write function in ISP memory management */
int hmm_store(ia_css_ptr virt, const void *data, unsigned int bytes)
{
--
2.43.0
^ permalink raw reply [flat|nested] 4+ messages in thread