From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Abhinav Kumar <quic_abhinavk@quicinc.com>,
Rob Clark <robdclark@gmail.com>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Sean Paul <sean@poorly.run>,
Marijn Suijten <marijn.suijten@somainline.org>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
Kuogee Hsieh <quic_khsieh@quicinc.com>
Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] drm/msm/dpu: Fix SC7280 PP length
Date: Thu, 21 Sep 2023 09:01:50 +0200 [thread overview]
Message-ID: <8f24963f-a016-3095-29da-a2fcae5ec9eb@linaro.org> (raw)
In-Reply-To: <3b23270c-ec89-2177-8252-6ccaf58d37ac@quicinc.com>
On 9/21/23 01:41, Abhinav Kumar wrote:
>
>
> On 9/20/2023 3:46 PM, Konrad Dybcio wrote:
>> Commit 194347df5844 ("drm/msm/dpu: inline DSC_BLK and DSC_BLK_1_2
>> macros") unrolled a macro incorrectly. Fix that.
>>
>
> No, its correct from what i can tell.
>
> Before inlining it was using PP_BLK_DITHER macro and not PP_BLK.
>
> PP_BLK_DITHER has a len of 0 and not 0xd4.
>
> Hence I cannot see whats wrong here.
Right, I misread the thing..
Konrad
next prev parent reply other threads:[~2023-09-21 20:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-20 22:46 [PATCH 0/3] SC7280 DPU fixups Konrad Dybcio
2023-09-20 22:46 ` [PATCH 1/3] drm/msm/dpu: Fix SC7280 PP length Konrad Dybcio
2023-09-20 23:41 ` Abhinav Kumar
2023-09-21 7:01 ` Konrad Dybcio [this message]
2023-09-20 22:46 ` [PATCH 2/3] drm/msm/dpu: Add missing DPU_DSC_OUTPUT_CTRL to SC7280 Konrad Dybcio
2023-09-21 0:01 ` Abhinav Kumar
2023-09-21 7:04 ` Konrad Dybcio
2023-09-20 22:46 ` [PATCH 3/3] drm/msm/dpu: Fix SC7280 DSC block length Konrad Dybcio
2023-09-21 0:10 ` Abhinav Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f24963f-a016-3095-29da-a2fcae5ec9eb@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_khsieh@quicinc.com \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®